| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| | |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
http://trac.openidenabled.com/trac/ticket/337
(http://trac.openidenabled.com/trac/attachment/ticket/337/php-openid-php5.3.patch)
Patch makes php-openid library compatible with PHP 5.3, and included changes to many files.
Original Message:
Reported by: http://bfarber.myopenid.com/
Opened 7 months ago
Last modified 2 months ago
PHP OpenID libraries do not work on PHP 5.3
"In my own application the script simply stops working at
function Auth_OpenID_setNoMathSupport() {
if (!defined('Auth_OpenID_NO_MATH_SUPPORT')) {
define('Auth_OpenID_NO_MATH_SUPPORT', true);
}
}
(Namespace issue perhaps?)
I downloaded the latest 2.1.3 libraries available from the site here and set them up on my local server. Using PHP 5.2.9 they work fine (with some notices) however using PHP 5.3 they don't work at all. I just get this one a white screen
Deprecated: Assigning the return value of new by reference is deprecated in C:\wamp\www\openid\php-openid-2.1.3\examples\consumer\common.php on line 72
Deprecated: Assigning the return value of new by reference is deprecated in C:\wamp\www\openid\php-openid-2.1.3\Auth\OpenID\Consumer.php on line 271
Deprecated: Assigning the return value of new by reference is deprecated in C:\wamp\www\openid\php-openid-2.1.3\Auth\OpenID\Consumer.php on line 273"
It should be noted that 34 hunks across about 22 files failed, and I applied most of them manually. 37 files were patched.
|
| |
|
|
|
|
|
|
|
|
|
|
| |
Reviewed By: Will Norris
Facebook has a policy to not have closing ?> tags at the bottom of PHP
files. It can unintentionally introduce newlines which causes
ridiculous bugs.
This is recommended in the Zend style guide:
http://framework.zend.com/manual/en/coding-standard.php-file-formatting.html
Signed-off-by: Will Norris <will@willnorris.com>
|
| |
|
|
|
|
| |
This reverts commit a2bdc5c6129ff11b1c1e29a207b1b80153ac6fb0.
I'm going to stop playing in bce's fork, and start messing in my own. Sorry for the mess Brian :)
|
| |
|
|
|
|
|
|
|
|
| |
Reviewed By: Will Norris
Facebook has a policy to not have closing ?> tags at the bottom of PHP files. It
can unintentionally introduce newlines which causes ridiculous bugs.
This is recommended in the Zend style guide:
http://framework.zend.com/manual/en/coding-standard.php-file-formatting.html
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Reviewed By: Will Norris
The set of tests assumes PHPUnit 2.3, which conflicts with my environment setup.
I think PHPUnit 3.3 is pretty widespread now, and under active maintenance
(latest rev 4/10/2009).
There's a few changes included here. I did a few mostly automated code
transformations:
replace "PHPUnit_TestCase" "PHPUnit_Framework_TestCase"
replace "PHPUnit_TestSuite" "PHPUnit_Framework_TestSuite"
removed all require_once "PHPUnit.php" - they are unnecessary.
"call by reference" is now deprecated, so changed "&$" to "$"
I also made a few changes to admin/testtext.php and Tests/TestDriver.php to
accomodate the new syntax.
Note that this just upgrades the framework; it does not guarantee that all tests
pass. I'll submit future diffs to fix or disable failing unit tests. I wasn't
able to get the tests running with the previous version, so I don't know if
these have always been failing.
I doubt that the github has automatically running unit tests, but if so then
we'll have to make sure that the central repo is running the same version of
PHPUnit.
|
| | |
|
| |
|
|
| |
Auth_Yadis_DiscoveryResult::usedYadisLocation, add Auth_Yadis_getServiceEndpoints, tests]
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| |
|
|
|
|
|
| |
Fixes #23.]
Everything that uses manifest.txt relies on the network, so this isn't
adding significantly more network overhead, and it lets us update it easier.
|
| | |
|
| | |
|
| | |
|
| |
|
