| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
| |
|
|
|
|
| |
is not available the old mechanisms are used.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
http://trac.openidenabled.com/trac/ticket/337
(http://trac.openidenabled.com/trac/attachment/ticket/337/php-openid-php5.3.patch)
Patch makes php-openid library compatible with PHP 5.3, and included changes to many files.
Original Message:
Reported by: http://bfarber.myopenid.com/
Opened 7 months ago
Last modified 2 months ago
PHP OpenID libraries do not work on PHP 5.3
"In my own application the script simply stops working at
function Auth_OpenID_setNoMathSupport() {
if (!defined('Auth_OpenID_NO_MATH_SUPPORT')) {
define('Auth_OpenID_NO_MATH_SUPPORT', true);
}
}
(Namespace issue perhaps?)
I downloaded the latest 2.1.3 libraries available from the site here and set them up on my local server. Using PHP 5.2.9 they work fine (with some notices) however using PHP 5.3 they don't work at all. I just get this one a white screen
Deprecated: Assigning the return value of new by reference is deprecated in C:\wamp\www\openid\php-openid-2.1.3\examples\consumer\common.php on line 72
Deprecated: Assigning the return value of new by reference is deprecated in C:\wamp\www\openid\php-openid-2.1.3\Auth\OpenID\Consumer.php on line 271
Deprecated: Assigning the return value of new by reference is deprecated in C:\wamp\www\openid\php-openid-2.1.3\Auth\OpenID\Consumer.php on line 273"
It should be noted that 34 hunks across about 22 files failed, and I applied most of them manually. 37 files were patched.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
http://lists.openidenabled.com/pipermail/dev/attachments/20090101/217f2590/attachment.bin
Original Message:
dev-list-openidenabled at thequod.de dev-list-openidenabled at thequod.de
Thu Jan 1 18:14:12 PST 2009
darcs patch: php-openid-urldecode-urlparamkey
"This patch also decodes the key of URL params, which is
required for param names like 'action[foo]' when the browser sends those
urlencoded (Konqueror 4.2 does so).
I would like to propose using rawurldecode instead of urldecode, too, but
that causes the tests to fail and may be against the OpenID spec
(the difference is only that "+" gets decoded with urldecode() but not
with rawurldecode IIRC)"
This patch was in the form of a Darcs patch, not a normal patch. So solve this, I applied it to the Darcs repository found on openidenabled, then created a new diff file between the original Darcs repo and the new one (with the patch applied) so that I could apply it to this git repo.
All hunks were applied successfully.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
http://lists.openidenabled.com/pipermail/dev/attachments/20080221/f087874e/attachment.obj
Original Messages:
Ryan Patterson cgamesplay at cgamesplay.com
Thu Feb 21 10:57:56 PST 2008
OpenIDStore for PEAR::MDB2
"On Thu, Feb 21, 2008 at 10:24 AM, Thomas Harning
<thomas.harning at trustbearer.com> wrote:
> Shortening the URLs to 255 chars has some ugly problems since the spec states
> that the max Server URL can technically be up to 2047 bytes (per OpenID 1.1-Appendix D)
Ah, I glanced at the spec but didn't see anything.
> One option for databases that can't have a key large enough is using a prefix-based key...
> I know MySQL supports this, but I'm not so sure on others.
This is what the current SQLStore implementation does. I've modified
the patch to add specific SQL for mysql backends, but use MDB2's
generic table creation for other stores. The test cases in the patch
pass for MDB2 using MySQL, but I'd like to verify that it works with
PostgreSQL.
--
Regards,
Ryan Patterson <mailto:cgamesplay at cgamesplay.com>"
Thomas Harning thomas.harning at trustbearer.com
Thu Feb 21 07:24:02 PST 2008
OpenIDStore for PEAR::MDB2
"Ryan Patterson wrote:
> I've created an Auth_OpenID_OpenIDStore implementation that utilizes
> PEAR::MDB2 instead of PEAR::DB, called Auth_OpenID_MDB2Store. The
> advantages to this store are that it supports all database back ends
> that PEAR::MDB2 supports, and does not require the user to know which
> database back end is being used when instantiating the store. Because
> of the complete database abstraction, the entire store is
> approximately 350 lines shorter than the SQLStore family.
>
> As a note to users planning to test this store: the table schema is
> incompatible with the other SQLStores. Specifically, the length of
> server URLs has been shortened to 255 characters to allow cross-RDBMS
> compatibility, and the field types have been changed to NOT NULL. You
> may safely delete your associations and nonces tables with no
> consequences.
Shortening the URLs to 255 chars has some ugly problems since the spec states
that the max Server URL can technically be up to 2047 bytes (per OpenID 1.1-Appendix D)
One option for databases that can't have a key large enough is using a prefix-based key...
I know MySQL supports this, but I'm not so sure on others.
Another option would be to use a unique value as the primary key and use some ugly
mechanics so that you can store a 20 byte sha1 in a non-unique index and the server URL
not in an index.
The basic select would be SELECT * FROM Sites WHERE URLHash = ? AND URL = ?;
The URLHash would narrow it down to likely one, where URL would clobber potential
collisions and keep the data around if needed...
--
Thomas Harning @ TrustBearer Labs (http://www.trustbearer.com)
Secure OpenID: https://openid.trustbearer.com/harningt
3201 Stellhorn Road 260-399-1656
Fort Wayne, IN 46815"
OpenIDStore for PEAR::MDB2
Ryan Patterson cgamesplay at cgamesplay.com
Thu Feb 21 07:19:02 PST 2008
"I've created an Auth_OpenID_OpenIDStore implementation that utilizes
PEAR::MDB2 instead of PEAR::DB, called Auth_OpenID_MDB2Store. The
advantages to this store are that it supports all database back ends
that PEAR::MDB2 supports, and does not require the user to know which
database back end is being used when instantiating the store. Because
of the complete database abstraction, the entire store is
approximately 350 lines shorter than the SQLStore family.
As a note to users planning to test this store: the table schema is
incompatible with the other SQLStores. Specifically, the length of
server URLs has been shortened to 255 characters to allow cross-RDBMS
compatibility, and the field types have been changed to NOT NULL. You
may safely delete your associations and nonces tables with no
consequences.
A test case has been added that tests the MDB2 store with a MySQL
backend. I would appreciate it if someone capable could modify the
test case and test it using PostgreSQL, to ensure that the database
abstraction I've used is correct.
--
Regards,
Ryan Patterson <mailto:cgamesplay at cgamesplay.com>"
All of the patch's hunks were applied successfully.
|
|
|
|
| |
openidenabled.com's repo after the repo was moved to git hub
|
|
|
|
|
|
|
|
|
|
|
|
| |
Reviewed By: Will Norris
Facebook has a policy to not have closing ?> tags at the bottom of PHP
files. It can unintentionally introduce newlines which causes
ridiculous bugs.
This is recommended in the Zend style guide:
http://framework.zend.com/manual/en/coding-standard.php-file-formatting.html
Signed-off-by: Will Norris <will@willnorris.com>
|
|
|
|
|
|
| |
This reverts commit a2bdc5c6129ff11b1c1e29a207b1b80153ac6fb0.
I'm going to stop playing in bce's fork, and start messing in my own. Sorry for the mess Brian :)
|
|
|
|
| |
This reverts commit f963a700e4440074a5b86d382789e75795206482.
|
|
|
|
|
|
|
|
| |
In the last commit, I over-aggressively removed closing PHP tags.
While I dislike the practice of using close tags within templates,
it is how this library works, so let's put them back.
Checked that all PHP compiles with "php -l".
|
|
|
|
|
|
|
|
|
|
| |
Reviewed By: Will Norris
Facebook has a policy to not have closing ?> tags at the bottom of PHP files. It
can unintentionally introduce newlines which causes ridiculous bugs.
This is recommended in the Zend style guide:
http://framework.zend.com/manual/en/coding-standard.php-file-formatting.html
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Reviewed By: Will Norris
The set of tests assumes PHPUnit 2.3, which conflicts with my environment setup.
I think PHPUnit 3.3 is pretty widespread now, and under active maintenance
(latest rev 4/10/2009).
There's a few changes included here. I did a few mostly automated code
transformations:
replace "PHPUnit_TestCase" "PHPUnit_Framework_TestCase"
replace "PHPUnit_TestSuite" "PHPUnit_Framework_TestSuite"
removed all require_once "PHPUnit.php" - they are unnecessary.
"call by reference" is now deprecated, so changed "&$" to "$"
I also made a few changes to admin/testtext.php and Tests/TestDriver.php to
accomodate the new syntax.
Note that this just upgrades the framework; it does not guarantee that all tests
pass. I'll submit future diffs to fix or disable failing unit tests. I wasn't
able to get the tests running with the previous version, so I don't know if
these have always been failing.
I doubt that the github has automatically running unit tests, but if so then
we'll have to make sure that the central repo is running the same version of
PHPUnit.
|
| |
|
| |
|
| |
|
| |
|
|
|
|
| |
or hostname]
|
| |
|
|
|
|
|
|
|
|
| |
messages that we create]
This makes the library compatible with the 1.x series of this library,
since it did not handle arbitrary query keys with dots in them (PHP
mangles . to _)
|
|
|
|
|
|
|
| |
message: allow two values for OPENID1_NS
Also:
* fix op_endpoint bug in Server.php
* always treat OpenID 1 namespace as implicit in messages we create
|
|
|
|
| |
Auth_OpenID_OPENID1_NS anywhere in server]
|
| |
|
|
|
|
| |
Auth_Yadis_DiscoveryResult::usedYadisLocation, add Auth_Yadis_getServiceEndpoints, tests]
|
|
|
|
| |
class type]
|
| |
|
|
|
|
| |
the OpenID Message object instead of null]
|
|
|
|
| |
of PHP 4.3 so the build passes]
|
| |
|
| |
|
| |
|
| |
|
|
|
|
| |
in Server.php]
|
| |
|
| |
|
|
|
|
| |
exposed]
|
|
|
|
| |
Auth_OpenID_ServerError if claimed_id is provided without identity]
|
|
|
|
| |
has an Auth_OpenID_Message after encountering invalid OpenID namespace]
|
|
|
|
| |
trust_root/realm]
|
| |
|
| |
|
|
|
|
| |
no ax args]
|
| |
|
| |
|
| |
|
|
|
|
| |
1.1 endpoint cannot be found]
|
| |
|
|
|
|
| |
name into its own function]
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
|
|
|
| |
object instead of Auth_OpenID_Message object so that it matches it's counterpart methods in SREG and PAPE extensions.]
|
| |
|
| |
|
|
|
|
| |
(OpenID 2 compliance)]
|
|
|
|
| |
attributes]
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
|
|
|
|
|
|
|
| |
includes supportsCleanup() function for OpenIDStore interface, as memcache doesn't allow ]
enumeration of all keys used (and cleans itself).
Also included test for memcached storage and support for supportsCleanup() in test functions.
|
| |
|
| |
|
| |
|
|
|
|
|
|
| |
- Removed extra newline.
- Changed comment in test_sqlitestore() to read 'sqlite' instead of
'postgres'.
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Mac OS X 10.5 generates a value for $TMPDIR that looks something like
this:
/var/folders/uU/uXMNhbRIGkOhaxcg60xSGU+++TI/-Tmp-/
The '+++' is causing the DSN in Tests_Auth_OpenID_StoreTest::test_sqlitestore
to become invalid. This invalid DSN causes the SQLite driver to attempt
creating a file at a nonexistant path, resulting in a failed test. This is
fixed by wrapping the value of $TMPDIR received by the system in a call to
urlencode().
|
|
|
|
|
|
|
|
| |
Use time() instead of (gm)mktime(), when used for getting the current
time (called without arguments).
According to "hunk ./Auth/OpenID/Nonce.php 99" gmmktime() for PHP4 is
buggy and using mktime() makes no sense when called without args:
just use time() then directly.
|
| |
|
| |
|
| |
|
|
|
|
| |
calls to consumer]
|
|
|
|
| |
session types are allowed by OpenID]
|
|
|
|
| |
failure when mode is not id_res)]
|
| |
|
| |
|
| |
|
| |
|
| |
|
|
|
|
| |
FetchResponse]
|
| |
|
| |
|
| |
|
|
|
|
| |
request]
|
| |
|
|
|
|
|
|
|
|
| |
- OpenID 1 only: Add claimed_id to return_to in requests
- OpenID 1, 2: Do discovery on response's claimed_id in the absence of
session storage
- OpenID 1: Do discovery verification on claimed_id in response rather than
the one in the session
|
|
|
|
| |
from return_to]
|
| |
|
| |
|
| |
|
| |
|
| |
|