summaryrefslogtreecommitdiffstats
path: root/Tests/Auth/OpenID/Extension.php
Commit message (Collapse)AuthorAgeFilesLines
* [ remove closing ?> tag from all files ]Luke Shepard2009-05-281-1/+0
| | | | | | | | | | | | Reviewed By: Will Norris Facebook has a policy to not have closing ?> tags at the bottom of PHP files. It can unintentionally introduce newlines which causes ridiculous bugs. This is recommended in the Zend style guide: http://framework.zend.com/manual/en/coding-standard.php-file-formatting.html Signed-off-by: Will Norris <will@willnorris.com>
* Revert "[ remove closing ?> tag from all files ]"Luke Shepard2009-05-271-0/+1
| | | | | | This reverts commit a2bdc5c6129ff11b1c1e29a207b1b80153ac6fb0. I'm going to stop playing in bce's fork, and start messing in my own. Sorry for the mess Brian :)
* [ remove closing ?> tag from all files ]Luke Shepard2009-05-271-1/+0
| | | | | | | | | | Reviewed By: Will Norris Facebook has a policy to not have closing ?> tags at the bottom of PHP files. It can unintentionally introduce newlines which causes ridiculous bugs. This is recommended in the Zend style guide: http://framework.zend.com/manual/en/coding-standard.php-file-formatting.html
* [ Upgrading php-openid test framework to use PHPUnit 3.3 ]Luke Shepard2009-05-271-2/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Reviewed By: Will Norris The set of tests assumes PHPUnit 2.3, which conflicts with my environment setup. I think PHPUnit 3.3 is pretty widespread now, and under active maintenance (latest rev 4/10/2009). There's a few changes included here. I did a few mostly automated code transformations: replace "PHPUnit_TestCase" "PHPUnit_Framework_TestCase" replace "PHPUnit_TestSuite" "PHPUnit_Framework_TestSuite" removed all require_once "PHPUnit.php" - they are unnecessary. "call by reference" is now deprecated, so changed "&$" to "$" I also made a few changes to admin/testtext.php and Tests/TestDriver.php to accomodate the new syntax. Note that this just upgrades the framework; it does not guarantee that all tests pass. I'll submit future diffs to fix or disable failing unit tests. I wasn't able to get the tests running with the previous version, so I don't know if these have always been failing. I doubt that the github has automatically running unit tests, but if so then we'll have to make sure that the central repo is running the same version of PHPUnit.
* [project @ Do not send namespace aliases for extensions with OpenID 1 ↵tailor2008-06-061-0/+46
messages that we create] This makes the library compatible with the 1.x series of this library, since it did not handle arbitrary query keys with dots in them (PHP mangles . to _)