| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| | |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Yadis' ParseHTML.php has a replaceEntities() function for replacing HTML
entities, with a comment that appears to explain its existence by stating
"Replace numeric entities because html_entity_decode doesn't do it for us".
This is breaking with PHP 5.5 because it uses the deprecated /e modifier
for preg_replace() - https://github.com/openid/php-openid/issues/108 .
I think this custom function is no longer needed at least with PHP 5. PHP 5
has had support for replacing numeric entities since 2003, and its entity
handling code has been refined quite a lot since then. replaceEntities() has
been there since 2006, and probably earlier. I guess at that time PHP 4
compatibility was still important so this was needed - I don't think PHP 4's
html_entity_decode() has ever had numeric entity support - but now PHP 5 is
a decade old and there's a separate PHP 4 branch of php-openid, I think we
can ditch replaceEntities() in the main branch!
|
| |
|
|
|
|
|
|
|
|
|
|
| |
Reviewed By: Will Norris
Facebook has a policy to not have closing ?> tags at the bottom of PHP
files. It can unintentionally introduce newlines which causes
ridiculous bugs.
This is recommended in the Zend style guide:
http://framework.zend.com/manual/en/coding-standard.php-file-formatting.html
Signed-off-by: Will Norris <will@willnorris.com>
|
| |
|
|
|
|
| |
This reverts commit a2bdc5c6129ff11b1c1e29a207b1b80153ac6fb0.
I'm going to stop playing in bce's fork, and start messing in my own. Sorry for the mess Brian :)
|
| |
|
|
|
|
|
|
|
|
| |
Reviewed By: Will Norris
Facebook has a policy to not have closing ?> tags at the bottom of PHP files. It
can unintentionally introduce newlines which causes ridiculous bugs.
This is recommended in the Zend style guide:
http://framework.zend.com/manual/en/coding-standard.php-file-formatting.html
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| |
|
