| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
|\
| |
| | |
Add warning when you disable SSL, don't be silly please
|
| | |
|
| | |
|
|/ |
|
|\
| |
| | |
Add Auth_OpenID_DISABLE_SSL_VERIFY opt to disable SSL verify
|
| | |
|
| | |
|
|/
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Yadis' ParseHTML.php has a replaceEntities() function for replacing HTML
entities, with a comment that appears to explain its existence by stating
"Replace numeric entities because html_entity_decode doesn't do it for us".
This is breaking with PHP 5.5 because it uses the deprecated /e modifier
for preg_replace() - https://github.com/openid/php-openid/issues/108 .
I think this custom function is no longer needed at least with PHP 5. PHP 5
has had support for replacing numeric entities since 2003, and its entity
handling code has been refined quite a lot since then. replaceEntities() has
been there since 2006, and probably earlier. I guess at that time PHP 4
compatibility was still important so this was needed - I don't think PHP 4's
html_entity_decode() has ever had numeric entity support - but now PHP 5 is
a decade old and there's a separate PHP 4 branch of php-openid, I think we
can ditch replaceEntities() in the main branch!
|
|\
| |
| | |
issue #8 fix (PHP 5.4 call-time pass-by-reference removed)
|
| | |
|
| |
| |
| | |
libxml_disable_entity_loader (PHP 5 >= 5.2.11)
|
|/
|
|
| |
thanks to Kousuke Ebihara for the report and patch.
|
| |
|
| |
|
|\
| |
| | |
Removed logging calls for a successful retrieval, as the PlainHTTPFetcher doesn't perform logging on a successful commit.
|
| |
| |
| |
| | |
doesn't perform logging on a successful commit.
|
| | |
|
| | |
|
| |
| |
| |
| | |
partially fixes #38
|
| |
| |
| |
| | |
make it a little more readable and obvious what we're doing here
|
|/
|
|
| |
verification on and off, or leaving the defaults as-is.
|
| |
|
|
|
|
|
|
|
|
|
| |
Auth/OpenID/Parse.php
The match() function takes a reference parameter $match and, depending on execution flow, either returns that as an array or a string. This has been modified to now return an array in both cases.
Auth/OpenID/Consumer.php
Auth/Yadis/Manager.php
Fixed two function calls with explicit call-by-reference parameters.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
http://trac.openidenabled.com/trac/ticket/338
(http://trac.openidenabled.com/trac/attachment/ticket/338/openid-php5.3.diff)
Patch makes php-openid library compatible with PHP 5.3, and included changes to many files.
Original Message:
Reported by: http://paulisageek.com/
Opened 6 months ago
Last modified 2 months ago
php openid library doesn't seem to work with php 5.3
"I get many PHP warnings and then the error condition on the Consumer.
Deprecated: Assigning the return value of new by reference is deprecated in *path*/Auth/OpenID/Consumer.php on line 271
Deprecated: Assigning the return value of new by reference is deprecated in *path*/Auth/OpenID/Consumer.php on line 273
Warning: Parameter 1 to filter_MatchesAnyOpenIDType() expected to be a reference, value given in *path*/Auth/Yadis/XRDS.php on line 431
Warning: Parameter 2 to Auth_OpenID_GenericConsumer::_completeInvalid() expected to be a reference, value given in *path*/Auth/OpenID/Consumer.php on line 669 "
It should be noted that 3 hunks across 7 files failed, and I applied most of them manually. 7 files were patched.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
http://trac.openidenabled.com/trac/ticket/337
(http://trac.openidenabled.com/trac/attachment/ticket/337/php-openid-php5.3.patch)
Patch makes php-openid library compatible with PHP 5.3, and included changes to many files.
Original Message:
Reported by: http://bfarber.myopenid.com/
Opened 7 months ago
Last modified 2 months ago
PHP OpenID libraries do not work on PHP 5.3
"In my own application the script simply stops working at
function Auth_OpenID_setNoMathSupport() {
if (!defined('Auth_OpenID_NO_MATH_SUPPORT')) {
define('Auth_OpenID_NO_MATH_SUPPORT', true);
}
}
(Namespace issue perhaps?)
I downloaded the latest 2.1.3 libraries available from the site here and set them up on my local server. Using PHP 5.2.9 they work fine (with some notices) however using PHP 5.3 they don't work at all. I just get this one a white screen
Deprecated: Assigning the return value of new by reference is deprecated in C:\wamp\www\openid\php-openid-2.1.3\examples\consumer\common.php on line 72
Deprecated: Assigning the return value of new by reference is deprecated in C:\wamp\www\openid\php-openid-2.1.3\Auth\OpenID\Consumer.php on line 271
Deprecated: Assigning the return value of new by reference is deprecated in C:\wamp\www\openid\php-openid-2.1.3\Auth\OpenID\Consumer.php on line 273"
It should be noted that 34 hunks across about 22 files failed, and I applied most of them manually. 37 files were patched.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
http://lists.openidenabled.com/pipermail/dev/attachments/20090928/2d616914/attachment.bin
Original Message:
anthony.lenton at canonical.com anthony.lenton at canonical.com
Mon Sep 28 11:30:12 PDT 2009
darcs patch: cURL verify host
"With this patch, if you define Auth_Openid_VERIFY_HOST cURL will enable host verification on ssl connections, for added security."
This patch was in the form of a Darcs patch, not a normal patch. So solve this, I applied it to the Darcs repository found on openidenabled, then created a new diff file between the original Darcs repo and the new one (with the patch applied) so that I could apply it to this git repo.
All hunks were applied successfully.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
http://lists.openidenabled.com/pipermail/dev/attachments/20090206/f0d91666/attachment-0001.bin
Original Message:
will at willnorris.com will at willnorris.com
Fri Feb 6 14:56:12 PST 2009
darcs patch: Properly handle Yadis discovery failure
"The library does not curently handle failures during Yadis discovery properly. Specifically, if Yadis discovery fails, and discovery WAS being done with an XRDS document, then non-Yadis discovery should be attempted.
The use-case I'm dealing with right now that exposes this bug is when an XRDS document location is advertised (via HTTP response header or <meta /> HTML tag), but the document is not able to be retrieved for whatever reason. The library is failing in this case, instead of continuing to attempt non-Yadis discovery.
This patch includes two changes:
- change to Yadis/Yadis.php that properly detects if XRDS was used
- change to OpenID/Discovery.php that prevents discovery from halting in the
above example"
This patch was in the form of a Darcs patch, not a normal patch. So solve this, I applied it to the Darcs repository found on openidenabled, then created a new diff file between the original Darcs repo and the new one (with the patch applied) so that I could apply it to this git repo.
All hunks were applied successfully.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
http://lists.openidenabled.com/pipermail/dev/attachments/20090109/7e344691/attachment-0001.bin
Original Message:
ketmar at ketmar.no-ip.org ketmar at ketmar.no-ip.org
Fri Jan 9 07:51:35 PST 2009
darcs patch: fix for incomplete URIs in "location" http field (for ...
"* fix for incomplete URIs in "location" http field (for technorati and maybe others)"
This patch was in the form of a Darcs patch, not a normal patch. So solve this, I applied it to the Darcs repository found on openidenabled, then created a new diff file between the original Darcs repo and the new one (with the patch applied) so that I could apply it to this git repo.
Hunks were applied successfully.
|
|
|
|
|
|
|
|
|
|
|
|
| |
Reviewed By: Will Norris
Facebook has a policy to not have closing ?> tags at the bottom of PHP
files. It can unintentionally introduce newlines which causes
ridiculous bugs.
This is recommended in the Zend style guide:
http://framework.zend.com/manual/en/coding-standard.php-file-formatting.html
Signed-off-by: Will Norris <will@willnorris.com>
|
|
|
|
|
|
| |
This reverts commit a2bdc5c6129ff11b1c1e29a207b1b80153ac6fb0.
I'm going to stop playing in bce's fork, and start messing in my own. Sorry for the mess Brian :)
|
|
|
|
|
|
|
|
|
|
| |
Reviewed By: Will Norris
Facebook has a policy to not have closing ?> tags at the bottom of PHP files. It
can unintentionally introduce newlines which causes ridiculous bugs.
This is recommended in the Zend style guide:
http://framework.zend.com/manual/en/coding-standard.php-file-formatting.html
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Reviewed By: Will Norris
The set of tests assumes PHPUnit 2.3, which conflicts with my environment setup.
I think PHPUnit 3.3 is pretty widespread now, and under active maintenance
(latest rev 4/10/2009).
There's a few changes included here. I did a few mostly automated code
transformations:
replace "PHPUnit_TestCase" "PHPUnit_Framework_TestCase"
replace "PHPUnit_TestSuite" "PHPUnit_Framework_TestSuite"
removed all require_once "PHPUnit.php" - they are unnecessary.
"call by reference" is now deprecated, so changed "&$" to "$"
I also made a few changes to admin/testtext.php and Tests/TestDriver.php to
accomodate the new syntax.
Note that this just upgrades the framework; it does not guarantee that all tests
pass. I'll submit future diffs to fix or disable failing unit tests. I wasn't
able to get the tests running with the previous version, so I don't know if
these have always been failing.
I doubt that the github has automatically running unit tests, but if so then
we'll have to make sure that the central repo is running the same version of
PHPUnit.
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
| |
ParanoidHTTPFetcher-strpos-instead-of-preg_match-and-code-improvements]
ParanoidHTTPFetcher:
- Fix corner case in get() and post() for headers without any value
(e.g. 'Expires:')
- Use strpos() instead of preg_match() when looking for ":" (and
look for ": " now instead)
|
| |
|
|
|
|
|
|
|
| |
1. There should only be a single CanonicalID in each XRD (in the latest XRI
resolution spec), so I made it use the first CID found instead of the last.
2. Use case-insensitive comparison when comparing CanonicalIDs.
|
| |
|
| |
|
|
|
|
| |
parameter]
|
|
|
|
| |
Auth_Yadis_DiscoveryResult::usedYadisLocation, add Auth_Yadis_getServiceEndpoints, tests]
|
|
|
|
| |
array or not.]
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
|
|
|
|
| |
Some http servers strictly follow http spec and do not send html reply when text/html isn't listed in Accept: header. Because of
this YADIS discovery fails for these servers. This patch adds 'text/html' to Accept: header.
|
| |
|
| |
|
| |
|
| |
|
| |
|
|
|
|
| |
http://ols2000.myopenid.com/)]
|
|
|
|
| |
The official documentation lies, curl_version() returns an array in PHP 5 and a string in PHP 4.
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
'Location:' header]
If an HTTP redirect was issued during discovery with a 'Location:' header that
doesn't exactly match case (such as 'location:' or 'LOCATION:'), discovery
would fail. This is incorrect behavior per RFC 2616, Section 4.2.
This behavior is corrected by using a case insensitive compare when checking
for HTTP redirects.
|
| |
|
| |
|
|
|
|
| |
request]
|
|
|
|
| |
of an XRD]
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
|
|