| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
| |
|
|\
| |
| | |
Fix DB requirement in README fixes #124
|
|/ |
|
|\
| |
| | |
Fixes CVE-2014-8150
|
|/
|
|
| |
Thanks for reporting and patching this Andrey!
|
|\
| |
| | |
loop over directories "the right way"
|
|/
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
See http://php.net/manual/en/function.readdir.php - specifically
/* This is the correct way to loop over the directory. */
while (false !== ($entry = readdir($handle))) {
echo "$entry\n";
}
/* This is the WRONG way to loop over the directory. */
while ($entry = readdir($handle)) {
echo "$entry\n";
}
Looping over a directory the wrong way will cause the loop to stop if it comes to a directory named 0 (or anything else which evaluates to false)
|
|\
| |
| | |
Provide several modifications on the PredisStore implementation.
|
|/
|
|
|
|
|
|
| |
- Fixed some typos
- Fixed the way an association is retreived from the store (getAssociation()).
The existing implementation was poping (LPOP) from a list, causing unneeded
re-associations. If we need to discard stale association handles, i think we
should rather set the appropriate expiry intervals.
|
|\
| |
| | |
Add warning when you disable SSL, don't be silly please
|
| | |
|
|\ \
| |/
|/| |
Reject OpenID XML responses with a doctype
|
| | |
|
|/ |
|
|\
| |
| | |
Add Auth_OpenID_DISABLE_SSL_VERIFY opt to disable SSL verify
|
| | |
|
| | |
|
|\ \
| | |
| | | |
Yadis: drop custom replaceEntities() function and use html_entity_decode
|
|/ /
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Yadis' ParseHTML.php has a replaceEntities() function for replacing HTML
entities, with a comment that appears to explain its existence by stating
"Replace numeric entities because html_entity_decode doesn't do it for us".
This is breaking with PHP 5.5 because it uses the deprecated /e modifier
for preg_replace() - https://github.com/openid/php-openid/issues/108 .
I think this custom function is no longer needed at least with PHP 5. PHP 5
has had support for replacing numeric entities since 2003, and its entity
handling code has been refined quite a lot since then. replaceEntities() has
been there since 2006, and probably earlier. I guess at that time PHP 4
compatibility was still important so this was needed - I don't think PHP 4's
html_entity_decode() has ever had numeric entity support - but now PHP 5 is
a decade old and there's a separate PHP 4 branch of php-openid, I think we
can ditch replaceEntities() in the main branch!
|
|\ \
| | |
| | | |
Improves open_basedir detection
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
fredden@gordo:/tmp/php-openid/examples$ php detect.php | grep -C1 basedir
If you are using a filesystem-based store or SQLite, be aware that
open_basedir
<http://www.php.net/manual/en/features.safe-mode.php#ini.open-basedir> is
in effect. This means that your data will have to be stored in one of the
fredden@gordo:/tmp/php-openid/examples$ php -i | grep basedir
open_basedir => no value => no value
fredden@gordo:/tmp/php-openid/examples$ vi detect.php
fredden@gordo:/tmp/php-openid/examples$ php detect.php | grep basedir
The *open_basedir* configuration restriction is not in effect.
fredden@gordo:/tmp/php-openid/examples$ git diff detect.php
diff --git a/examples/detect.php b/examples/detect.php
index 9c59db3..90e3995 100644
--- a/examples/detect.php
+++ b/examples/detect.php
@@ -352,7 +352,7 @@ function detect_stores($r, &$out)
}
$basedir_str = ini_get('open_basedir');
- if (gettype($basedir_str) == 'string') {
+ if (gettype($basedir_str) == 'string' && $basedir_str) {
$url = 'http://www.php.net/manual/en/features.safe-mode.php' .
'#ini.open-basedir';
$lnk = $r->link($url, 'open_basedir');
fredden@gordo:/tmp/php-openid/examples$
|
|\ \ \
| |_|/
|/| | |
Update Consumer.php for Auth_OpenID_DumbStore
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
```
$this->_use_assocs = (is_null($this->store) ? false : true);
```
always return true, even the store is Auth_OpenID_DumbStore, and do an association with the OpenID Server.
but OpenID Server will reject the check_authentication, if RP have do an association.
|
|\ \ \
| |/ /
|/| | |
issue #8 fix (PHP 5.4 call-time pass-by-reference removed)
|
| | | |
|
|\ \ \
| | | |
| | | | |
Changed gist location as the current was returning 404, new Hello World!...
|
|/ / /
| | |
| | |
| | | |
gist created
|
|\ \ \
| | | |
| | | | |
Fixed wrong expiration command (expiresat -> expireat)
|
| | | | |
|
| | | |
| | | |
| | | | |
libxml_disable_entity_loader (PHP 5 >= 5.2.11)
|
|\ \ \ \
| |/ / /
| | | | |
Implemented PredisStore to provide association store for Redis servers.
|
| | |/
| |/| |
|
|/ /
| |
| |
| | |
thanks to Kousuke Ebihara for the report and patch.
|
|\ \
| | |
| | | |
PEAR and strict mode issues
|
|/ / |
|
|\ \
| | |
| | | |
Pass request data to fix AX. Fixes #54.
|
|/ /
| |
| |
| |
| |
| | |
AX fetch response is created based on AX fetch request data. Need to
pass the $request to the Auth_OpenID_AX_FetchResponse getExtensionArgs
method.
|
|\ \
| | |
| | | |
Separate file_exists() and filesize() checks to avoid fread and filesize error
|
|/ / |
|
|\ \
| |/
|/| |
Added composer support
|
|/ |
|
|\
| |
| | |
If $_SESSION isn't set, don't trigger a PHP notice.
|
| | |
|
|/ |
|
|\
| |
| | |
Fix encoding errors in some POST forms + fix example server
|
| |
| |
| |
| |
| | |
Since all objects are passed by reference in PHP 5, assigning them by
reference does not make sense, and in some cases causes warnings.
|
| |
| |
| |
| |
| |
| | |
Since this data is inserted as strings in HTML documents, we should
call htmlspecialchars() to protect against any values containing
special characters, e.g. '"' or '&'.
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
needed)."
Since the message values are not URL encoded, calling urldecode() on
them does not make sense. Instead, it breaks any OpenID parameter
containing anything that looks like URL encoding.
This reverts commit 8d53dfe542f321da3a6e6d6e626923d575ed91d2.
|
|\ \
| | |
| | | |
Removed logging calls for a successful retrieval, as the PlainHTTPFetcher doesn't perform logging on a successful commit.
|
| | |
| | |
| | |
| | | |
doesn't perform logging on a successful commit.
|
|\ \ \
| |_|/
|/| | |
Set proxy options only if Auth_OpenID_HTTP_PROXY is explicitly set
|
|/ / |
|
|\ \
| | |
| | | |
Fixed issue #32
|
|/ / |
|
|\ \
| | |
| | | |
Fixing "preg_match_all() expects parameter 2 to be string, array given" error
|
|/ / |
|
|\ \
| | |
| | | |
Fixed one deprecated runtime call-by-reference from Server.php (line 1707)
|
|/ / |
|
|\ \
| | |
| | | |
Changing datatype of the server_url column from blob to varchar
|
| | | |
|
|\ \ \
| | | |
| | | | |
Remove call-time pass-by-reference
|
|/ / / |
|
|\ \ \
| | | |
| | | |
| | | |
| | | | |
Fix for all dl() cases and short_open_tag
I'm pretty sure we should remove the dl() calls entirely, since it is not longer present in PHP 5.3, but going ahead and merging this as-is for now.
|
| | | | |
|
| | |/
| |/| |
|
|\ \ \
| | | |
| | | | |
Fix detect
|
| | | |
| | | |
| | | |
| | | | |
changed and they do some redirects. This makes the test pass again
|
| |/ /
| | |
| | |
| | | |
format the URL doesn't get printed.
|
|\ \ \
| | | |
| | | | |
Fix minor typo
|
| |/ / |
|
| | |
| | |
| | |
| | | |
partially fixes #38
|
| | |
| | |
| | |
| | | |
make it a little more readable and obvious what we're doing here
|
|/ /
| |
| |
| | |
verification on and off, or leaving the defaults as-is.
|
|\ \
| | |
| | |
| | | |
adrianlang-master
|
| |/ |
|
|/
|
|
| |
is not available the old mechanisms are used.
|
|
|
|
|
|
| |
This was also logged previously as Trac ticket 356
This patch was submitted at the time by https://me.yahoo.com/doulepov
|
|
|
|
|
|
|
|
|
| |
Auth/OpenID/Parse.php
The match() function takes a reference parameter $match and, depending on execution flow, either returns that as an array or a string. This has been modified to now return an array in both cases.
Auth/OpenID/Consumer.php
Auth/Yadis/Manager.php
Fixed two function calls with explicit call-by-reference parameters.
|
|
|
|
| |
openid-enabled.com in detect.php
|
| |
|
| |
|
|
|
|
| |
2. Fixed a notice with absent $_GET parameter.
|
|
|
|
| |
github.com/openid/php-openid branch
|
|
|
|
| |
pseudo-references
|
| |
|
| |
|
| |
|
|
|
|
| |
user reported that the regular expression in Auth/OpenID/Parse.php is too greedy to cope with big pages. A simple fix is to make .? to . See http://bugs.debian.org/535479 for more info."
|
| |
|
|\ |
|
| | |
|
| | |
|
| | |
|
|/
|
|
| |
reference here, as php-5.x already treats all objects as pseudo-references'
|
|\ |
|
| | |
|
| | |
|
| |
| |
| |
| |
| |
| |
| |
| | |
This prevents a blank page with no error indication at all, if there
appears to happen a fatal error when trying to require DB.php from
the global include path (very bad practice!)
Instead, using is_subclass_of should be enough, especially when
using an own implementation.
|
| |
| |
| |
| | |
the commit was failing as when I tried to pull the change. This fixes the issue opened by ccazette: 'In Server.php, this function calls the Auth_OpenID_verifyReturnTo() function from TrustRoot.php, which takes 3 arguments, but only 2 are given in call_user_func_array.'
|