summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMarco Ceppi <marco@ceppi.net>2014-01-23 06:17:28 -0500
committerMarco Ceppi <marco@ceppi.net>2014-01-23 06:17:28 -0500
commitf97f69afcc6b07ab718618e6041d23c1a2e889a5 (patch)
treefc43079c7f22a1336c675b0d3eea1eb2a8a1b603
parent8e0678e85ef925095446909b33abd253b0a6f9c6 (diff)
downloadphp-openid-f97f69afcc6b07ab718618e6041d23c1a2e889a5.zip
php-openid-f97f69afcc6b07ab718618e6041d23c1a2e889a5.tar.gz
php-openid-f97f69afcc6b07ab718618e6041d23c1a2e889a5.tar.bz2
Reject OpenID XML responses with a doctype CVE-2012-4554
-rw-r--r--Auth/Yadis/XML.php4
1 files changed, 4 insertions, 0 deletions
diff --git a/Auth/Yadis/XML.php b/Auth/Yadis/XML.php
index 0f8aaec..2b8a20e 100644
--- a/Auth/Yadis/XML.php
+++ b/Auth/Yadis/XML.php
@@ -250,6 +250,10 @@ class Auth_Yadis_dom extends Auth_Yadis_XMLParser {
return false;
}
+ if (isset($this->doc->doctype)) {
+ return false;
+ }
+
$this->xpath = new DOMXPath($this->doc);
if ($this->xpath) {