summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorOlav Morken <olav.morken@uninett.no>2012-10-19 08:44:33 +0200
committerOlav Morken <olav.morken@uninett.no>2012-10-19 08:46:35 +0200
commit04f91fd782bffcd54dbcca729ec7bdc0e1c7124a (patch)
treedb803c84068501555385decb51f08a146396c42e
parent9a79bd586bd53bbc738d643d70c580aaceb27ccc (diff)
downloadphp-openid-04f91fd782bffcd54dbcca729ec7bdc0e1c7124a.zip
php-openid-04f91fd782bffcd54dbcca729ec7bdc0e1c7124a.tar.gz
php-openid-04f91fd782bffcd54dbcca729ec7bdc0e1c7124a.tar.bz2
Revert "1. Added urldecoding POST form values (browser will encode them if needed)."
Since the message values are not URL encoded, calling urldecode() on them does not make sense. Instead, it breaks any OpenID parameter containing anything that looks like URL encoding. This reverts commit 8d53dfe542f321da3a6e6d6e626923d575ed91d2.
-rw-r--r--Auth/OpenID/Message.php2
1 files changed, 1 insertions, 1 deletions
diff --git a/Auth/OpenID/Message.php b/Auth/OpenID/Message.php
index 9a5b20d..9aa1fa4 100644
--- a/Auth/OpenID/Message.php
+++ b/Auth/OpenID/Message.php
@@ -684,7 +684,7 @@ class Auth_OpenID_Message {
foreach ($this->toPostArgs() as $name => $value) {
$form .= sprintf(
"<input type=\"hidden\" name=\"%s\" value=\"%s\" />\n",
- $name, urldecode($value));
+ $name, $value);
}
$form .= sprintf("<input type=\"submit\" value=\"%s\" />\n",