summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* CS: Binary operators should be arounded by at least one spaceDariusz Ruminski2015-03-278-27/+27
|
* fixed CSFabien Potencier2015-03-251-6/+7
|
* Change behavior to mirror hash_equals() returning early if there is a length ↵Anthony Ferrara2015-03-251-9/+9
| | | | mismatch
* CS fixingAnthony Ferrara2015-03-251-1/+1
|
* Prevent modifying secrets as much as possibleAnthony Ferrara2015-03-251-9/+13
|
* Update StringUtils.phpScott Arciszewski2015-03-251-1/+8
|
* WhitespaceScott Arciszewski2015-03-251-2/+3
|
* Update StringUtils.phpScott Arciszewski2015-03-251-2/+16
|
* minor #14038 CS: fix some license headers (keradus)Fabien Potencier2015-03-241-6/+6
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This PR was merged into the 2.3 branch. Discussion ---------- CS: fix some license headers | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | ? | Fixed tickets | N/A | License | MIT | Doc PR | N/A Commits ------- 2b74841 CS: fix some license headers
| * CS: fix some license headersDariusz Ruminski2015-03-241-0/+10
| |
* | CS: Ensure there is no code on the same line as the PHP open tag and it is ↵Dariusz Ruminski2015-03-242-0/+2
|/ | | | followed by a blankline
* CS: Convert double quotes to single quotesDariusz Ruminski2015-03-215-9/+9
|
* [2.3] Static Code Analysis for Componentsv2.3.26Vladimir Reznichenko2015-03-121-3/+0
|
* Php Inspections (EA Extended) - static code analysis includes:Vladimir Reznichenko2015-03-072-6/+6
| | | | | | | | Reduce couple count calls in [Yaml] Modernize type casting, fix several strict comparisons Unsets merged Elvis operator usage Short syntax for applied operations
* minor #13862 [2.3] [Config] [Console] [DependencyInjection] [DomCrawler] ↵Fabien Potencier2015-03-074-16/+18
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | [Form] [HttpKernel] [PropertyAccess] [Security] [Translation] [Yaml] static code analysis, code cleanup (kalessil) This PR was squashed before being merged into the 2.3 branch (closes #13862). Discussion ---------- [2.3] [Config] [Console] [DependencyInjection] [DomCrawler] [Form] [HttpKernel] [PropertyAccess] [Security] [Translation] [Yaml] static code analysis, code cleanup | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | n/a | License | MIT | Doc PR | n/a Split <a href="https://github.com/symfony/symfony/pull/13813">PR 13813</a>: part 1 - targeting v2.3 Following is included (no functional changes, found with <a href="https://plugins.jetbrains.com/plugin/7622?pr=phpStorm">Php Inspections (EA Extended)</a>): - Fixed couple of concatenation as array index warnings - Unset calls can be merged inspection fixes - array_search in in_array context inspection fixes - Is null usage inspection fixes - Prefixed increment/decrement inspection fixes - Elvis operator can be used inspection fixes - Alias functions usage inspection fixes - Ternary operator simplification inspection fixes - _ _ DIR _ _ equivalent inspection fixes Commits ------- f13b5f7 [2.3] [Config] [Console] [DependencyInjection] [DomCrawler] [Form] [HttpKernel] [PropertyAccess] [Security] [Translation] [Yaml] static code analysis, code cleanup
| * [2.3] [Config] [Console] [DependencyInjection] [DomCrawler] [Form] ↵Vladimir Reznichenko2015-03-074-16/+18
| | | | | | | | [HttpKernel] [PropertyAccess] [Security] [Translation] [Yaml] static code analysis, code cleanup
* | CS fixesDariusz Ruminski2015-03-023-11/+11
|/
* [2.3] require-dev PHPUnit bridgeNicolas Grekas2015-02-242-2/+2
|
* renamed composer.phar to composer to be consistent with the Symfony docsFabien Potencier2015-02-081-1/+1
|
* bug #13466 [Security] Remove ContextListener's onKernelResponse listener as ↵Fabien Potencier2015-02-052-3/+36
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | it is used (davedevelopment) This PR was squashed before being merged into the 2.3 branch (closes #13466). Discussion ---------- [Security] Remove ContextListener's onKernelResponse listener as it is used | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | The context listeners are specific to a particular firewall, and as such, should not be applied if the current request doesn't match that context listener. To avoid this, the context listener can remove itself from the dispatcher as it is called. This comes in to affect when two or more firewalls are setup and using the same kernel for multiple requests. Assuming there are two firewalls 'site' and 'admin' - Request comes in matching 'site' firewall, 'site' ContextListener adds it's onKernelResponse method to the dispatcher - Succesful auth for 'site' - ContextListener writes token to session - Request comes in matching 'admin' firewall, 'admin' ContextListener can't find anything in the session, so nulls the token in the security context - 'site' ContextListener listens for response, can't find a token in the security context so removes the 'site' token from the session Commits ------- 380d805 [Security] Remove ContextListener's onKernelResponse listener as it is used
| * [Security] Remove ContextListener's onKernelResponse listener as it is usedDave Marshall2015-02-052-3/+36
| |
* | Removed dead code and various cleaningv2.3.25sarah khalil2015-01-215-12/+5
|/
* [Security] Don't destroy the session on buggy php releases.v2.3.24Alexander M. Turek2015-01-072-1/+21
|
* add missing param names to @param annotationChristian Flothmann2015-01-041-1/+1
|
* minor #13206 [2.3] Cleanup deprecations (nicolas-grekas)Fabien Potencier2015-01-0337-323/+1
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This PR was merged into the 2.3 branch. Discussion ---------- [2.3] Cleanup deprecations | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | let's see | Fixed tickets | - | License | MIT | Doc PR | - Commits ------- d649bef [2.3] Remove useless tests skips 1d68ad3 [2.3] Cleanup deprecations
| * [2.3] Remove useless tests skipsNicolas Grekas2015-01-0336-322/+0
| |
| * [2.3] Cleanup deprecationsNicolas Grekas2015-01-031-1/+1
| |
* | minor #13211 [Security] fixed wrong phpdoc (fabpot)Fabien Potencier2015-01-031-2/+4
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This PR was merged into the 2.3 branch. Discussion ---------- [Security] fixed wrong phpdoc | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #12597 | License | MIT | Doc PR | n/a Commits ------- 064062d [Security] fixed wrong phpdoc
| * | [Security] fixed wrong phpdocFabien Potencier2015-01-031-2/+4
| |/
* | adapted previous commit for 2.3Fabien Potencier2015-01-032-2/+2
| |
* | [Security] Don't send remember cookie for sub requestblanchonvincent2015-01-032-2/+24
|/
* Fixes various phpdoc and coding standards.Hugo Hamon2015-01-021-1/+3
|
* Updated copyright to 2015Saro0h2015-01-011-1/+1
|
* minor #13147 [2.3] for consistency, use value of DIRECTORY_SEPARATOR to ↵Fabien Potencier2014-12-301-1/+1
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | detect Windows (xabbuh) This PR was merged into the 2.3 branch. Discussion ---------- [2.3] for consistency, use value of DIRECTORY_SEPARATOR to detect Windows | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | This commit unifies the detection of Windows builds across the Symfony codebase. Commits ------- 20a427d use value of DIRECTORY_SEPARATOR to detect Windows
| * use value of DIRECTORY_SEPARATOR to detect WindowsChristian Flothmann2014-12-301-1/+1
| | | | | | | | | | This commit unifies the detection of Windows builds across the Symfony codebase.
* | Updated generateSql toolJoshua Thijssen2014-12-301-2/+2
| |
* | Fix phpdoc and coding standardsChristophe Coevoet2014-12-297-7/+3
|/ | | | | | This removes the unused use statements which were not catched by PHP-CS-Fixer because of string occurences. It also fixes some invalid phpdoc (scalar is not recognized as a valid type for instance).
* [2.3] CS And DocBlock FixesGraham Campbell2014-12-2256-150/+155
|
* bug #13048 [Security] Delete old session on auth strategy migrate (xelaris)Fabien Potencier2014-12-202-2/+2
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This PR was merged into the 2.3 branch. Discussion ---------- [Security] Delete old session on auth strategy migrate | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #13026 | License | MIT | Doc PR | As identified by @austinh in #13026 there are two sessions after authentication, since the previous session is migrated to a new one by ``session_regenerate_id``. This PR ensures the old session is been deleted immediately on migration. I can't see any drawbacks, but if the change would break BC, another approach would be to add a new strategy like ``switch`` to enable instant deletion of the old session. Commits ------- 5dd11e6 [Security] Delete old session on auth strategy migrate
| * [Security] Delete old session on auth strategy migrateAlexander Schwenn2014-12-202-2/+2
| |
* | [Tests] Silenced all deprecations in tests for 2.3sarah khalil2014-12-182-168/+4
|/
* Test components using their lowest possible depsNicolas Grekas2014-12-151-2/+3
|
* Fixed the AuthenticationProviderInterface alignmentGraham Campbell2014-12-091-8/+8
|
* minor #12887 [2.3] CS Fixes: fix phpdoc's alignment (keradus)Fabien Potencier2014-12-071-7/+7
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This PR was merged into the 2.3 branch. Discussion ---------- [2.3] CS Fixes: fix phpdoc's alignment | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | ? | Fixed tickets | N/A | License | MIT | Doc PR | N/A Fix phpdoc's alignment Commits ------- f588610 fix phpdoc's alignment
| * fix phpdoc's alignmentDariusz Rumiński2014-12-071-7/+7
| |
* | Minor phpcs fixesJeroen Thora2014-12-071-1/+1
|/
* CS fixesGraham Campbell2014-12-038-9/+1
|
* PSR-2 fixesv2.3.23Graham Campbell2014-12-027-20/+20
|
* minor #12774 Docblock Fixes (GrahamCampbell)Fabien Potencier2014-11-3037-141/+201
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This PR was merged into the 2.3 branch. Discussion ---------- Docblock Fixes | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | N/A | License | MIT | Doc PR | N/A ##### This pull request fixes the docblock alignment as requested in #12760. It was also necessary for me to ensure the `@return` annotations were correctly separated in order to accurately align the `@param` annotations. Commits ------- 443307e Docblock fixes
| * Docblock fixesGraham Campbell2014-11-3037-141/+201
| |
* | Tweaked the password-compat version constraintGraham Campbell2014-11-301-1/+1
|/
* Azerbaijani localev2.3.22Farhad Safarov2014-11-192-0/+142
|
* compare version using PHP_VERSION_IDChristian Flothmann2014-11-172-2/+2
| | | | | | To let opcode caches optimize cached code, the `PHP_VERSION_ID` constant is used to detect the current PHP version instead of calling `version_compare()` with `PHP_VERSION`.
* Add machine readable eventsDaniel Wehner2014-11-161-0/+4
|
* [Translations] Added missing Hebrew language trans-unit sourcesMichael H. Arieli2014-11-122-0/+142
|
* minor #12293 Remove aligned '=>' and '=' (disquedur)Fabien Potencier2014-10-2619-83/+83
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This PR was squashed before being merged into the 2.3 branch (closes #12293). Discussion ---------- Remove aligned '=>' and '=' | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | [https://github.com/symfony/symfony/issues/12284] | License | MIT Could you said to me if i should make an other PR for 2.5 branch. Commits ------- 51312d3 Remove aligned '=>' and '='
| * Remove aligned '=>' and '='Disquedur2014-10-2619-83/+83
| |
* | Improved the phpdoc for security token classesChristophe Coevoet2014-10-242-5/+5
|/
* Lithuanian security translationsv2.3.21Tadas Gliaubicas2014-10-151-0/+71
|
* bug #10242 Missing checkPreAuth from RememberMeAuthenticationProviderv2.3.20Mathieu Morlon2014-09-242-13/+9
|
* fixed CSFabien Potencier2014-09-2233-118/+134
|
* [Security] Added more testsMarc Torres2014-09-151-0/+42
|
* minor #11822 [Security] Use hash_equals for constant-time string comparison ↵Fabien Potencier2014-09-102-4/+50
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | (again) (dunglas) This PR was merged into the 2.3 branch. Discussion ---------- [Security] Use hash_equals for constant-time string comparison (again) | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | n/a | License | MIT | Doc PR | n/a Use the `hash_equals` function (introduced in PHP 5.6) for timing attack safe string comparison when available. Add in the DocBlock that length will leak (https://github.com/symfony/symfony/pull/11797#issuecomment-53990712). Commits ------- 3071557 [Security] Add more tests for StringUtils::equals 03bd74b [Security] Use hash_equals for constant-time string comparison
| * [Security] Add more tests for StringUtils::equalsKévin Dunglas2014-09-041-3/+41
| |
| * [Security] Use hash_equals for constant-time string comparisonKévin Dunglas2014-09-041-1/+9
| |
* | [Security] Fix usage of unexistent method in DoctrineAclCache.Morgan Auchede2014-09-051-1/+4
|/
* fixing typo in a commentv2.3.19Christian Flothmann2014-09-011-1/+1
|
* minor #11574 [Security] Made optimization on constant-time algorithm ↵Fabien Potencier2014-08-311-8/+4
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | removing modulus operator (yosmanyga) This PR was merged into the 2.3 branch. Discussion ---------- [Security] Made optimization on constant-time algorithm removing modulus operator | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - This fix improves the constant-time algorithm used to compare strings, as it removes the `%` operator inside the loop. Commits ------- 000bd0d Made optimization deprecating modulus operator
| * Made optimization deprecating modulus operatorYosmany Garcia2014-08-141-8/+4
| |
* | Fixed the phpdoc of the VoterInterfaceChristophe Coevoet2014-08-251-1/+1
| |
* | [Validator] Backported constraint validator tests from 2.5Bernhard Schussek2014-08-141-0/+168
|/
* minor #11483 fix some docblocks (xabbuh)Fabien Potencier2014-08-023-3/+7
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This PR was merged into the 2.3 branch. Discussion ---------- fix some docblocks | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | Commits ------- 1775da5 fix some docblocks
| * fix some docblocksChristian Flothmann2014-08-023-3/+7
| |
* | Unify null comparisonsWouterJ2014-07-261-1/+1
|/
* removed defaults from PHPUnit configurationv2.3.18Christian Raue2014-07-071-6/+0
|
* added XSD to PHPUnit configurationv2.3.17Christian Raue2014-07-071-2/+3
|
* [Security] Add check for supported attributes in AclVoterv2.3.16v2.3.15v2.3.14Arturs Vonda2014-05-082-3/+34
|
* added @Target annotationsv2.3.13Fabien Potencier2014-04-231-0/+1
|
* Fixed incompatibility of x509 auth with nginxalcaeus2014-04-222-21/+43
|
* minor #10717 unified return null usages (fabpot)Fabien Potencier2014-04-189-13/+10
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This PR was merged into the 2.3 branch. Discussion ---------- unified return null usages | Q | A | ------------- | --- | License | MIT This PR unifies the way we return `null` from a function or method: * always use `return;` instead of `return null;` (the current code base uses both); * never use `return;` at the end of a function/method. Commits ------- d1d569b unified return null usages
| * unified return null usagesFabien Potencier2014-04-169-13/+10
| |
* | [Security] fix DBAL connection typehintTobias Schultze2014-04-172-6/+15
| |
* | fixed types in phpdocsFabien Potencier2014-04-1630-49/+49
|/
* minor #10713 made {@inheritdoc} annotations consistent across the board (fabpot)Fabien Potencier2014-04-1645-109/+109
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This PR was merged into the 2.3 branch. Discussion ---------- made {@inheritdoc} annotations consistent across the board | Q | A | ------------- | --- | License | MIT Commits ------- 810b9ed made {@inheritdoc} annotations consistent across the board
| * made {@inheritdoc} annotations consistent across the boardFabien Potencier2014-04-1645-109/+109
| |
* | fixed types in phpdocsFabien Potencier2014-04-161-1/+1
|/
* minor #10701 Made types used by Symfony compatible with the ones of Hack ↵Fabien Potencier2014-04-1530-133/+133
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | (fabpot) This PR was merged into the 2.3 branch. Discussion ---------- Made types used by Symfony compatible with the ones of Hack | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | n/a | License | MIT | Doc PR | n/a PHP supports several ways to express types: like Boolean/bool or integer/int. Hack only supports one of them, so this PR proposes to use the Hack type to make Symfony a bit more "compatible" with Hack (gradual upgrade ;)). Commits ------- 3c9c10f made phpdoc types consistent with those defined in Hack 0555b7f made types consistent with those defined in Hack
| * made phpdoc types consistent with those defined in HackFabien Potencier2014-04-1529-124/+124
| |
| * made types consistent with those defined in HackFabien Potencier2014-04-135-9/+9
| |
* | minor #10708 Add support Thai translations (liverbool)Fabien Potencier2014-04-151-0/+71
|\ \ | |/ |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This PR was squashed before being merged into the 2.3 branch (closes #10708). Discussion ---------- Add support Thai translations Add [Thai](http://www.thai-language.com/) translations to: + Symfony/Component/Validator/Resources/translations/ + Symfony/Component/Security/Resources/translations/ Commits ------- 4bc2951 Add support Thai translations
| * Add support Thai translationsツ Liverbool2014-04-151-0/+71
| |
* | [Security] Replace exception mocks with actual exception instances.v2.3.12Jakub Zalas2014-04-015-13/+17
| | | | | | | | | | | | It is done for two reasons: * consistency - we use real exception objects in most of the code * latest phpunit does not like the way we were creating mocks for exceptions (it could be also fixed by letting phpunit to call the original constructor)
* | Update DefaultAuthenticationSuccessHandler.phpureimers2014-03-141-3/+0
| |
* | Update BCryptPasswordEncoder.phpv2.3.11szymek2014-02-191-0/+1
| |
* | fixed various inconsistenciesv2.3.10Fabien Potencier2014-02-118-48/+48
| |
* | Added Bulgarian translation for security componentRoumen Damianoff2014-01-261-0/+71
| |
* | Create security.id.xlfUlumuddin Cahyadi Yunus2014-01-261-0/+71
| |
* | [Security] Add zh_CN translationsWang Jingyu2014-01-251-0/+71
| |
* | fixed attribute "source-language" for translationsChristian Raue2014-01-212-2/+2
| |
* | Updated Vietnamese translationHa Phan2014-01-201-0/+71
| |