summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorFabien Potencier <fabien.potencier@gmail.com>2014-04-16 09:15:58 +0200
committerFabien Potencier <fabien.potencier@gmail.com>2014-04-16 09:43:51 +0200
commit092ef5478bef202a86b53f2ca0cbaa2f43d45594 (patch)
tree937851b111ba54e4fef5a1bc85089e7e53f80667
parent74eaf535ddcd6cad834c68e7802cfcb08f400c1e (diff)
downloadsymfony-security-092ef5478bef202a86b53f2ca0cbaa2f43d45594.zip
symfony-security-092ef5478bef202a86b53f2ca0cbaa2f43d45594.tar.gz
symfony-security-092ef5478bef202a86b53f2ca0cbaa2f43d45594.tar.bz2
unified return null usages
-rw-r--r--Acl/Domain/DoctrineAclCache.php8
-rw-r--r--Acl/Domain/ObjectIdentityRetrievalStrategy.php2
-rw-r--r--Acl/Permission/BasicPermissionMap.php2
-rw-r--r--Core/Authentication/Provider/AnonymousAuthenticationProvider.php2
-rw-r--r--Core/Authentication/Provider/PreAuthenticatedAuthenticationProvider.php2
-rw-r--r--Core/Authentication/Provider/UserAuthenticationProvider.php2
-rw-r--r--Core/User/User.php1
-rw-r--r--Http/Firewall/ContextListener.php2
-rw-r--r--Http/RememberMe/AbstractRememberMeServices.php2
9 files changed, 10 insertions, 13 deletions
diff --git a/Acl/Domain/DoctrineAclCache.php b/Acl/Domain/DoctrineAclCache.php
index b680fb1..9e14af5 100644
--- a/Acl/Domain/DoctrineAclCache.php
+++ b/Acl/Domain/DoctrineAclCache.php
@@ -96,14 +96,14 @@ class DoctrineAclCache implements AclCacheInterface
{
$lookupKey = $this->getAliasKeyForIdentity($aclId);
if (!$this->cache->contains($lookupKey)) {
- return null;
+ return;
}
$key = $this->cache->fetch($lookupKey);
if (!$this->cache->contains($key)) {
$this->cache->delete($lookupKey);
- return null;
+ return;
}
return $this->unserializeAcl($this->cache->fetch($key));
@@ -116,7 +116,7 @@ class DoctrineAclCache implements AclCacheInterface
{
$key = $this->getDataKeyByIdentity($oid);
if (!$this->cache->contains($key)) {
- return null;
+ return;
}
return $this->unserializeAcl($this->cache->fetch($key));
@@ -154,7 +154,7 @@ class DoctrineAclCache implements AclCacheInterface
$parentAcl = $this->getFromCacheById($parentId);
if (null === $parentAcl) {
- return null;
+ return;
}
$acl->setParentAcl($parentAcl);
diff --git a/Acl/Domain/ObjectIdentityRetrievalStrategy.php b/Acl/Domain/ObjectIdentityRetrievalStrategy.php
index 7dc552c..fc66856 100644
--- a/Acl/Domain/ObjectIdentityRetrievalStrategy.php
+++ b/Acl/Domain/ObjectIdentityRetrievalStrategy.php
@@ -29,7 +29,7 @@ class ObjectIdentityRetrievalStrategy implements ObjectIdentityRetrievalStrategy
try {
return ObjectIdentity::fromDomainObject($domainObject);
} catch (InvalidDomainObjectException $failed) {
- return null;
+ return;
}
}
}
diff --git a/Acl/Permission/BasicPermissionMap.php b/Acl/Permission/BasicPermissionMap.php
index 30d801f..fa3d543 100644
--- a/Acl/Permission/BasicPermissionMap.php
+++ b/Acl/Permission/BasicPermissionMap.php
@@ -92,7 +92,7 @@ class BasicPermissionMap implements PermissionMapInterface
public function getMasks($permission, $object)
{
if (!isset($this->map[$permission])) {
- return null;
+ return;
}
return $this->map[$permission];
diff --git a/Core/Authentication/Provider/AnonymousAuthenticationProvider.php b/Core/Authentication/Provider/AnonymousAuthenticationProvider.php
index ea91075..7fbbf85 100644
--- a/Core/Authentication/Provider/AnonymousAuthenticationProvider.php
+++ b/Core/Authentication/Provider/AnonymousAuthenticationProvider.php
@@ -40,7 +40,7 @@ class AnonymousAuthenticationProvider implements AuthenticationProviderInterface
public function authenticate(TokenInterface $token)
{
if (!$this->supports($token)) {
- return null;
+ return;
}
if ($this->key !== $token->getKey()) {
diff --git a/Core/Authentication/Provider/PreAuthenticatedAuthenticationProvider.php b/Core/Authentication/Provider/PreAuthenticatedAuthenticationProvider.php
index 3affd78..21ce8d0 100644
--- a/Core/Authentication/Provider/PreAuthenticatedAuthenticationProvider.php
+++ b/Core/Authentication/Provider/PreAuthenticatedAuthenticationProvider.php
@@ -53,7 +53,7 @@ class PreAuthenticatedAuthenticationProvider implements AuthenticationProviderIn
public function authenticate(TokenInterface $token)
{
if (!$this->supports($token)) {
- return null;
+ return;
}
if (!$user = $token->getUser()) {
diff --git a/Core/Authentication/Provider/UserAuthenticationProvider.php b/Core/Authentication/Provider/UserAuthenticationProvider.php
index 14fbdda..3728c01 100644
--- a/Core/Authentication/Provider/UserAuthenticationProvider.php
+++ b/Core/Authentication/Provider/UserAuthenticationProvider.php
@@ -58,7 +58,7 @@ abstract class UserAuthenticationProvider implements AuthenticationProviderInter
public function authenticate(TokenInterface $token)
{
if (!$this->supports($token)) {
- return null;
+ return;
}
$username = $token->getUsername();
diff --git a/Core/User/User.php b/Core/User/User.php
index b378e1b..ea2c6a4 100644
--- a/Core/User/User.php
+++ b/Core/User/User.php
@@ -64,7 +64,6 @@ final class User implements AdvancedUserInterface
*/
public function getSalt()
{
- return null;
}
/**
diff --git a/Http/Firewall/ContextListener.php b/Http/Firewall/ContextListener.php
index 60ab3df..c4b0a1e 100644
--- a/Http/Firewall/ContextListener.php
+++ b/Http/Firewall/ContextListener.php
@@ -171,7 +171,7 @@ class ContextListener implements ListenerInterface
$this->logger->warning(sprintf('Username "%s" could not be found.', $notFound->getUsername()));
}
- return null;
+ return;
}
}
diff --git a/Http/RememberMe/AbstractRememberMeServices.php b/Http/RememberMe/AbstractRememberMeServices.php
index 740d3d6..9c2456f 100644
--- a/Http/RememberMe/AbstractRememberMeServices.php
+++ b/Http/RememberMe/AbstractRememberMeServices.php
@@ -142,8 +142,6 @@ abstract class AbstractRememberMeServices implements RememberMeServicesInterface
}
$this->cancelCookie($request);
-
- return null;
}
/**