diff options
author | Fabien Potencier <fabien.potencier@gmail.com> | 2016-01-27 05:57:57 +0100 |
---|---|---|
committer | Fabien Potencier <fabien.potencier@gmail.com> | 2016-01-27 05:57:57 +0100 |
commit | ca564737b36474a1e566d06585c3a01e849eb0b9 (patch) | |
tree | d2e002099f843d8ea48644da4039f426754d6b8c /Tests/Http/RememberMe | |
parent | a9c0831d7e4f6bd2a72edc235bb31e59ec05f995 (diff) | |
parent | b27826b0ed6f72b12a66608bfb4074d36e1d4176 (diff) | |
download | symfony-security-ca564737b36474a1e566d06585c3a01e849eb0b9.zip symfony-security-ca564737b36474a1e566d06585c3a01e849eb0b9.tar.gz symfony-security-ca564737b36474a1e566d06585c3a01e849eb0b9.tar.bz2 |
minor #17480 Static code analysis (Koc)
This PR was merged into the 2.3 branch.
Discussion
----------
Static code analysis
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | -
| License | MIT
| Doc PR | -
Things that done:
* fix case in method calls
* removed unused imports
* use shorter concat where it possible
* optimize some css
* removed duplicated array keys
* removed redurant return statements
* removed one-time variables
* do not pass arguments that not used in functions
Commits
-------
8db691a Static code analysis
Diffstat (limited to 'Tests/Http/RememberMe')
-rw-r--r-- | Tests/Http/RememberMe/TokenBasedRememberMeServicesTest.php | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/Tests/Http/RememberMe/TokenBasedRememberMeServicesTest.php b/Tests/Http/RememberMe/TokenBasedRememberMeServicesTest.php index b988c7d..d1ec9b2 100644 --- a/Tests/Http/RememberMe/TokenBasedRememberMeServicesTest.php +++ b/Tests/Http/RememberMe/TokenBasedRememberMeServicesTest.php @@ -172,9 +172,8 @@ class TokenBasedRememberMeServicesTest extends \PHPUnit_Framework_TestCase { $service = $this->getService(null, array('name' => 'foo', 'path' => '/foo', 'domain' => 'foodomain.foo')); $request = new Request(); - $response = new Response(); - $service->loginFail($request, $response); + $service->loginFail($request); $cookie = $request->attributes->get(RememberMeServicesInterface::COOKIE_ATTR_NAME); $this->assertTrue($cookie->isCleared()); |