summaryrefslogtreecommitdiffstats
path: root/Http
diff options
context:
space:
mode:
authorNicolas Grekas <nicolas.grekas@gmail.com>2015-01-03 16:33:07 +0100
committerNicolas Grekas <nicolas.grekas@gmail.com>2015-01-03 16:33:07 +0100
commitb1d5c3526ab1278959d1252c4cdda6b8f3a6452a (patch)
tree4e9d39e5a172f8f06326e236346ac19778df21a0 /Http
parent6c39103b6f13e2bcde7c3543a8e28e0dd3c1f571 (diff)
parent3c08afb6d3cacf22c9799bfb0f08c3235ef38cd6 (diff)
downloadsymfony-security-b1d5c3526ab1278959d1252c4cdda6b8f3a6452a.zip
symfony-security-b1d5c3526ab1278959d1252c4cdda6b8f3a6452a.tar.gz
symfony-security-b1d5c3526ab1278959d1252c4cdda6b8f3a6452a.tar.bz2
Merge branch '2.5' into 2.6
* 2.5: [2.3] Remove useless tests skips [ClassLoader] removes deprecated classes from documentation. [ClassLoader] added missing deprecation notice. [HttpFoundation] Fix an issue caused by php's Bug #66606. [Yaml] Update README.md Don't add Accept-Range header on unsafe HTTP requests simplify hasScheme method adapted merge to 2.5 adapted previous commit for 2.3 [Security] Don't send remember cookie for sub request [Security] fixed wrong phpdoc [HttpKernel] Fix UriSigner::check when _hash is not at the end of the uri [2.3] Cleanup deprecations Conflicts: src/Symfony/Bundle/FrameworkBundle/composer.json src/Symfony/Bundle/WebProfilerBundle/Resources/views/Collector/logger.html.twig src/Symfony/Component/HttpKernel/composer.json
Diffstat (limited to 'Http')
-rw-r--r--Http/RememberMe/ResponseListener.php4
-rw-r--r--Http/Tests/Firewall/AnonymousAuthenticationListenerTest.php4
-rw-r--r--Http/Tests/RememberMe/ResponseListenerTest.php19
3 files changed, 22 insertions, 5 deletions
diff --git a/Http/RememberMe/ResponseListener.php b/Http/RememberMe/ResponseListener.php
index 2253c5d..4149fb6 100644
--- a/Http/RememberMe/ResponseListener.php
+++ b/Http/RememberMe/ResponseListener.php
@@ -27,6 +27,10 @@ class ResponseListener implements EventSubscriberInterface
*/
public function onKernelResponse(FilterResponseEvent $event)
{
+ if (!$event->isMasterRequest()) {
+ return;
+ }
+
$request = $event->getRequest();
$response = $event->getResponse();
diff --git a/Http/Tests/Firewall/AnonymousAuthenticationListenerTest.php b/Http/Tests/Firewall/AnonymousAuthenticationListenerTest.php
index 0f43aa0..3bc4eb6 100644
--- a/Http/Tests/Firewall/AnonymousAuthenticationListenerTest.php
+++ b/Http/Tests/Firewall/AnonymousAuthenticationListenerTest.php
@@ -73,10 +73,6 @@ class AnonymousAuthenticationListenerTest extends \PHPUnit_Framework_TestCase
public function testHandledEventIsLogged()
{
- if (!interface_exists('Psr\Log\LoggerInterface')) {
- $this->markTestSkipped('The "LoggerInterface" is not available');
- }
-
$context = $this->getMock('Symfony\Component\Security\Core\SecurityContextInterface');
$logger = $this->getMock('Psr\Log\LoggerInterface');
$logger->expects($this->once())
diff --git a/Http/Tests/RememberMe/ResponseListenerTest.php b/Http/Tests/RememberMe/ResponseListenerTest.php
index 9bb84a2..78de8e4 100644
--- a/Http/Tests/RememberMe/ResponseListenerTest.php
+++ b/Http/Tests/RememberMe/ResponseListenerTest.php
@@ -11,6 +11,7 @@
namespace Symfony\Component\Security\Http\Tests\RememberMe;
+use Symfony\Component\HttpKernel\HttpKernelInterface;
use Symfony\Component\Security\Http\RememberMe\ResponseListener;
use Symfony\Component\Security\Http\RememberMe\RememberMeServicesInterface;
use Symfony\Component\HttpFoundation\Request;
@@ -34,6 +35,21 @@ class ResponseListenerTest extends \PHPUnit_Framework_TestCase
$listener->onKernelResponse($this->getEvent($request, $response));
}
+ public function testRememberMeCookieIsNotSendWithResponseForSubRequests()
+ {
+ $cookie = new Cookie('rememberme');
+
+ $request = $this->getRequest(array(
+ RememberMeServicesInterface::COOKIE_ATTR_NAME => $cookie,
+ ));
+
+ $response = $this->getResponse();
+ $response->headers->expects($this->never())->method('setCookie');
+
+ $listener = new ResponseListener();
+ $listener->onKernelResponse($this->getEvent($request, $response, HttpKernelInterface::SUB_REQUEST));
+ }
+
public function testRememberMeCookieIsNotSendWithResponse()
{
$request = $this->getRequest();
@@ -71,13 +87,14 @@ class ResponseListenerTest extends \PHPUnit_Framework_TestCase
return $response;
}
- private function getEvent($request, $response)
+ private function getEvent($request, $response, $type = HttpKernelInterface::MASTER_REQUEST)
{
$event = $this->getMockBuilder('Symfony\Component\HttpKernel\Event\FilterResponseEvent')
->disableOriginalConstructor()
->getMock();
$event->expects($this->any())->method('getRequest')->will($this->returnValue($request));
+ $event->expects($this->any())->method('isMasterRequest')->will($this->returnValue($type === HttpKernelInterface::MASTER_REQUEST));
$event->expects($this->any())->method('getResponse')->will($this->returnValue($response));
return $event;