diff options
author | Fabien Potencier <fabien.potencier@gmail.com> | 2015-10-05 16:40:32 +0200 |
---|---|---|
committer | Fabien Potencier <fabien.potencier@gmail.com> | 2015-10-05 16:40:32 +0200 |
commit | 545528ff1e7a50a50b8e91f27bd667d66a140b14 (patch) | |
tree | 04ad1c0b4e70ae470b055d9f06bc88fc49a3b1bb /Http/RememberMe/AbstractRememberMeServices.php | |
parent | dc6bf51f8c3febd6a5fa0708e2a020d98daca79d (diff) | |
parent | 135b1b5bb942c97ec1f1d5e811063a7be3cae35e (diff) | |
download | symfony-security-545528ff1e7a50a50b8e91f27bd667d66a140b14.zip symfony-security-545528ff1e7a50a50b8e91f27bd667d66a140b14.tar.gz symfony-security-545528ff1e7a50a50b8e91f27bd667d66a140b14.tar.bz2 |
bug #14842 [Security][bugfix] "Remember me" cookie cleared on logout with custom "secure"/"httponly" config options [1] (MacDada)
This PR was squashed before being merged into the 2.3 branch (closes #14842).
Discussion
----------
[Security][bugfix] "Remember me" cookie cleared on logout with custom "secure"/"httponly" config options [1]
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #14822
| License | MIT
| Doc PR | ~
* test now always pass "secure" and "httponly" options, as they are required
* could be considered BC, but [`RememberMeFactory` passes them](https://github.com/symfony/symfony/blob/2.3/src/Symfony/Bundle/SecurityBundle/DependencyInjection/Security/Factory/RememberMeFactory.php#L21), so they should've always been treated as required
* I can squash the commits before merging
* Alternative solution: #14843
Commits
-------
18b1c6a [Security][bugfix] "Remember me" cookie cleared on logout with custom "secure"/"httponly" config options [1]
Diffstat (limited to 'Http/RememberMe/AbstractRememberMeServices.php')
-rw-r--r-- | Http/RememberMe/AbstractRememberMeServices.php | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/Http/RememberMe/AbstractRememberMeServices.php b/Http/RememberMe/AbstractRememberMeServices.php index 1ba2df6..51eddb6 100644 --- a/Http/RememberMe/AbstractRememberMeServices.php +++ b/Http/RememberMe/AbstractRememberMeServices.php @@ -293,7 +293,7 @@ abstract class AbstractRememberMeServices implements RememberMeServicesInterface $this->logger->debug(sprintf('Clearing remember-me cookie "%s"', $this->options['name'])); } - $request->attributes->set(self::COOKIE_ATTR_NAME, new Cookie($this->options['name'], null, 1, $this->options['path'], $this->options['domain'])); + $request->attributes->set(self::COOKIE_ATTR_NAME, new Cookie($this->options['name'], null, 1, $this->options['path'], $this->options['domain'], $this->options['secure'], $this->options['httponly'])); } /** |