summaryrefslogtreecommitdiffstats
path: root/Http/Logout/LogoutSuccessHandlerInterface.php
diff options
context:
space:
mode:
authorBernhard Schussek <bernhard.schussek@symfony-project.com>2011-03-05 15:30:34 +0100
committerBernhard Schussek <bernhard.schussek@symfony-project.com>2011-03-05 15:30:34 +0100
commitc0b58aaf0672541eb7215d4018201b0e21ff957d (patch)
tree7a76588be3608fe885ed1a5d45c95419f64166fe /Http/Logout/LogoutSuccessHandlerInterface.php
parenta45d4a21c023980a2d652234d7068a477a20f6e8 (diff)
downloadsymfony-security-c0b58aaf0672541eb7215d4018201b0e21ff957d.zip
symfony-security-c0b58aaf0672541eb7215d4018201b0e21ff957d.tar.gz
symfony-security-c0b58aaf0672541eb7215d4018201b0e21ff957d.tar.bz2
Replaced EventDispatcher by Doctrine's EventManager implementation
Doctrine's EventManager implementation has several advantages over the EventDispatcher implementation of Symfony2. Therefore I suggest that we use their implementation. Advantages: * Event Listeners are objects, not callbacks. These objects have handler methods that have the same name as the event. This helps a lot when reading the code and makes the code for adding an event listener shorter. * You can create Event Subscribers, which are event listeners with an additional getSubscribedEvents() method. The benefit here is that the code that registers the subscriber doesn't need to know about its implementation. * All events are defined in static Events classes, so users of IDEs benefit of code completion * The communication between the dispatching class of an event and all listeners is done through a subclass of EventArgs. This subclass can be tailored to the type of event. A constructor, setters and getters can be implemented that verify the validity of the data set into the object. See examples below. * Because each event type corresponds to an EventArgs implementation, developers of event listeners can look up the available EventArgs methods and benefit of code completion. * EventArgs::stopPropagation() is more flexible and (IMO) clearer to use than notifyUntil(). Also, it is a concept that is also used in other event implementations Before: class EventListener { public function handle(EventInterface $event, $data) { ... } } $dispatcher->connect('core.request', array($listener, 'handle')); $dispatcher->notify('core.request', new Event(...)); After (with listeners): final class Events { const onCoreRequest = 'onCoreRequest'; } class EventListener { public function onCoreRequest(RequestEventArgs $eventArgs) { ... } } $evm->addEventListener(Events::onCoreRequest, $listener); $evm->dispatchEvent(Events::onCoreRequest, new RequestEventArgs(...)); After (with subscribers): class EventSubscriber { public function onCoreRequest(RequestEventArgs $eventArgs) { ... } public function getSubscribedEvents() { return Events::onCoreRequest; } } $evm->addEventSubscriber($subscriber); $evm->dispatchEvent(Events::onCoreRequest, new RequestEventArgs(...));
Diffstat (limited to 'Http/Logout/LogoutSuccessHandlerInterface.php')
-rw-r--r--Http/Logout/LogoutSuccessHandlerInterface.php6
1 files changed, 3 insertions, 3 deletions
diff --git a/Http/Logout/LogoutSuccessHandlerInterface.php b/Http/Logout/LogoutSuccessHandlerInterface.php
index 346784b..87153e7 100644
--- a/Http/Logout/LogoutSuccessHandlerInterface.php
+++ b/Http/Logout/LogoutSuccessHandlerInterface.php
@@ -3,7 +3,7 @@
namespace Symfony\Component\Security\Http\Logout;
use Symfony\Component\HttpFoundation\Request;
-use Symfony\Component\EventDispatcher\EventInterface;
+use Symfony\Component\HttpKernel\Event\RequestEventArgs;
/**
* LogoutSuccesshandlerInterface.
@@ -21,9 +21,9 @@ interface LogoutSuccessHandlerInterface
/**
* Creates a Response object to send upon a successful logout.
*
- * @param EventInterface $event
+ * @param RequestEventArgs $eventArgs
* @param Request $request
* @return Response never null
*/
- function onLogoutSuccess(EventInterface $event, Request $request);
+ function onLogoutSuccess(RequestEventArgs $eventArgs, Request $request);
} \ No newline at end of file