diff options
author | Bernhard Schussek <bernhard.schussek@symfony-project.com> | 2011-03-05 15:30:34 +0100 |
---|---|---|
committer | Bernhard Schussek <bernhard.schussek@symfony-project.com> | 2011-03-05 15:30:34 +0100 |
commit | c0b58aaf0672541eb7215d4018201b0e21ff957d (patch) | |
tree | 7a76588be3608fe885ed1a5d45c95419f64166fe /Http/Event | |
parent | a45d4a21c023980a2d652234d7068a477a20f6e8 (diff) | |
download | symfony-security-c0b58aaf0672541eb7215d4018201b0e21ff957d.zip symfony-security-c0b58aaf0672541eb7215d4018201b0e21ff957d.tar.gz symfony-security-c0b58aaf0672541eb7215d4018201b0e21ff957d.tar.bz2 |
Replaced EventDispatcher by Doctrine's EventManager implementation
Doctrine's EventManager implementation has several advantages over the
EventDispatcher implementation of Symfony2. Therefore I suggest that we
use their implementation.
Advantages:
* Event Listeners are objects, not callbacks. These objects have handler
methods that have the same name as the event. This helps a lot when
reading the code and makes the code for adding an event listener shorter.
* You can create Event Subscribers, which are event listeners with an
additional getSubscribedEvents() method. The benefit here is that the
code that registers the subscriber doesn't need to know about its
implementation.
* All events are defined in static Events classes, so users of IDEs benefit
of code completion
* The communication between the dispatching class of an event and all
listeners is done through a subclass of EventArgs. This subclass can be
tailored to the type of event. A constructor, setters and getters can be
implemented that verify the validity of the data set into the object.
See examples below.
* Because each event type corresponds to an EventArgs implementation,
developers of event listeners can look up the available EventArgs methods
and benefit of code completion.
* EventArgs::stopPropagation() is more flexible and (IMO) clearer to use
than notifyUntil(). Also, it is a concept that is also used in other
event implementations
Before:
class EventListener
{
public function handle(EventInterface $event, $data) { ... }
}
$dispatcher->connect('core.request', array($listener, 'handle'));
$dispatcher->notify('core.request', new Event(...));
After (with listeners):
final class Events
{
const onCoreRequest = 'onCoreRequest';
}
class EventListener
{
public function onCoreRequest(RequestEventArgs $eventArgs) { ... }
}
$evm->addEventListener(Events::onCoreRequest, $listener);
$evm->dispatchEvent(Events::onCoreRequest, new RequestEventArgs(...));
After (with subscribers):
class EventSubscriber
{
public function onCoreRequest(RequestEventArgs $eventArgs) { ... }
public function getSubscribedEvents()
{
return Events::onCoreRequest;
}
}
$evm->addEventSubscriber($subscriber);
$evm->dispatchEvent(Events::onCoreRequest, new RequestEventArgs(...));
Diffstat (limited to 'Http/Event')
-rw-r--r-- | Http/Event/InteractiveLoginEventArgs.php | 38 | ||||
-rw-r--r-- | Http/Event/SwitchUserEventArgs.php | 39 |
2 files changed, 77 insertions, 0 deletions
diff --git a/Http/Event/InteractiveLoginEventArgs.php b/Http/Event/InteractiveLoginEventArgs.php new file mode 100644 index 0000000..7ca4f4e --- /dev/null +++ b/Http/Event/InteractiveLoginEventArgs.php @@ -0,0 +1,38 @@ +<?php + +/* + * This file is part of the Symfony package. + * + * (c) Fabien Potencier <fabien.potencier@symfony-project.com> + * + * For the full copyright and license information, please view the LICENSE + * file that was distributed with this source code. + */ + +namespace Symfony\Component\Security\Http\Event; + +use Symfony\Component\HttpFoundation\Request; +use Doctrine\Common\EventArgs; + +class InteractiveLoginEventArgs extends EventArgs +{ + private $request; + + private $authenticationToken; + + public function __construct(Request $request, $authenticationToken) + { + $this->request = $request; + $this->authenticationToken = $authenticationToken; + } + + public function getRequest() + { + return $this->request; + } + + public function getAuthenticationToken() + { + return $this->authenticationToken; + } +}
\ No newline at end of file diff --git a/Http/Event/SwitchUserEventArgs.php b/Http/Event/SwitchUserEventArgs.php new file mode 100644 index 0000000..be38036 --- /dev/null +++ b/Http/Event/SwitchUserEventArgs.php @@ -0,0 +1,39 @@ +<?php + +/* + * This file is part of the Symfony package. + * + * (c) Fabien Potencier <fabien.potencier@symfony-project.com> + * + * For the full copyright and license information, please view the LICENSE + * file that was distributed with this source code. + */ + +namespace Symfony\Component\Security\Http\Event; + +use Symfony\Component\HttpFoundation\Request; +use Symfony\Component\Security\Core\User\AccountInterface; +use Doctrine\Common\EventArgs; + +class SwitchUserEventArgs extends EventArgs +{ + private $request; + + private $targetUser; + + public function __construct(Request $request, AccountInterface $targetUser) + { + $this->request = $request; + $this->targetUser = $targetUser; + } + + public function getRequest() + { + return $this->request; + } + + public function getTargetUser() + { + return $this->targetUser; + } +}
\ No newline at end of file |