diff options
author | Fabien Potencier <fabien.potencier@gmail.com> | 2014-09-03 11:22:04 +0200 |
---|---|---|
committer | Fabien Potencier <fabien.potencier@gmail.com> | 2014-09-03 11:22:04 +0200 |
commit | 0c51a70c04279663ac6e016efeb31557b28b0c44 (patch) | |
tree | 68763d1ff701aedc34d990b9c34a949dab9dadf7 /Core/Tests | |
parent | ea2fdb74f55f823975150e0bf6da7c8bc0ccafc6 (diff) | |
download | symfony-security-0c51a70c04279663ac6e016efeb31557b28b0c44.zip symfony-security-0c51a70c04279663ac6e016efeb31557b28b0c44.tar.gz symfony-security-0c51a70c04279663ac6e016efeb31557b28b0c44.tar.bz2 |
Revert "minor #11808 [Security] Add more tests for StringUtils::equals (dunglas)"v2.4.9
This reverts commit 8fdfb6fc35e194db06583854933f9c826608f7a7, reversing
changes made to e99dfdf87a8f0d2871a5415401409ed96cff6f3d.
Diffstat (limited to 'Core/Tests')
-rw-r--r-- | Core/Tests/Util/StringUtilsTest.php | 44 |
1 files changed, 3 insertions, 41 deletions
diff --git a/Core/Tests/Util/StringUtilsTest.php b/Core/Tests/Util/StringUtilsTest.php index e0366a5..89da98d 100644 --- a/Core/Tests/Util/StringUtilsTest.php +++ b/Core/Tests/Util/StringUtilsTest.php @@ -13,49 +13,11 @@ namespace Symfony\Component\Security\Core\Tests\Util; use Symfony\Component\Security\Core\Util\StringUtils; -/** - * Data from PHP.net's hash_equals tests - */ class StringUtilsTest extends \PHPUnit_Framework_TestCase { - public function dataProviderTrue() - { - return array( - array('same', 'same'), - array('', ''), - array(123, 123), - array(null, ''), - array(null, null), - ); - } - - public function dataProviderFalse() - { - return array( - array('not1same', 'not2same'), - array('short', 'longer'), - array('longer', 'short'), - array('', 'notempty'), - array('notempty', ''), - array(123, 'NaN'), - array('NaN', 123), - array(null, 123), - ); - } - - /** - * @dataProvider dataProviderTrue - */ - public function testEqualsTrue($known, $user) - { - $this->assertTrue(StringUtils::equals($known, $user)); - } - - /** - * @dataProvider dataProviderFalse - */ - public function testEqualsFalse($known, $user) + public function testEquals() { - $this->assertFalse(StringUtils::equals($known, $user)); + $this->assertTrue(StringUtils::equals('password', 'password')); + $this->assertFalse(StringUtils::equals('password', 'foo')); } } |