summaryrefslogtreecommitdiffstats
path: root/Core/Role/RoleHierarchy.php
diff options
context:
space:
mode:
authorEnleur <enleury@gmail.com>2016-09-06 13:52:05 +0300
committerFabien Potencier <fabien.potencier@gmail.com>2016-09-06 17:21:44 -0700
commit2174a8c2e3fb6190a24d823e5b4a08f2aab631ce (patch)
treec658f779a082701e59fb6d6fef38bfdc75f5ffad /Core/Role/RoleHierarchy.php
parent1a56ae95e84784bcd003c697a8173921412beee7 (diff)
downloadsymfony-security-2174a8c2e3fb6190a24d823e5b4a08f2aab631ce.zip
symfony-security-2174a8c2e3fb6190a24d823e5b4a08f2aab631ce.tar.gz
symfony-security-2174a8c2e3fb6190a24d823e5b4a08f2aab631ce.tar.bz2
[Security] Optimize RoleHierarchy's buildRoleMap method
Diffstat (limited to 'Core/Role/RoleHierarchy.php')
-rw-r--r--Core/Role/RoleHierarchy.php12
1 files changed, 10 insertions, 2 deletions
diff --git a/Core/Role/RoleHierarchy.php b/Core/Role/RoleHierarchy.php
index 793007e..95e76ee 100644
--- a/Core/Role/RoleHierarchy.php
+++ b/Core/Role/RoleHierarchy.php
@@ -65,9 +65,17 @@ class RoleHierarchy implements RoleHierarchyInterface
}
$visited[] = $role;
- $this->map[$main] = array_unique(array_merge($this->map[$main], $this->hierarchy[$role]));
- $additionalRoles = array_merge($additionalRoles, array_diff($this->hierarchy[$role], $visited));
+
+ foreach ($this->hierarchy[$role] as $roleToAdd) {
+ $this->map[$main][] = $roleToAdd;
+ }
+
+ foreach (array_diff($this->hierarchy[$role], $visited) as $additionalRole) {
+ $additionalRoles[] = $additionalRole;
+ }
}
+
+ $this->map[$main] = array_unique($this->map[$main]);
}
}
}