diff options
| author | Fabien Potencier <fabien.potencier@gmail.com> | 2015-07-22 15:13:29 +0200 |
|---|---|---|
| committer | Fabien Potencier <fabien.potencier@gmail.com> | 2015-07-22 15:13:29 +0200 |
| commit | 999b2896fe878d343d8b0de62694eea745a36665 (patch) | |
| tree | 0c67a347ac55ce81a00812cdc7115a0c9fc13bfe /Core/Authentication/SimplePreAuthenticatorInterface.php | |
| parent | 185507f0f15e07f162d047306f018fd55cdf5d3c (diff) | |
| parent | a9b06e1674a54da58eafbbff5cdf1b9158f78186 (diff) | |
| download | symfony-security-999b2896fe878d343d8b0de62694eea745a36665.zip symfony-security-999b2896fe878d343d8b0de62694eea745a36665.tar.gz symfony-security-999b2896fe878d343d8b0de62694eea745a36665.tar.bz2 | |
feature #15131 [Security] Moved Simple{Form,Pre}AuthenticatorInterfaces to Security\Http (WouterJ)
This PR was squashed before being merged into the 2.8 branch (closes #15131).
Discussion
----------
[Security] Moved Simple{Form,Pre}AuthenticatorInterfaces to Security\Http
Description
---
The `SimpleFormAuthenticatorInterface` and `SimplePreAuthenticatorInterface` rely on `Request`, which means it's a Http land class. This means they don't belong in core.
Having a form login that doesn't depend on the request is an option as well (e.g. a console application might use the question helper to implement a "form" login). However, then there is a need for a new abstraction of the request. I don't think it's worth it.
Furthermore, the only classes typehinting/relying on this interfaces can be found in `Security\Http`.
Implementation
---
The new interfaces extend the old ones for better backwards compability. Symfony doesn't trigger deprecation errors for interfaces, see https://github.com/symfony/symfony/commit/6f57b7b552e77a12f8116460671d78a3eb0ddbb9
PR Info Table
---
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | yes
| Tests pass? | yes
| Fixed tickets | -
| License | MIT
| Doc PR | -
Commits
-------
ebb2064 [Security] Moved Simple{Form,Pre}AuthenticatorInterfaces to Security\Http
Diffstat (limited to 'Core/Authentication/SimplePreAuthenticatorInterface.php')
| -rw-r--r-- | Core/Authentication/SimplePreAuthenticatorInterface.php | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/Core/Authentication/SimplePreAuthenticatorInterface.php b/Core/Authentication/SimplePreAuthenticatorInterface.php index 6164e7d..c01f064 100644 --- a/Core/Authentication/SimplePreAuthenticatorInterface.php +++ b/Core/Authentication/SimplePreAuthenticatorInterface.php @@ -14,6 +14,8 @@ namespace Symfony\Component\Security\Core\Authentication; use Symfony\Component\HttpFoundation\Request; /** + * @deprecated Since version 2.8, to be removed in 3.0. Use the same interface from Security\Http\Authentication instead. + * * @author Jordi Boggiano <j.boggiano@seld.be> */ interface SimplePreAuthenticatorInterface extends SimpleAuthenticatorInterface |