summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorFabien Potencier <fabien.potencier@gmail.com>2010-11-23 09:42:19 +0100
committerFabien Potencier <fabien.potencier@gmail.com>2010-11-25 17:30:06 +0100
commitd4e986a1fe559c9ed5077086e861a0f069a1631f (patch)
tree9664bc7a0f8ef356c36ee3e82a4a8e7dede9a89f
parentc5010893af7040a0c17521029a1d7838719d89bc (diff)
downloadsymfony-security-d4e986a1fe559c9ed5077086e861a0f069a1631f.zip
symfony-security-d4e986a1fe559c9ed5077086e861a0f069a1631f.tar.gz
symfony-security-d4e986a1fe559c9ed5077086e861a0f069a1631f.tar.bz2
made some method name changes to have a better coherence throughout the framework
When an object has a "main" many relation with related "things" (objects, parameters, ...), the method names are normalized: * get() * set() * all() * replace() * remove() * clear() * isEmpty() * add() * register() * count() * keys() The classes below follow this method naming convention: * BrowserKit\CookieJar -> Cookie * BrowserKit\History -> Request * Console\Application -> Command * Console\Application\Helper\HelperSet -> HelperInterface * DependencyInjection\Container -> services * DependencyInjection\ContainerBuilder -> services * DependencyInjection\ParameterBag\ParameterBag -> parameters * DependencyInjection\ParameterBag\FrozenParameterBag -> parameters * DomCrawler\Form -> FormField * EventDispatcher\Event -> parameters * Form\FieldGroup -> Field * HttpFoundation\HeaderBag -> headers * HttpFoundation\ParameterBag -> parameters * HttpFoundation\Session -> attributes * HttpKernel\Profiler\Profiler -> DataCollectorInterface * Routing\RouteCollection -> Route * Security\Authentication\AuthenticationProviderManager -> AuthenticationProviderInterface * Templating\Engine -> HelperInterface * Translation\MessageCatalogue -> messages The usage of these methods are only allowed when it is clear that there is a main relation: * a CookieJar has many Cookies; * a Container has many services and many parameters (as services is the main relation, we use the naming convention for this relation); * a Console Input has many arguments and many options. There is no "main" relation, and so the naming convention does not apply. For many relations where the convention does not apply, the following methods must be used instead (where XXX is the name of the related thing): * get() -> getXXX() * set() -> setXXX() * all() -> getXXXs() * replace() -> setXXXs() * remove() -> removeXXX() * clear() -> clearXXX() * isEmpty() -> isEmptyXXX() * add() -> addXXX() * register() -> registerXXX() * count() -> countXXX() * keys()
-rw-r--r--Authentication/AuthenticationProviderManager.php6
1 files changed, 3 insertions, 3 deletions
diff --git a/Authentication/AuthenticationProviderManager.php b/Authentication/AuthenticationProviderManager.php
index 78d7225..9f8efbf 100644
--- a/Authentication/AuthenticationProviderManager.php
+++ b/Authentication/AuthenticationProviderManager.php
@@ -90,7 +90,7 @@ class AuthenticationProviderManager implements AuthenticationManagerInterface
*
* @return AuthenticationProviderInterface[] An array of AuthenticationProviderInterface instances
*/
- public function getProviders()
+ public function all()
{
return $this->providers;
}
@@ -104,7 +104,7 @@ class AuthenticationProviderManager implements AuthenticationManagerInterface
{
$this->providers = array();
foreach ($providers as $provider) {
- $this->addProvider($provider);
+ $this->add($provider);
}
}
@@ -113,7 +113,7 @@ class AuthenticationProviderManager implements AuthenticationManagerInterface
*
* @param AuthenticationProviderInterface $provider A AuthenticationProviderInterface instance
*/
- public function addProvider(AuthenticationProviderInterface $provider)
+ public function add(AuthenticationProviderInterface $provider)
{
$this->providers[] = $provider;
}