diff options
author | Fabien Potencier <fabien.potencier@gmail.com> | 2016-06-29 07:10:15 +0200 |
---|---|---|
committer | Fabien Potencier <fabien.potencier@gmail.com> | 2016-06-29 07:10:15 +0200 |
commit | cc882b6a2f23f4d670267ef31c4c46f3e2d36040 (patch) | |
tree | 6c8acfa230ec9349edf0549a0faf4c950e839b53 | |
parent | 2e1886476405d194d8903c116098af8e8ecf86c8 (diff) | |
parent | 9ff799166f5f636b51a241f8a522f1cab3ebd2ce (diff) | |
download | symfony-security-cc882b6a2f23f4d670267ef31c4c46f3e2d36040.zip symfony-security-cc882b6a2f23f4d670267ef31c4c46f3e2d36040.tar.gz symfony-security-cc882b6a2f23f4d670267ef31c4c46f3e2d36040.tar.bz2 |
bug #19204 [Security] Allow LDAP loadUser override (tucksaun)
This PR was merged into the 3.1 branch.
Discussion
----------
[Security] Allow LDAP loadUser override
| Q | A
| ------------- | ---
| Branch? | 3.1
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | -
| License | MIT
| Doc PR | -
Back to 3.0, one could extend `Symfony\Component\Security\Core\User\LdapUserProvider` and override how User objects are created.
Among several improvements, #17560 changed `loadUser` signature but also visibility to `private` which disallow any overriding.
Even if the signature BC break is legitimate, we should still be able to override this method IMHO, which is not possible with a private visibility.
This PRs introduces a `protected` visibility to allow again overriding.
Commits
-------
ae99aa8 [Security] Allow LDAP loadUser override
-rw-r--r-- | Core/User/LdapUserProvider.php | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/Core/User/LdapUserProvider.php b/Core/User/LdapUserProvider.php index 5eb7668..fc42419 100644 --- a/Core/User/LdapUserProvider.php +++ b/Core/User/LdapUserProvider.php @@ -111,7 +111,7 @@ class LdapUserProvider implements UserProviderInterface * * @return User */ - private function loadUser($username, Entry $entry) + protected function loadUser($username, Entry $entry) { $password = $this->getPassword($entry); |