summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorNicolas Grekas <nicolas.grekas@gmail.com>2015-03-12 11:28:44 +0100
committerNicolas Grekas <nicolas.grekas@gmail.com>2015-03-12 11:28:44 +0100
commit79b93b26ebf03b69df71bdeb51ec78811dcda90a (patch)
treed3d7b9f84d9455de3c6b159594508f36d7fffa4e
parentb883dbdf074f070aaf67e7f6da5bb9af807f7cbd (diff)
parent117752eeae89dc43f7a9d36ea8ce1f0690e97c5a (diff)
downloadsymfony-security-79b93b26ebf03b69df71bdeb51ec78811dcda90a.zip
symfony-security-79b93b26ebf03b69df71bdeb51ec78811dcda90a.tar.gz
symfony-security-79b93b26ebf03b69df71bdeb51ec78811dcda90a.tar.bz2
Merge branch '2.3' into 2.6
* 2.3: Changed visibility of setUp() and tearDown to protected fixed XSS in the exception handler Php Inspections (EA Extended) - static code analysis includes: [2.3] Remove most refs uses Test with local components instead of waiting for the subtree-splitter when possible Conflicts: src/Symfony/Bundle/FrameworkBundle/Command/ContainerDebugCommand.php src/Symfony/Component/Config/Util/XmlUtils.php src/Symfony/Component/Console/Helper/ProgressHelper.php src/Symfony/Component/Debug/ExceptionHandler.php src/Symfony/Component/Debug/Tests/ErrorHandlerTest.php src/Symfony/Component/Filesystem/Tests/FilesystemTest.php src/Symfony/Component/OptionsResolver/Options.php src/Symfony/Component/Security/Acl/Dbal/MutableAclProvider.php src/Symfony/Component/Yaml/Inline.php
-rw-r--r--Acl/Dbal/MutableAclProvider.php10
-rw-r--r--Http/EntryPoint/DigestAuthenticationEntryPoint.php2
2 files changed, 6 insertions, 6 deletions
diff --git a/Acl/Dbal/MutableAclProvider.php b/Acl/Dbal/MutableAclProvider.php
index edf997b..023a22f 100644
--- a/Acl/Dbal/MutableAclProvider.php
+++ b/Acl/Dbal/MutableAclProvider.php
@@ -256,7 +256,7 @@ class MutableAclProvider extends AclProvider implements MutableAclProviderInterf
if (null === $propertyChanges['parentAcl'][1]) {
$sets[] = 'parent_object_identity_id = NULL';
} else {
- $sets[] = 'parent_object_identity_id = '.intval($propertyChanges['parentAcl'][1]->getId());
+ $sets[] = 'parent_object_identity_id = '.(int) $propertyChanges['parentAcl'][1]->getId();
}
$this->regenerateAncestorRelations($acl);
@@ -478,7 +478,7 @@ QUERY;
$query,
$this->options['entry_table_name'],
$classId,
- null === $objectIdentityId ? 'NULL' : intval($objectIdentityId),
+ null === $objectIdentityId ? 'NULL' : (int) $objectIdentityId,
null === $field ? 'NULL' : $this->connection->quote($field),
$aceOrder,
$securityIdentityId,
@@ -596,7 +596,7 @@ QUERY;
$classId,
null === $oid ?
$this->connection->getDatabasePlatform()->getIsNullExpression('object_identity_id')
- : 'object_identity_id = '.intval($oid),
+ : 'object_identity_id = '.(int) $oid,
null === $field ?
$this->connection->getDatabasePlatform()->getIsNullExpression('field_name')
: 'field_name = '.$this->connection->quote($field),
@@ -879,7 +879,7 @@ QUERY;
$aceIdProperty = new \ReflectionProperty('Symfony\Component\Security\Acl\Domain\Entry', 'id');
$aceIdProperty->setAccessible(true);
- $aceIdProperty->setValue($ace, intval($aceId));
+ $aceIdProperty->setValue($ace, (int) $aceId);
}
}
}
@@ -953,7 +953,7 @@ QUERY;
$aceIdProperty = new \ReflectionProperty($ace, 'id');
$aceIdProperty->setAccessible(true);
- $aceIdProperty->setValue($ace, intval($aceId));
+ $aceIdProperty->setValue($ace, (int) $aceId);
}
}
}
diff --git a/Http/EntryPoint/DigestAuthenticationEntryPoint.php b/Http/EntryPoint/DigestAuthenticationEntryPoint.php
index 71a6313..5a7aa1a 100644
--- a/Http/EntryPoint/DigestAuthenticationEntryPoint.php
+++ b/Http/EntryPoint/DigestAuthenticationEntryPoint.php
@@ -50,7 +50,7 @@ class DigestAuthenticationEntryPoint implements AuthenticationEntryPointInterfac
$authenticateHeader = sprintf('Digest realm="%s", qop="auth", nonce="%s"', $this->realmName, $nonceValueBase64);
if ($authException instanceof NonceExpiredException) {
- $authenticateHeader = $authenticateHeader.', stale="true"';
+ $authenticateHeader .= ', stale="true"';
}
if (null !== $this->logger) {