diff options
author | Wouter Tinus <wouter.tinus@gmail.com> | 2020-04-22 19:58:13 +0200 |
---|---|---|
committer | Wouter Tinus <wouter.tinus@gmail.com> | 2020-04-22 19:58:13 +0200 |
commit | 4f4bfb53d185dbf11fbc7836f2bbddcb5c9fe2bd (patch) | |
tree | 8e63941dcd0c01d591ab828a7924ea1b8b508fb9 /src | |
parent | 4c6331add8296024a758660fb27218c70664d86c (diff) | |
download | letsencrypt-win-simple-4f4bfb53d185dbf11fbc7836f2bbddcb5c9fe2bd.zip letsencrypt-win-simple-4f4bfb53d185dbf11fbc7836f2bbddcb5c9fe2bd.tar.gz letsencrypt-win-simple-4f4bfb53d185dbf11fbc7836f2bbddcb5c9fe2bd.tar.bz2 |
fix warnings
Diffstat (limited to 'src')
4 files changed, 24 insertions, 24 deletions
diff --git a/src/main.test/Mock/Clients/IISClient.cs b/src/main.test/Mock/Clients/IISClient.cs index 6b8cc38..df0c1a8 100644 --- a/src/main.test/Mock/Clients/IISClient.cs +++ b/src/main.test/Mock/Clients/IISClient.cs @@ -121,7 +121,7 @@ namespace PKISharp.WACS.UnitTests.Mock.Clients public void UpdateBinding(MockSite site, MockBinding binding, BindingOptions bindingOptions) { - site.Bindings.Remove(binding); + _ = site.Bindings.Remove(binding); var updateOptions = bindingOptions .WithHost(binding.Host) .WithIP(binding.IP) diff --git a/src/main.test/Tests/BindingTests/Bindings.cs b/src/main.test/Tests/BindingTests/Bindings.cs index ac4a157..8e1bd3a 100644 --- a/src/main.test/Tests/BindingTests/Bindings.cs +++ b/src/main.test/Tests/BindingTests/Bindings.cs @@ -171,16 +171,16 @@ namespace PKISharp.WACS.UnitTests.Tests.BindingTests Assert.AreEqual(existingBindings.Count() + expectedNew, httpOnlySite.Bindings.Count); var newBindings = httpOnlySite.Bindings.Except(existingBindings); - newBindings.All(newBinding => - { - Assert.AreEqual(existingHost, newBinding.Host); - Assert.AreEqual("https", newBinding.Protocol); - Assert.AreEqual(storeName, newBinding.CertificateStoreName); - Assert.AreEqual(newCert, newBinding.CertificateHash); - Assert.AreEqual(bindingPort, newBinding.Port); - Assert.AreEqual(expectedFlags, newBinding.SSLFlags); - return true; - }); + _ = newBindings.All(newBinding => + { + Assert.AreEqual(existingHost, newBinding.Host); + Assert.AreEqual("https", newBinding.Protocol); + Assert.AreEqual(storeName, newBinding.CertificateStoreName); + Assert.AreEqual(newCert, newBinding.CertificateHash); + Assert.AreEqual(bindingPort, newBinding.Port); + Assert.AreEqual(expectedFlags, newBinding.SSLFlags); + return true; + }); var oldips = existingBindings.Select(x => x.IP).Distinct(); var newips = newBindings.Select(x => x.IP).Distinct(); diff --git a/src/main.test/Tests/InstallationPluginTests/MultipleInstallerTests.cs b/src/main.test/Tests/InstallationPluginTests/MultipleInstallerTests.cs index 331f241..e071c77 100644 --- a/src/main.test/Tests/InstallationPluginTests/MultipleInstallerTests.cs +++ b/src/main.test/Tests/InstallationPluginTests/MultipleInstallerTests.cs @@ -40,23 +40,23 @@ namespace PKISharp.WACS.UnitTests.Tests.InstallationPluginTests var builder = new ContainerBuilder(); - builder.RegisterInstance(plugins). + _ = builder.RegisterInstance(plugins). As<IPluginService>(). SingleInstance(); - builder.RegisterInstance(log). + _ = builder.RegisterInstance(log). As<ILogService>(). SingleInstance(); - builder.RegisterType<Mock.Clients.MockIISClient>(). + _ = builder.RegisterType<Mock.Clients.MockIISClient>(). As<IIISClient>(). SingleInstance(); - builder.RegisterType<ArgumentsParser>(). + _ = builder.RegisterType<ArgumentsParser>(). SingleInstance(). WithParameter(new TypedParameter(typeof(string[]), commandLine.Split(' '))); - builder.RegisterType<ArgumentsService>(). + _ = builder.RegisterType<ArgumentsService>(). As<IArgumentsService>(). SingleInstance(); - builder.RegisterType<mock.UserRoleService>().As<IUserRoleService>().SingleInstance(); - builder.RegisterType<UnattendedResolver>().As<IResolver>(); + _ = builder.RegisterType<mock.UserRoleService>().As<IUserRoleService>().SingleInstance(); + _ = builder.RegisterType<UnattendedResolver>().As<IResolver>(); plugins.Configure(builder); var scope = builder.Build(); diff --git a/src/plugin.validation.dns.azure/AzureArgumentsProvider.cs b/src/plugin.validation.dns.azure/AzureArgumentsProvider.cs index 6a5edcd..ce9d42b 100755 --- a/src/plugin.validation.dns.azure/AzureArgumentsProvider.cs +++ b/src/plugin.validation.dns.azure/AzureArgumentsProvider.cs @@ -10,22 +10,22 @@ namespace PKISharp.WACS.Plugins.ValidationPlugins public override string Condition => "--validationmode dns-01 --validation azure"; public override void Configure(FluentCommandLineParser<AzureArguments> parser) { - parser.Setup(o => o.AzureUseMsi) + _ = parser.Setup(o => o.AzureUseMsi) .As("azureusemsi") .WithDescription("Use Managed Service Identity for authentication."); - parser.Setup(o => o.AzureTenantId) + _ = parser.Setup(o => o.AzureTenantId) .As("azuretenantid") .WithDescription("Tenant ID to login into Microsoft Azure."); - parser.Setup(o => o.AzureClientId) + _ = parser.Setup(o => o.AzureClientId) .As("azureclientid") .WithDescription("Client ID to login into Microsoft Azure."); - parser.Setup(o => o.AzureSecret) + _ = parser.Setup(o => o.AzureSecret) .As("azuresecret") .WithDescription("Secret to login into Microsoft Azure."); - parser.Setup(o => o.AzureSubscriptionId) + _ = parser.Setup(o => o.AzureSubscriptionId) .As("azuresubscriptionid") .WithDescription("Subscription ID to login into Microsoft Azure DNS."); - parser.Setup(o => o.AzureResourceGroupName) + _ = parser.Setup(o => o.AzureResourceGroupName) .As("azureresourcegroupname") .WithDescription("The name of the resource group within Microsoft Azure DNS."); } |