diff options
| author | Wouter Tinus <win.acme.simple@gmail.com> | 2020-03-04 21:55:35 +0100 |
|---|---|---|
| committer | Wouter Tinus <win.acme.simple@gmail.com> | 2020-03-04 21:55:35 +0100 |
| commit | 478cc058349c9999a2786d269fa9181f2bc1f92a (patch) | |
| tree | 2c099feb84e180240730476bfb9db276bcf1fe07 /src/main.lib/Plugins/InstallationPlugins/Script | |
| parent | 5d5e6eb7505e817e2b869bd5bcbbba2b86bd38ed (diff) | |
| download | letsencrypt-win-simple-478cc058349c9999a2786d269fa9181f2bc1f92a.zip letsencrypt-win-simple-478cc058349c9999a2786d269fa9181f2bc1f92a.tar.gz letsencrypt-win-simple-478cc058349c9999a2786d269fa9181f2bc1f92a.tar.bz2 | |
remove numbered parameters and add comment about why
Diffstat (limited to 'src/main.lib/Plugins/InstallationPlugins/Script')
| -rw-r--r-- | src/main.lib/Plugins/InstallationPlugins/Script/Script.cs | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/src/main.lib/Plugins/InstallationPlugins/Script/Script.cs b/src/main.lib/Plugins/InstallationPlugins/Script/Script.cs index 29c0492..7b5b876 100644 --- a/src/main.lib/Plugins/InstallationPlugins/Script/Script.cs +++ b/src/main.lib/Plugins/InstallationPlugins/Script/Script.cs @@ -27,6 +27,9 @@ namespace PKISharp.WACS.Plugins.InstallationPlugins var defaultStoreType = store.First().GetType(); var defaultStoreInfo = newCertificate.StoreInfo[defaultStoreType]; var parameters = _options.ScriptParameters ?? ""; + + // Numbered parameters for backwards compatibility only, + // do not extend for future updates parameters = parameters.Replace("{0}", newCertificate.CommonName); parameters = parameters.Replace("{1}", _renewal.PfxPassword?.Value); parameters = parameters.Replace("{2}", newCertificate.CacheFile?.FullName); @@ -35,10 +38,7 @@ namespace PKISharp.WACS.Plugins.InstallationPlugins parameters = parameters.Replace("{5}", newCertificate.Certificate.Thumbprint); parameters = parameters.Replace("{6}", newCertificate.CacheFile?.Directory.FullName); parameters = parameters.Replace("{7}", _renewal.Id); - parameters = parameters.Replace("{8}", oldCertificate?.SubjectName); - parameters = parameters.Replace("{9}", oldCertificate?.Certificate.FriendlyName); - parameters = parameters.Replace("{10}", oldCertificate?.Certificate.Thumbprint); - + parameters = parameters.Replace("{CachePassword}", _renewal.PfxPassword?.Value); parameters = parameters.Replace("{CacheFile}", newCertificate.CacheFile?.FullName); parameters = parameters.Replace("{CacheFolder}", newCertificate.CacheFile?.FullName); @@ -48,7 +48,7 @@ namespace PKISharp.WACS.Plugins.InstallationPlugins parameters = parameters.Replace("{StoreType}", defaultStoreInfo.Name); parameters = parameters.Replace("{StorePath}", defaultStoreInfo.Path); parameters = parameters.Replace("{RenewalId}", _renewal.Id); - parameters = parameters.Replace("{OldCertCommonName}", oldCertificate?.SubjectName); + parameters = parameters.Replace("{OldCertCommonName}", oldCertificate?.CommonName); parameters = parameters.Replace("{OldCertFriendlyName}", oldCertificate?.Certificate.FriendlyName); parameters = parameters.Replace("{OldCertThumbprint}", oldCertificate?.Certificate.Thumbprint); |