Adapt Plugins.loadForBook to use correct order

1 files changed, 40 insertions, 43 deletions

diff --git a/lib/plugins/loadForBook.js b/lib/plugins/loadForBook.js
index a3f9dd0..757677e 100644
--- a/lib/plugins/loadForBook.js
+++ b/lib/plugins/loadForBook.js
@@ -1,6 +1,7 @@
-var Promise = require('../utils/promise');
+var Immutable = require('immutable');
 
-var listForBook = require('./listForBook');
+var Promise = require('../utils/promise');
+var listDepsForBook = require('./listDepsForBook');
 var findForBook = require('./findForBook');
 var loadPlugin = require('./loadPlugin');
 
@@ -13,60 +14,56 @@ var loadPlugin = require('./loadPlugin');
  */
 function loadForBook(book) {
     var logger = book.getLogger();
-    var requirements = listForBook(book);
-    var requirementsKeys = requirements.keySeq().toList();
-
-    return findForBook(book)
-    .then(function(installed) {
-        // Filter out plugins not listed of first level
-        // (aka pre-installed plugins)
-        /*installed = installed.filter(function(plugin) {
-            return (
-                // Plugin is a dependency of another one
-                plugin.getDepth() > 0 ||
-
-                // Plugin is specified in "book.json"
-                requirements.has(plugin.getName())
-            );
-        });*/
 
-        // Insert installed plugins not listed in required
-        var pluginsToLoad = installed.reduce(function(pluginSeq, plugin) {
-            var name = plugin.getName();
+    // List the dependencies
+    var requirements = listDepsForBook(book);
 
-            if (requirements.has(name)) {
-                return pluginSeq;
+    // List all plugins installed in the book
+    return findForBook(book)
+    .then(function(installedMap) {
+        var missing = [];
+        var plugins = requirements.reduce(function(result, dep) {
+            var name = dep.getName();
+            var installed = installedMap.get(name);
+
+            if (installed) {
+                var deps = installedMap
+                    .filter(function(plugin) {
+                        return plugin.getParent() === name;
+                    })
+                    .toArray();
+
+                result = result.concat(deps);
+                result.push(installed);
+            } else {
+                missing.push(name);
             }
 
-            var parentName = plugin.getParent();
-
-
-            pluginSeq = pluginSeq.push([
-                name,
-                plugin
-            ]);
-
-            return pluginSeq;
-        }, requirements.entrySeq());
-
+            return result;
+        }, []);
 
+        // Convert plugins list to a map
+        plugins = Immutable.List(plugins)
+            .map(function(plugin) {
+                return [
+                    plugin.getName(),
+                    plugin
+                ];
+            });
+        plugins = Immutable.OrderedMap(plugins);
 
         // Log state
-        logger.info.ln(installed.size + ' plugins are installed');
-        if (requirements.size != installed.size) {
+        logger.info.ln(installedMap.size + ' plugins are installed');
+        if (requirements.size != installedMap.size) {
             logger.info.ln(requirements.size + ' explicitly listed');
         }
 
         // Verify that all plugins are present
-        var notInstalled = requirementsKeys.filter(function(name) {
-            return !installed.has(name);
-        });
-
-        if (notInstalled.size > 0) {
-            throw new Error('Couldn\'t locate plugins "' + notInstalled.join(', ') + '", Run \'gitbook install\' to install plugins from registry.');
+        if (missing.length > 0) {
+            throw new Error('Couldn\'t locate plugins "' + missing.join(', ') + '", Run \'gitbook install\' to install plugins from registry.');
         }
 
-        return Promise.map(installed, function(plugin) {
+        return Promise.map(plugins, function(plugin) {
             return loadPlugin(book, plugin);
         });
     });