summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorSamy Pesse <samypesse@gmail.com>2016-06-07 00:48:47 +0200
committerSamy Pesse <samypesse@gmail.com>2016-06-07 00:48:47 +0200
commit996170a4ade4f72df2efb6ee2e75edaab669809f (patch)
tree50ce8da8b837e637a6cab3eef07e0fd329a991d0
parentaa66a4f928122856370d6d8579b9fd3d15fcccad (diff)
downloadgitbook-996170a4ade4f72df2efb6ee2e75edaab669809f.zip
gitbook-996170a4ade4f72df2efb6ee2e75edaab669809f.tar.gz
gitbook-996170a4ade4f72df2efb6ee2e75edaab669809f.tar.bz2
ConfigModifier.removePlugin should toggle off if default
-rw-r--r--lib/browser.js4
-rw-r--r--lib/modifiers/config/removePlugin.js12
2 files changed, 14 insertions, 2 deletions
diff --git a/lib/browser.js b/lib/browser.js
index bb84044..ce56b59 100644
--- a/lib/browser.js
+++ b/lib/browser.js
@@ -12,8 +12,8 @@ module.exports = {
PluginDependency: require('./models/pluginDependency'),
// Modifiers
- SummaryModifier: Modifiers.Summary,
- ConfigModifier: Modifiers.Config,
+ SummaryModifier: Modifiers.Summary,
+ ConfigModifier: Modifiers.Config,
// Constants
CONFIG_FILES: require('./constants/configFiles.js'),
diff --git a/lib/modifiers/config/removePlugin.js b/lib/modifiers/config/removePlugin.js
index 70ec3b1..123be0b 100644
--- a/lib/modifiers/config/removePlugin.js
+++ b/lib/modifiers/config/removePlugin.js
@@ -1,3 +1,5 @@
+var DEFAULT_PLUGINS = require('../../constants/defaultPlugins');
+var togglePlugin = require('./togglePlugin');
/**
* Remove a plugin from a book's configuration
@@ -8,6 +10,16 @@
function removePlugin(config, pluginName) {
var deps = config.getPluginDependencies();
+ var isDefault = DEFAULT_PLUGINS.find(function(dep) {
+ return dep.getName() === pluginName;
+ });
+
+ // For default plugin, we have to disable it instead of removing from the list
+ if (isDefault) {
+ return togglePlugin(config, pluginName, false);
+ }
+
+ // Remove the dependency from the list
deps = deps.filter(function(dep) {
return dep.getName() === pluginName;
});