summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorIgnace Nyamagana Butera <nyamsprod@gmail.com>2014-04-25 10:44:00 +0200
committerIgnace Nyamagana Butera <nyamsprod@gmail.com>2014-04-25 10:44:00 +0200
commitb774352a74765cd6b9aa66e0a716228518fe9b62 (patch)
treefb2d11778b475399bc41f3447b6e115b345bf2f8
parent7ed6ce08e944e9ac9659b6bf675919503db7542e (diff)
downloadcsv-b774352a74765cd6b9aa66e0a716228518fe9b62.zip
csv-b774352a74765cd6b9aa66e0a716228518fe9b62.tar.gz
csv-b774352a74765cd6b9aa66e0a716228518fe9b62.tar.bz2
remove internal Reader::execute method
-rw-r--r--src/Reader.php33
1 files changed, 8 insertions, 25 deletions
diff --git a/src/Reader.php b/src/Reader.php
index e714f43..0e335e8 100644
--- a/src/Reader.php
+++ b/src/Reader.php
@@ -92,15 +92,18 @@ class Reader extends AbstractCsv
}
/**
- * Return a filtered Iterator based on the filtering settings
+ * Return a Filtered Iterator
*
- * @param Iterator $iterator The iterator to be filtered
* @param callable $callable a callable function to be applied to each Iterator item
*
- * @return Iterator
+ * @return \Iterator
*/
- protected function execute(Iterator $iterator, callable $callable = null)
+ public function query(callable $callable = null)
{
+ $iterator = new CallbackFilterIterator($this->getIterator(), function ($row) {
+ return is_array($row);
+ });
+
$iterator = $this->applyFilter($iterator);
$iterator = $this->applySortBy($iterator);
$iterator = $this->applyInterval($iterator);
@@ -112,22 +115,6 @@ class Reader extends AbstractCsv
}
/**
- * Return a Filtered Iterator
- *
- * @param callable $callable a callable function to be applied to each Iterator item
- *
- * @return \Iterator
- */
- public function query(callable $callable = null)
- {
- $iterator = new CallbackFilterIterator($this->getIterator(), function ($row) {
- return is_array($row);
- });
-
- return $this->execute($iterator, $callable);
- }
-
- /**
* Apply a callback function on the CSV
*
* @param callable $callable The callback function to call on every element.
@@ -138,11 +125,7 @@ class Reader extends AbstractCsv
*/
public function each(callable $callable)
{
- $iterator = new CallbackFilterIterator($this->getIterator(), function ($row) {
- return is_array($row);
- });
-
- $iterator = $this->execute($iterator);
+ $iterator = $this->query();
$index = 0;
foreach ($iterator as $rowIndex => $row) {
if (true !== $callable($row, $rowIndex, $iterator)) {