diff options
author | Deven Bansod <devenbansod@users.noreply.github.com> | 2018-12-09 15:51:22 +0530 |
---|---|---|
committer | GitHub <noreply@github.com> | 2018-12-09 15:51:22 +0530 |
commit | 5e8dbcf3ff0d1123efd731863083a9af539e5992 (patch) | |
tree | b60470ba4a628ee748310403dd71caad46101968 /src/Components/SetOperation.php | |
parent | ad6a0ce1efcde74726e28e9b3da9ffad3fc4c474 (diff) | |
parent | 4b3684f16ecb3539057cbba3141473c059141a45 (diff) | |
download | sql-parser-5e8dbcf3ff0d1123efd731863083a9af539e5992.zip sql-parser-5e8dbcf3ff0d1123efd731863083a9af539e5992.tar.gz sql-parser-5e8dbcf3ff0d1123efd731863083a9af539e5992.tar.bz2 |
Merge pull request #206 from bperel/cleanup
Cleanup the code
* Avoid duplicate if conditions
* Use switch/case instead of ifs when possible
* Use triple (in)equalities when type compatibility is ensured
Diffstat (limited to 'src/Components/SetOperation.php')
-rw-r--r-- | src/Components/SetOperation.php | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/Components/SetOperation.php b/src/Components/SetOperation.php index 83f2e55..7dab0a1 100644 --- a/src/Components/SetOperation.php +++ b/src/Components/SetOperation.php @@ -94,7 +94,7 @@ class SetOperation extends Component // No keyword is expected. if (($token->type === Token::TYPE_KEYWORD) && ($token->flags & Token::FLAG_KEYWORD_RESERVED) - && ($state == 0) + && ($state === 0) ) { break; } @@ -113,7 +113,7 @@ class SetOperation extends Component 'breakOnAlias' => true, ) ); - if ($tmp == null) { + if (is_null($tmp)) { $parser->error('Missing expression.', $token); break; } |