summaryrefslogtreecommitdiffstats
path: root/src/Components/ExpressionArray.php
diff options
context:
space:
mode:
authorDan Ungureanu <udan1107@gmail.com>2015-07-19 14:36:53 +0300
committerDan Ungureanu <udan1107@gmail.com>2015-07-19 14:36:53 +0300
commit5e554b3534c44f122906fea36ef7698a5769316b (patch)
tree4cd766c505b0f93498eccc6d75f9446b21f6a5a4 /src/Components/ExpressionArray.php
parentb894375c04eb138f4c541623e644be8364ff11de (diff)
downloadsql-parser-5e554b3534c44f122906fea36ef7698a5769316b.zip
sql-parser-5e554b3534c44f122906fea36ef7698a5769316b.tar.gz
sql-parser-5e554b3534c44f122906fea36ef7698a5769316b.tar.bz2
Avoid processing the alias twice and generate an error.
Errors are triggered when an unexpected token is found between clauses. Refactoring.
Diffstat (limited to 'src/Components/ExpressionArray.php')
-rw-r--r--src/Components/ExpressionArray.php35
1 files changed, 28 insertions, 7 deletions
diff --git a/src/Components/ExpressionArray.php b/src/Components/ExpressionArray.php
index d62f34c..afabc3a 100644
--- a/src/Components/ExpressionArray.php
+++ b/src/Components/ExpressionArray.php
@@ -38,6 +38,20 @@ class ExpressionArray extends Component
$expr = null;
+ /**
+ * The state of the parser.
+ *
+ * Below are the states of the parser.
+ *
+ * 0 ----------------------[ array ]---------------------> 1
+ *
+ * 1 ------------------------[ , ]------------------------> 0
+ * 1 -----------------------[ else ]----------------------> -1
+ *
+ * @var int
+ */
+ $state = 0;
+
for (; $list->idx < $list->count; ++$list->idx) {
/**
* Token parsed at this moment.
@@ -60,20 +74,27 @@ class ExpressionArray extends Component
break;
}
- if (($token->type === Token::TYPE_OPERATOR) && ($token->value === ',')) {
- $ret[] = $expr;
- } else {
+ if ($state === 0) {
$expr = Expression::parse($parser, $list, $options);
if ($expr === null) {
break;
}
+ $ret[] = $expr;
+ $state = 1;
+ } elseif ($state === 1) {
+ if ($token->value === ',') {
+ $state = 0;
+ } else {
+ break;
+ }
}
-
}
- // Last iteration was not processed.
- if ($expr !== null) {
- $ret[] = $expr;
+ if ($state === 0) {
+ $parser->error(
+ 'An expression was expected.',
+ $list->tokens[$list->idx]
+ );
}
--$list->idx;