summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMichal Čihař <michal@cihar.com>2017-01-06 12:35:39 +0100
committerMichal Čihař <michal@cihar.com>2017-01-06 12:35:39 +0100
commit6bb07eaa6672ae56f02e24ec449dfa71d456385b (patch)
tree180da1624ed5bfe18da32ad7f9dc8d395152b9a4
parent1fae088096d4b36c761c586e038b25adfb31e538 (diff)
downloadsql-parser-6bb07eaa6672ae56f02e24ec449dfa71d456385b.zip
sql-parser-6bb07eaa6672ae56f02e24ec449dfa71d456385b.tar.gz
sql-parser-6bb07eaa6672ae56f02e24ec449dfa71d456385b.tar.bz2
Properly handle operators AND, NOT, OR, XOR, DIV, MOD
Signed-off-by: Michal Čihař <michal@cihar.com>
-rw-r--r--CHANGELOG.md1
-rw-r--r--src/Components/Expression.php1
-rw-r--r--tests/Parser/SelectStatementTest.php1
-rw-r--r--tests/data/parser/parseSelect11.in1
-rw-r--r--tests/data/parser/parseSelect11.out4
5 files changed, 8 insertions, 0 deletions
diff --git a/CHANGELOG.md b/CHANGELOG.md
index fe8df4d..1bf3197 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -9,6 +9,7 @@
* PHP 7.2 compatibility.
* Better parameter passing to query formatter.
* Coding style fixes.
+* Properly handle operators AND, NOT, OR, XOR, DIV, MOD
## [3.4.14] - 2016-11-30
diff --git a/src/Components/Expression.php b/src/Components/Expression.php
index b0c45df..9c71d25 100644
--- a/src/Components/Expression.php
+++ b/src/Components/Expression.php
@@ -30,6 +30,7 @@ class Expression extends Component
*/
private static $ALLOWED_KEYWORDS = array(
'AS' => 1, 'DUAL' => 1, 'NULL' => 1, 'REGEXP' => 1, 'CASE' => 1,
+ 'DIV' => 1, 'AND' => 1, 'OR' => 1, 'XOR' => 1, 'NOT' => 1, 'MOD' => 1,
);
/**
diff --git a/tests/Parser/SelectStatementTest.php b/tests/Parser/SelectStatementTest.php
index bbfc926..f0502fc 100644
--- a/tests/Parser/SelectStatementTest.php
+++ b/tests/Parser/SelectStatementTest.php
@@ -35,6 +35,7 @@ class SelectStatementTest extends TestCase
array('parser/parseSelect8'),
array('parser/parseSelect9'),
array('parser/parseSelect10'),
+ array('parser/parseSelect11'),
array('parser/parseSelectErr1'),
array('parser/parseSelectNested'),
array('parser/parseSelectCase1'),
diff --git a/tests/data/parser/parseSelect11.in b/tests/data/parser/parseSelect11.in
new file mode 100644
index 0000000..99f01a8
--- /dev/null
+++ b/tests/data/parser/parseSelect11.in
@@ -0,0 +1 @@
+SELECT 1 AND NOT 1
diff --git a/tests/data/parser/parseSelect11.out b/tests/data/parser/parseSelect11.out
new file mode 100644
index 0000000..2f08592
--- /dev/null
+++ b/tests/data/parser/parseSelect11.out
@@ -0,0 +1,4 @@
+a:4:{s:5:"query";s:19:"SELECT 1 AND NOT 1
+";s:5:"lexer";O:15:"SqlParser\Lexer":8:{s:6:"strict";b:0;s:3:"str";s:19:"SELECT 1 AND NOT 1
+";s:3:"len";i:19;s:4:"last";i:19;s:4:"list";O:20:"SqlParser\TokensList":3:{s:6:"tokens";a:11:{i:0;O:15:"SqlParser\Token":5:{s:5:"token";s:6:"SELECT";s:5:"value";s:6:"SELECT";s:4:"type";i:1;s:5:"flags";i:3;s:8:"position";i:0;}i:1;O:15:"SqlParser\Token":5:{s:5:"token";s:1:" ";s:5:"value";s:1:" ";s:4:"type";i:3;s:5:"flags";i:0;s:8:"position";i:6;}i:2;O:15:"SqlParser\Token":5:{s:5:"token";s:1:"1";s:5:"value";i:1;s:4:"type";i:6;s:5:"flags";i:0;s:8:"position";i:7;}i:3;O:15:"SqlParser\Token":5:{s:5:"token";s:1:" ";s:5:"value";s:1:" ";s:4:"type";i:3;s:5:"flags";i:0;s:8:"position";i:8;}i:4;O:15:"SqlParser\Token":5:{s:5:"token";s:3:"AND";s:5:"value";s:3:"AND";s:4:"type";i:1;s:5:"flags";i:3;s:8:"position";i:9;}i:5;O:15:"SqlParser\Token":5:{s:5:"token";s:1:" ";s:5:"value";s:1:" ";s:4:"type";i:3;s:5:"flags";i:0;s:8:"position";i:12;}i:6;O:15:"SqlParser\Token":5:{s:5:"token";s:3:"NOT";s:5:"value";s:3:"NOT";s:4:"type";i:1;s:5:"flags";i:3;s:8:"position";i:13;}i:7;O:15:"SqlParser\Token":5:{s:5:"token";s:1:" ";s:5:"value";s:1:" ";s:4:"type";i:3;s:5:"flags";i:0;s:8:"position";i:16;}i:8;O:15:"SqlParser\Token":5:{s:5:"token";s:1:"1";s:5:"value";i:1;s:4:"type";i:6;s:5:"flags";i:0;s:8:"position";i:17;}i:9;O:15:"SqlParser\Token":5:{s:5:"token";s:1:"
+";s:5:"value";s:1:" ";s:4:"type";i:3;s:5:"flags";i:0;s:8:"position";i:18;}i:10;O:15:"SqlParser\Token":5:{s:5:"token";N;s:5:"value";N;s:4:"type";i:9;s:5:"flags";i:0;s:8:"position";N;}}s:5:"count";i:11;s:3:"idx";i:11;}s:9:"delimiter";s:1:";";s:12:"delimiterLen";i:1;s:6:"errors";a:0:{}}s:6:"parser";O:16:"SqlParser\Parser":5:{s:4:"list";r:8;s:6:"strict";b:0;s:6:"errors";a:0:{}s:10:"statements";a:1:{i:0;O:36:"SqlParser\Statements\SelectStatement":16:{s:4:"expr";a:1:{i:0;O:31:"SqlParser\Components\Expression":7:{s:8:"database";N;s:5:"table";N;s:6:"column";N;s:4:"expr";s:11:"1 AND NOT 1";s:5:"alias";N;s:8:"function";N;s:8:"subquery";N;}}s:4:"from";a:0:{}s:9:"partition";N;s:5:"where";N;s:5:"group";N;s:6:"having";N;s:5:"order";N;s:5:"limit";N;s:9:"procedure";N;s:4:"into";N;s:4:"join";N;s:5:"union";a:0:{}s:11:"end_options";N;s:7:"options";O:33:"SqlParser\Components\OptionsArray":1:{s:7:"options";a:0:{}}s:5:"first";i:0;s:4:"last";i:9;}}s:8:"brackets";i:0;}s:6:"errors";a:2:{s:5:"lexer";a:0:{}s:6:"parser";a:0:{}}} \ No newline at end of file