rawurlencode solution arguments before interpolationorigin/urlencode-url-parts

  - URL segments are generally sids, but in the case that they are phone
     numbers or sid-likes, they should be `rawurlencode()`d
  - Updates the Holodeck assertions so they produce better failure messages.
  - Updates appropriate tests to assert correct behavior.

1 files changed, 11 insertions, 11 deletions

diff --git a/Twilio/Tests/Integration/Taskrouter/V1/Workspace/WorkflowTest.php b/Twilio/Tests/Integration/Taskrouter/V1/Workspace/WorkflowTest.php
index d99af2a..16a35a0 100644
--- a/Twilio/Tests/Integration/Taskrouter/V1/Workspace/WorkflowTest.php
+++ b/Twilio/Tests/Integration/Taskrouter/V1/Workspace/WorkflowTest.php
@@ -25,10 +25,10 @@ class WorkflowTest extends HolodeckTestCase {
         } catch (DeserializeException $e) {}
           catch (TwilioException $e) {}
         
-        $this->assertTrue($this->holodeck->hasRequest(new Request(
+        $this->assertRequest(new Request(
             'get',
             'https://taskrouter.twilio.com/v1/Workspaces/WSaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa/Workflows/WFaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa'
-        )));
+        ));
     }
 
     public function testFetchResponse() {
@@ -67,10 +67,10 @@ class WorkflowTest extends HolodeckTestCase {
         } catch (DeserializeException $e) {}
           catch (TwilioException $e) {}
         
-        $this->assertTrue($this->holodeck->hasRequest(new Request(
+        $this->assertRequest(new Request(
             'post',
             'https://taskrouter.twilio.com/v1/Workspaces/WSaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa/Workflows/WFaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa'
-        )));
+        ));
     }
 
     public function testUpdateResponse() {
@@ -109,10 +109,10 @@ class WorkflowTest extends HolodeckTestCase {
         } catch (DeserializeException $e) {}
           catch (TwilioException $e) {}
         
-        $this->assertTrue($this->holodeck->hasRequest(new Request(
+        $this->assertRequest(new Request(
             'delete',
             'https://taskrouter.twilio.com/v1/Workspaces/WSaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa/Workflows/WFaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa'
-        )));
+        ));
     }
 
     public function testDeleteResponse() {
@@ -136,10 +136,10 @@ class WorkflowTest extends HolodeckTestCase {
         } catch (DeserializeException $e) {}
           catch (TwilioException $e) {}
         
-        $this->assertTrue($this->holodeck->hasRequest(new Request(
+        $this->assertRequest(new Request(
             'get',
             'https://taskrouter.twilio.com/v1/Workspaces/WSaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa/Workflows'
-        )));
+        ));
     }
 
     public function testReadFullResponse() {
@@ -180,7 +180,7 @@ class WorkflowTest extends HolodeckTestCase {
         $actual = $this->twilio->taskrouter->v1->workspaces("WSaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa")
                                                ->workflows->read();
         
-        $this->assertTrue(count($actual) > 0);
+        $this->assertGreaterThan(0, count($actual));
     }
 
     public function testReadEmptyResponse() {
@@ -224,12 +224,12 @@ class WorkflowTest extends HolodeckTestCase {
             'AssignmentCallbackUrl' => "https://example.com",
         );
         
-        $this->assertTrue($this->holodeck->hasRequest(new Request(
+        $this->assertRequest(new Request(
             'post',
             'https://taskrouter.twilio.com/v1/Workspaces/WSaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa/Workflows',
             null,
             $values
-        )));
+        ));
     }
 
     public function testCreateResponse() {