still use in_array, just require strict type checking

Signed-off-by: Will Norris <will@willnorris.com>

1 files changed, 2 insertions, 4 deletions

diff --git a/Auth/OpenID/Association.php b/Auth/OpenID/Association.php
index 6a3a11b..07aaee1 100644
--- a/Auth/OpenID/Association.php
+++ b/Auth/OpenID/Association.php
@@ -131,10 +131,8 @@ class Auth_OpenID_Association {
     function Auth_OpenID_Association(
         $handle, $secret, $issued, $lifetime, $assoc_type)
     {
-        // use array_key_exists because in_array doesn't check
-        // correctly for numerical indexes
-        $types_hash = array_flip(Auth_OpenID_getSupportedAssociationTypes());
-        if (!array_key_exists($assoc_type, $types_hash)) {
+        if (!in_array($assoc_type,
+                      Auth_OpenID_getSupportedAssociationTypes(), true)) {
             $fmt = 'Unsupported association type (%s)';
             trigger_error(sprintf($fmt, $assoc_type), E_USER_ERROR);
         }