Added the following patch from the trac.openidenabled.com bug tracker:

http://trac.openidenabled.com/trac/ticket/338
(http://trac.openidenabled.com/trac/attachment/ticket/338/openid-php5.3.diff)

Patch makes php-openid library compatible with PHP 5.3, and included changes to many files.

Original Message:
Reported by:  	http://paulisageek.com/
Opened 6 months ago
Last modified 2 months ago
php openid library doesn't seem to work with php 5.3

	"I get many PHP warnings and then the error condition on the Consumer.

	Deprecated: Assigning the return value of new by reference is deprecated in *path*/Auth/OpenID/Consumer.php on line 271

	Deprecated: Assigning the return value of new by reference is deprecated in *path*/Auth/OpenID/Consumer.php on line 273

	Warning: Parameter 1 to filter_MatchesAnyOpenIDType() expected to be a reference, value given in *path*/Auth/Yadis/XRDS.php on line 431

	Warning: Parameter 2 to Auth_OpenID_GenericConsumer::_completeInvalid() expected to be a reference, value given in *path*/Auth/OpenID/Consumer.php on line 669 "

It should be noted that 3 hunks across 7 files failed, and I applied most of them manually. 7 files were patched.

1 files changed, 1 insertions, 1 deletions

diff --git a/Auth/OpenID/TrustRoot.php b/Auth/OpenID/TrustRoot.php
index 0f53958..000440b 100644
--- a/Auth/OpenID/TrustRoot.php
+++ b/Auth/OpenID/TrustRoot.php
@@ -413,7 +413,7 @@ function Auth_OpenID_getAllowedReturnURLs($relying_party_url, $fetcher,
     }
 
     call_user_func_array($discover_function,
-                         array($relying_party_url, $fetcher));
+                         array($relying_party_url, &$fetcher));
 
     $return_to_urls = array();
     $matching_endpoints = Auth_OpenID_extractReturnURL($endpoints);