diff options
author | Lilli <lilli@janrain.com> | 2010-02-16 12:17:30 -0800 |
---|---|---|
committer | Lilli <lilli@janrain.com> | 2010-02-16 12:17:30 -0800 |
commit | 3edee3a03ec4b187fb44f8af7daa128ed6b8fc5e (patch) | |
tree | 5e564cecaf85388dca8faf630485540f2955ce5c /Auth/OpenID/Consumer.php | |
parent | 634d7b470e82e34ca2730c168332232259cf17d1 (diff) | |
download | php-openid-3edee3a03ec4b187fb44f8af7daa128ed6b8fc5e.zip php-openid-3edee3a03ec4b187fb44f8af7daa128ed6b8fc5e.tar.gz php-openid-3edee3a03ec4b187fb44f8af7daa128ed6b8fc5e.tar.bz2 |
Added the following patch from the trac.openidenabled.com bug tracker:
http://trac.openidenabled.com/trac/ticket/338
(http://trac.openidenabled.com/trac/attachment/ticket/338/openid-php5.3.diff)
Patch makes php-openid library compatible with PHP 5.3, and included changes to many files.
Original Message:
Reported by: http://paulisageek.com/
Opened 6 months ago
Last modified 2 months ago
php openid library doesn't seem to work with php 5.3
"I get many PHP warnings and then the error condition on the Consumer.
Deprecated: Assigning the return value of new by reference is deprecated in *path*/Auth/OpenID/Consumer.php on line 271
Deprecated: Assigning the return value of new by reference is deprecated in *path*/Auth/OpenID/Consumer.php on line 273
Warning: Parameter 1 to filter_MatchesAnyOpenIDType() expected to be a reference, value given in *path*/Auth/Yadis/XRDS.php on line 431
Warning: Parameter 2 to Auth_OpenID_GenericConsumer::_completeInvalid() expected to be a reference, value given in *path*/Auth/OpenID/Consumer.php on line 669 "
It should be noted that 3 hunks across 7 files failed, and I applied most of them manually. 7 files were patched.
Diffstat (limited to 'Auth/OpenID/Consumer.php')
-rw-r--r-- | Auth/OpenID/Consumer.php | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/Auth/OpenID/Consumer.php b/Auth/OpenID/Consumer.php index 92466cf..98e408b 100644 --- a/Auth/OpenID/Consumer.php +++ b/Auth/OpenID/Consumer.php @@ -666,7 +666,7 @@ class Auth_OpenID_GenericConsumer { '_completeInvalid'); return call_user_func_array(array($this, $method), - array($message, $endpoint, $return_to)); + array($message, &$endpoint, $return_to)); } /** @@ -1181,7 +1181,7 @@ class Auth_OpenID_GenericConsumer { // oidutil.log('Performing discovery on %s' % (claimed_id,)) list($unused, $services) = call_user_func($this->discoverMethod, $claimed_id, - $this->fetcher); + &$this->fetcher); if (!$services) { return new Auth_OpenID_FailureResponse(null, |