[ few random cleanup changes ]

A few minor changes made over the past few months. This adds some
additional logging, an extra helper function for error messages,
and fixes a small bug with the association handler ... not to mention
standardizing on "false" instead of "False".

Signed-off-by: Will Norris <will@willnorris.com>

1 files changed, 14 insertions, 3 deletions

diff --git a/Auth/OpenID.php b/Auth/OpenID.php
index bc66d62..924cd1e 100644
--- a/Auth/OpenID.php
+++ b/Auth/OpenID.php
@@ -102,9 +102,7 @@ define('Auth_OpenID_digits',
 define('Auth_OpenID_punct',
        "!\"#$%&'()*+,-./:;<=>?@[\\]^_`{|}~");
 
-if (Auth_OpenID_getMathLib() === null) {
-    Auth_OpenID_setNoMathSupport();
-}
+Auth_OpenID_include_init();
 
 /**
  * The OpenID utility function class.
@@ -139,6 +137,9 @@ class Auth_OpenID {
      * Returns an empty array if neither GET nor POST was used, or if
      * POST was used but php://input cannot be opened.
      *
+     * See background:
+     * http://lists.openidenabled.com/pipermail/dev/2007-March/000395.html
+     *
      * @access private
      */
     function getQuery($query_str=null)
@@ -550,3 +551,13 @@ class Auth_OpenID {
     }
 }
 
+/*
+ * Function to run when this file is included.
+ * Abstracted to a function to make life easier
+ * for some PHP optimizers.
+ */
+function Auth_OpenID_include_init() {
+  if (Auth_OpenID_getMathLib() === null) {
+    Auth_OpenID_setNoMathSupport();
+  }
+}