1 files changed, 65 insertions, 20 deletions

diff --git a/src/DotNetOpenAuth.OAuth2.Client/OAuth2/ClientCredentialApplicator.cs b/src/DotNetOpenAuth.OAuth2.Client/OAuth2/ClientCredentialApplicator.cs
index ac78a90..67e7234 100644
--- a/src/DotNetOpenAuth.OAuth2.Client/OAuth2/ClientCredentialApplicator.cs
+++ b/src/DotNetOpenAuth.OAuth2.Client/OAuth2/ClientCredentialApplicator.cs
@@ -13,63 +13,108 @@ namespace DotNetOpenAuth.OAuth2 {
 	using DotNetOpenAuth.Messaging;
 	using DotNetOpenAuth.OAuth2.Messages;
 
+	/// <summary>
+	/// A base class for extensions that apply client authentication to messages for the authorization server in specific ways.
+	/// </summary>
 	public abstract class ClientCredentialApplicator {
+		/// <summary>
+		/// Initializes a new instance of the <see cref="ClientCredentialApplicator"/> class.
+		/// </summary>
 		protected ClientCredentialApplicator() {
 		}
 
+		/// <summary>
+		/// Transmits the secret the client shares with the authorization server as a parameter in the POST entity payload.
+		/// </summary>
+		/// <param name="clientSecret">The secret the client shares with the authorization server.</param>
+		/// <returns>The credential applicator to provide to the <see cref="ClientBase"/> instance.</returns>
 		public static ClientCredentialApplicator SecretParameter(string clientSecret) {
 			Requires.NotNullOrEmpty(clientSecret, "clientSecret");
 			return new SecretParameterApplicator(clientSecret);
 		}
 
-		public static ClientCredentialApplicator NetworkCredential(NetworkCredential credential) {
-			Requires.NotNull(credential, "credential");
-			return new NetworkCredentialApplicator(credential);
+		/// <summary>
+		/// Transmits the client identifier and secret in the HTTP Authorization header via HTTP Basic authentication.
+		/// </summary>
+		/// <param name="clientSecret">The secret the client shares with the authorization server.</param>
+		/// <returns>The credential applicator to provide to the <see cref="ClientBase"/> instance.</returns>
+		public static ClientCredentialApplicator HttpBasic(string clientSecret) {
+			Requires.NotNullOrEmpty(clientSecret, "clientSecret");
+			return new HttpBasicApplicator(clientSecret);
 		}
 
+		/// <summary>
+		/// Never transmits a secret.  Useful for anonymous clients or clients unable to keep a secret.
+		/// </summary>
+		/// <returns>The credential applicator to provide to the <see cref="ClientBase"/> instance.</returns>
 		public static ClientCredentialApplicator NoSecret() {
 			return null;
 		}
 
-		public virtual void ApplyClientCredential(string clientIdentifier, AuthenticatedClientRequestBase request) {
-		}
+		/// <summary>
+		/// Applies the client identifier and (when applicable) the client authentication to an outbound message.
+		/// </summary>
+		/// <param name="clientIdentifier">The identifier by which the authorization server should recognize this client.</param>
+		/// <param name="request">The outbound message to apply authentication information to.</param>
+		public abstract void ApplyClientCredential(string clientIdentifier, AuthenticatedClientRequestBase request);
 
-		public virtual void ApplyClientCredential(string clientIdentifier, HttpWebRequest request) {
-		}
+		/// <summary>
+		/// Authenticates the client via HTTP Basic.
+		/// </summary>
+		private class HttpBasicApplicator : ClientCredentialApplicator {
+			/// <summary>
+			/// The client secret.
+			/// </summary>
+			private readonly string clientSecret;
 
-		private class NetworkCredentialApplicator : ClientCredentialApplicator {
-			private readonly NetworkCredential credential;
-
-			internal NetworkCredentialApplicator(NetworkCredential credential) {
-				Requires.NotNull(credential, "credential");
-				this.credential = credential;
+			/// <summary>
+			/// Initializes a new instance of the <see cref="HttpBasicApplicator"/> class.
+			/// </summary>
+			/// <param name="clientSecret">The client secret.</param>
+			internal HttpBasicApplicator(string clientSecret) {
+				Requires.NotNullOrEmpty(clientSecret, "clientSecret");
+				this.clientSecret = clientSecret;
 			}
 
+			/// <summary>
+			/// Applies the client identifier and (when applicable) the client authentication to an outbound message.
+			/// </summary>
+			/// <param name="clientIdentifier">The identifier by which the authorization server should recognize this client.</param>
+			/// <param name="request">The outbound message to apply authentication information to.</param>
 			public override void ApplyClientCredential(string clientIdentifier, AuthenticatedClientRequestBase request) {
 				// When using network credentials, the client authentication is not done as standard message parts.
 				request.ClientIdentifier = null;
 				request.ClientSecret = null;
-				OAuthUtilities.ApplyHttpBasicAuth(request.Headers, clientIdentifier, this.credential.Password);
-			}
-
-			public override void ApplyClientCredential(string clientIdentifier, HttpWebRequest request) {
+				OAuthUtilities.ApplyHttpBasicAuth(request.Headers, clientIdentifier, this.clientSecret);
 			}
 		}
 
+		/// <summary>
+		/// Authenticates the client via a client_secret parameter in the message.
+		/// </summary>
 		private class SecretParameterApplicator : ClientCredentialApplicator {
+			/// <summary>
+			/// The client secret.
+			/// </summary>
 			private readonly string secret;
 
+			/// <summary>
+			/// Initializes a new instance of the <see cref="SecretParameterApplicator"/> class.
+			/// </summary>
+			/// <param name="clientSecret">The client secret.</param>
 			internal SecretParameterApplicator(string clientSecret) {
 				Requires.NotNullOrEmpty(clientSecret, "clientSecret");
 				this.secret = clientSecret;
 			}
 
+			/// <summary>
+			/// Applies the client identifier and (when applicable) the client authentication to an outbound message.
+			/// </summary>
+			/// <param name="clientIdentifier">The identifier by which the authorization server should recognize this client.</param>
+			/// <param name="request">The outbound message to apply authentication information to.</param>
 			public override void ApplyClientCredential(string clientIdentifier, AuthenticatedClientRequestBase request) {
 				request.ClientSecret = this.secret;
 			}
-
-			public override void ApplyClientCredential(string clientIdentifier, HttpWebRequest request) {
-			}
 		}
 	}
 }