BREAKING CHANGE for SimpleRegistration extension, and other stuff.

* SimpleRegistration changed from struct to class.
* SimpleRegistrationFieldValues.None and SimpleRegistrationRequestFields.None removed.
* Semantic for extension classes that ReadFromRequest or ReadFromResponse and don't find any matching parameters changed from returning an empty struct to returning null.
* Added framework for testing extensions.
* Upgraded TestWeb project to .NET 3.5.
* Built up bare framework for sending/receiving Attribute Exchange extension messages.

1 files changed, 21 insertions, 13 deletions

diff --git a/src/DotNetOpenId.Test/ProfileFieldValuesTests.cs b/src/DotNetOpenId.Test/ProfileFieldValuesTests.cs
index 6834942..323b05b 100644
--- a/src/DotNetOpenId.Test/ProfileFieldValuesTests.cs
+++ b/src/DotNetOpenId.Test/ProfileFieldValuesTests.cs
@@ -18,7 +18,7 @@ using DotNetOpenId.Extensions;
 namespace DotNetOpenId.Test {

 	[TestFixture]

 	public class ProfileFieldValuesTests {

-		SimpleRegistrationFieldValues getFilledStruct() {

+		SimpleRegistrationFieldValues getFilledData() {

 			return new SimpleRegistrationFieldValues() {

 				BirthDate = new DateTime(2005, 2, 3),

 				Culture = new System.Globalization.CultureInfo("en-US"),

@@ -33,7 +33,7 @@ namespace DotNetOpenId.Test {
 

 		[Test]

 		public void BinarySerialization() {

-			SimpleRegistrationFieldValues fields = getFilledStruct();

+			SimpleRegistrationFieldValues fields = getFilledData();

 			MemoryStream ms = new MemoryStream();

 			IFormatter formatter = new BinaryFormatter();

 			formatter.Serialize(ms, fields);

@@ -45,7 +45,7 @@ namespace DotNetOpenId.Test {
 

 		[Test]

 		public void XmlSerialization() {

-			SimpleRegistrationFieldValues fields = getFilledStruct();

+			SimpleRegistrationFieldValues fields = getFilledData();

 			MemoryStream ms = new MemoryStream();

 			XmlSerializer xs = new XmlSerializer(typeof(SimpleRegistrationFieldValues));

 			xs.Serialize(ms, fields);

@@ -57,40 +57,48 @@ namespace DotNetOpenId.Test {
 

 		[Test]

 		public void TestEquals() {

-			SimpleRegistrationFieldValues fields1 = getFilledStruct();

+			SimpleRegistrationFieldValues fields1 = getFilledData();

 

 			Assert.AreNotEqual(fields1, null);

 			Assert.AreNotEqual(fields1, "string");

 

-			SimpleRegistrationFieldValues fields2 = fields1;

+			SimpleRegistrationFieldValues fields2 = getFilledData();

 			Assert.AreNotSame(fields1, fields2, "Test sanity check.");

 			Assert.AreEqual(fields1, fields2);

 

 			// go through each property and change it slightly and make sure it causes inequality.

 			fields2.Email += "q";

 			Assert.AreNotEqual(fields1, fields2);

-			fields2 = fields1;

+			fields1.Email = fields2.Email;

+			Assert.AreEqual(fields1, fields2, "Test sanity check.");

 			fields2.BirthDate = DateTime.Now;

 			Assert.AreNotEqual(fields1, fields2);

-			fields2 = fields1;

+			fields2.BirthDate = fields1.BirthDate;

+			Assert.AreEqual(fields1, fields2, "Test sanity check.");

 			fields2.Country += "q";

 			Assert.AreNotEqual(fields1, fields2);

-			fields2 = fields1;

+			fields2.Country = fields1.Country;

+			Assert.AreEqual(fields1, fields2, "Test sanity check.");

 			fields2.FullName += "q";

 			Assert.AreNotEqual(fields1, fields2);

-			fields2 = fields1;

+			fields2.FullName = fields1.FullName;

+			Assert.AreEqual(fields1, fields2, "Test sanity check.");

 			fields2.Gender = Gender.Female;

 			Assert.AreNotEqual(fields1, fields2);

-			fields2 = fields1;

+			fields2.Gender = fields1.Gender;

+			Assert.AreEqual(fields1, fields2, "Test sanity check.");

 			fields2.Language = "gb";

 			Assert.AreNotEqual(fields1, fields2);

-			fields2 = fields1;

+			fields2.Language = fields1.Language;

+			Assert.AreEqual(fields1, fields2, "Test sanity check.");

 			fields2.Nickname += "q";

 			Assert.AreNotEqual(fields1, fields2);

-			fields2 = fields1;

+			fields2.Nickname = fields1.Nickname;

+			Assert.AreEqual(fields1, fields2, "Test sanity check.");

 			fields2.PostalCode += "q";

 			Assert.AreNotEqual(fields1, fields2);

-			fields2 = fields1;

+			fields2.PostalCode = fields1.PostalCode;

+			Assert.AreEqual(fields1, fields2, "Test sanity check.");

 			fields2.TimeZone += "q";

 			Assert.AreNotEqual(fields1, fields2);

 		}