summaryrefslogtreecommitdiffstats
path: root/src/DotNetOpenAuth.Core/Messaging/Channel.cs
diff options
context:
space:
mode:
authorAndrew Arnott <andrewarnott@gmail.com>2012-02-09 08:29:36 -0800
committerAndrew Arnott <andrewarnott@gmail.com>2012-02-09 08:29:36 -0800
commitcd00f47e375106db6b04a32dff669e5b87c5affb (patch)
treeca2d8625561f2084250c3cebf6eae3813f71c8b2 /src/DotNetOpenAuth.Core/Messaging/Channel.cs
parentb6a394fdde0b5ba09d3836ea80dd201f79e90a3a (diff)
downloadDotNetOpenAuth-cd00f47e375106db6b04a32dff669e5b87c5affb.zip
DotNetOpenAuth-cd00f47e375106db6b04a32dff669e5b87c5affb.tar.gz
DotNetOpenAuth-cd00f47e375106db6b04a32dff669e5b87c5affb.tar.bz2
Fixed FxCop messages in DNOA.Core #68
Diffstat (limited to 'src/DotNetOpenAuth.Core/Messaging/Channel.cs')
-rw-r--r--src/DotNetOpenAuth.Core/Messaging/Channel.cs5
1 files changed, 4 insertions, 1 deletions
diff --git a/src/DotNetOpenAuth.Core/Messaging/Channel.cs b/src/DotNetOpenAuth.Core/Messaging/Channel.cs
index 18071ed..201d861 100644
--- a/src/DotNetOpenAuth.Core/Messaging/Channel.cs
+++ b/src/DotNetOpenAuth.Core/Messaging/Channel.cs
@@ -817,7 +817,7 @@ namespace DotNetOpenAuth.Messaging {
if (tooLargeForGet) {
ErrorUtilities.VerifyProtocol(
(message.HttpMethods & HttpDeliveryMethods.PostRequest) == HttpDeliveryMethods.PostRequest,
- "Message too large for a HTTP GET, and HTTP POST is not allowed for this message type.");
+ MessagingStrings.MessageExceedsGetSizePostNotAllowed);
}
// If GET didn't work out, for whatever reason...
@@ -873,6 +873,7 @@ namespace DotNetOpenAuth.Messaging {
/// <param name="message">The message to forward.</param>
/// <param name="fields">The pre-serialized fields from the message.</param>
/// <returns>The encoded HTTP response.</returns>
+ [SuppressMessage("Microsoft.Reliability", "CA2000:Dispose objects before losing scope", Justification = "No apparent problem. False positive?")]
protected virtual OutgoingWebResponse CreateFormPostResponse(IDirectedProtocolMessage message, IDictionary<string, string> fields) {
Requires.NotNull(message, "message");
Requires.True(message.Recipient != null, "message", MessagingStrings.DirectedMessageMissingRecipient);
@@ -946,6 +947,7 @@ namespace DotNetOpenAuth.Messaging {
/// <param name="message">The message to serialize.</param>
/// <returns>A JSON string.</returns>
[SuppressMessage("Microsoft.Usage", "CA2202:Do not dispose objects multiple times", Justification = "This Dispose is safe.")]
+ [SuppressMessage("Microsoft.Reliability", "CA2000:Dispose objects before losing scope", Justification = "No apparent problem. False positive?")]
protected virtual string SerializeAsJson(IMessage message) {
Requires.NotNull(message, "message");
@@ -966,6 +968,7 @@ namespace DotNetOpenAuth.Messaging {
/// </summary>
/// <param name="json">A JSON string.</param>
/// <returns>The simple "key":"value" pairs from a JSON-encoded object.</returns>
+ [SuppressMessage("Microsoft.Reliability", "CA2000:Dispose objects before losing scope", Justification = "No apparent problem. False positive?")]
protected virtual IDictionary<string, string> DeserializeFromJson(string json) {
Requires.NotNullOrEmpty(json, "json");