Removed all the AllowEmpty attribute parameters in OAuth 2.0 messages because the spec says empty parameters should be dropped and therefore are irrelevant.

14 files changed, 33 insertions, 33 deletions

diff --git a/src/DotNetOpenAuth/OAuth2/Messages/AccessProtectedResourceRequest.cs b/src/DotNetOpenAuth/OAuth2/Messages/AccessProtectedResourceRequest.cs
index f49efce..410592f 100644
--- a/src/DotNetOpenAuth/OAuth2/Messages/AccessProtectedResourceRequest.cs
+++ b/src/DotNetOpenAuth/OAuth2/Messages/AccessProtectedResourceRequest.cs
@@ -51,7 +51,7 @@ namespace DotNetOpenAuth.OAuth2.Messages {
 		/// Gets or sets the access token.
 		/// </summary>
 		/// <value>The access token.</value>
-		[MessagePart("token", IsRequired = true, AllowEmpty = false)]
+		[MessagePart("token", IsRequired = true)]
 		internal string AccessToken { get; set; }
 
 		/// <summary>
diff --git a/src/DotNetOpenAuth/OAuth2/Messages/AccessTokenAssertionRequest.cs b/src/DotNetOpenAuth/OAuth2/Messages/AccessTokenAssertionRequest.cs
index b0dced4..fa50f6b 100644
--- a/src/DotNetOpenAuth/OAuth2/Messages/AccessTokenAssertionRequest.cs
+++ b/src/DotNetOpenAuth/OAuth2/Messages/AccessTokenAssertionRequest.cs
@@ -28,14 +28,14 @@ namespace DotNetOpenAuth.OAuth2.Messages {
 		/// Gets or sets the format of the assertion as defined by the Authorization Server.
 		/// </summary>
 		/// <value>The assertion format.</value>
-		[MessagePart(Protocol.assertion_type, IsRequired = true, AllowEmpty = false)]
+		[MessagePart(Protocol.assertion_type, IsRequired = true)]
 		internal Uri AssertionType { get; set; }
 
 		/// <summary>
 		/// Gets or sets the assertion.
 		/// </summary>
 		/// <value>The assertion.</value>
-		[MessagePart(Protocol.assertion, IsRequired = true, AllowEmpty = false)]
+		[MessagePart(Protocol.assertion, IsRequired = true)]
 		internal string Assertion { get; set; }
 
 		/// <summary>
diff --git a/src/DotNetOpenAuth/OAuth2/Messages/AccessTokenAuthorizationCodeRequest.cs b/src/DotNetOpenAuth/OAuth2/Messages/AccessTokenAuthorizationCodeRequest.cs
index 67afdcb..28739a0 100644
--- a/src/DotNetOpenAuth/OAuth2/Messages/AccessTokenAuthorizationCodeRequest.cs
+++ b/src/DotNetOpenAuth/OAuth2/Messages/AccessTokenAuthorizationCodeRequest.cs
@@ -72,7 +72,7 @@ namespace DotNetOpenAuth.OAuth2.Messages {
 		/// in <see cref="EndUserAuthorizationSuccessAuthCodeResponse.AuthorizationCode"/>.
 		/// </summary>
 		/// <value>The verification code received from the authorization server.</value>
-		[MessagePart(Protocol.code, IsRequired = true, AllowEmpty = false)]
+		[MessagePart(Protocol.code, IsRequired = true)]
 		internal string AuthorizationCode { get; set; }
 
 		/// <summary>
@@ -81,7 +81,7 @@ namespace DotNetOpenAuth.OAuth2.Messages {
 		/// <value>
 		/// The Callback URL used to obtain the Verification Code.
 		/// </value>
-		[MessagePart(Protocol.redirect_uri, IsRequired = true, AllowEmpty = false)]
+		[MessagePart(Protocol.redirect_uri, IsRequired = true)]
 		internal Uri Callback { get; set; }
 	}
 }
diff --git a/src/DotNetOpenAuth/OAuth2/Messages/AccessTokenFailedResponse.cs b/src/DotNetOpenAuth/OAuth2/Messages/AccessTokenFailedResponse.cs
index 8903527..82de341 100644
--- a/src/DotNetOpenAuth/OAuth2/Messages/AccessTokenFailedResponse.cs
+++ b/src/DotNetOpenAuth/OAuth2/Messages/AccessTokenFailedResponse.cs
@@ -66,21 +66,21 @@ namespace DotNetOpenAuth.OAuth2.Messages {
 		/// Gets or sets the error.
 		/// </summary>
 		/// <value>One of the values given in <see cref="Protocol.AccessTokenRequestErrorCodes"/>.</value>
-		[MessagePart(Protocol.error, IsRequired = true, AllowEmpty = false)]
+		[MessagePart(Protocol.error, IsRequired = true)]
 		internal string Error { get; set; }
 
 		/// <summary>
 		/// Gets or sets a human readable description of the error.
 		/// </summary>
 		/// <value>Human-readable text providing additional information, used to assist in the understanding and resolution of the error that occurred.</value>
-		[MessagePart(Protocol.error_description, AllowEmpty = true, IsRequired = false)]
+		[MessagePart(Protocol.error_description, IsRequired = false)]
 		internal string ErrorDescription { get; set; }
 
 		/// <summary>
 		/// Gets or sets the location of the web page that describes the error and possible resolution.
 		/// </summary>
 		/// <value>A URI identifying a human-readable web page with information about the error, used to provide the end-user with additional information about the error.</value>
-		[MessagePart(Protocol.error_uri, AllowEmpty = false, IsRequired = false)]
+		[MessagePart(Protocol.error_uri, IsRequired = false)]
 		internal Uri ErrorUri { get; set; }
 	}
 }
diff --git a/src/DotNetOpenAuth/OAuth2/Messages/AccessTokenRefreshRequest.cs b/src/DotNetOpenAuth/OAuth2/Messages/AccessTokenRefreshRequest.cs
index fe48efb..c193392 100644
--- a/src/DotNetOpenAuth/OAuth2/Messages/AccessTokenRefreshRequest.cs
+++ b/src/DotNetOpenAuth/OAuth2/Messages/AccessTokenRefreshRequest.cs
@@ -60,7 +60,7 @@ namespace DotNetOpenAuth.OAuth2.Messages {
 		/// <remarks>
 		/// REQUIRED. The refresh token associated with the access token to be refreshed. 
 		/// </remarks>
-		[MessagePart(Protocol.refresh_token, IsRequired = true, AllowEmpty = false)]
+		[MessagePart(Protocol.refresh_token, IsRequired = true)]
 		internal string RefreshToken { get; set; }
 
 		/// <summary>
diff --git a/src/DotNetOpenAuth/OAuth2/Messages/AccessTokenRequestBase.cs b/src/DotNetOpenAuth/OAuth2/Messages/AccessTokenRequestBase.cs
index 0783ba2..55387a6 100644
--- a/src/DotNetOpenAuth/OAuth2/Messages/AccessTokenRequestBase.cs
+++ b/src/DotNetOpenAuth/OAuth2/Messages/AccessTokenRequestBase.cs
@@ -32,14 +32,14 @@ namespace DotNetOpenAuth.OAuth2.Messages {
 		/// Gets the type of the grant.
 		/// </summary>
 		/// <value>The type of the grant.</value>
-		[MessagePart(Protocol.grant_type, IsRequired = true, AllowEmpty = false, Encoder = typeof(GrantTypeEncoder))]
+		[MessagePart(Protocol.grant_type, IsRequired = true, Encoder = typeof(GrantTypeEncoder))]
 		internal abstract GrantType GrantType { get; }
 
 		/// <summary>
 		/// Gets the set of scopes the Client would like the access token to provide access to.
 		/// </summary>
 		/// <value>A set of scopes.  Never null.</value>
-		[MessagePart(Protocol.scope, IsRequired = false, AllowEmpty = true, Encoder = typeof(ScopeEncoder))]
+		[MessagePart(Protocol.scope, IsRequired = false, Encoder = typeof(ScopeEncoder))]
 		internal HashSet<string> Scope { get; private set; }
 
 		/// <summary>
diff --git a/src/DotNetOpenAuth/OAuth2/Messages/AccessTokenResourceOwnerPasswordCredentialsRequest.cs b/src/DotNetOpenAuth/OAuth2/Messages/AccessTokenResourceOwnerPasswordCredentialsRequest.cs
index b5fde03..ed22843 100644
--- a/src/DotNetOpenAuth/OAuth2/Messages/AccessTokenResourceOwnerPasswordCredentialsRequest.cs
+++ b/src/DotNetOpenAuth/OAuth2/Messages/AccessTokenResourceOwnerPasswordCredentialsRequest.cs
@@ -37,14 +37,14 @@ namespace DotNetOpenAuth.OAuth2.Messages {
 		/// Gets or sets the user's account username.
 		/// </summary>
 		/// <value>The username on the user's account.</value>
-		[MessagePart(Protocol.username, IsRequired = true, AllowEmpty = false)]
+		[MessagePart(Protocol.username, IsRequired = true)]
 		internal string UserName { get; set; }
 
 		/// <summary>
 		/// Gets or sets the user's password.
 		/// </summary>
 		/// <value>The password.</value>
-		[MessagePart(Protocol.password, IsRequired = true, AllowEmpty = true)]
+		[MessagePart(Protocol.password, IsRequired = true)]
 		internal string Password { get; set; }
 	}
 }
diff --git a/src/DotNetOpenAuth/OAuth2/Messages/AccessTokenSuccessResponse.cs b/src/DotNetOpenAuth/OAuth2/Messages/AccessTokenSuccessResponse.cs
index 3ee2fb2..bae2dd9 100644
--- a/src/DotNetOpenAuth/OAuth2/Messages/AccessTokenSuccessResponse.cs
+++ b/src/DotNetOpenAuth/OAuth2/Messages/AccessTokenSuccessResponse.cs
@@ -53,7 +53,7 @@ namespace DotNetOpenAuth.OAuth2.Messages {
 		/// Gets or sets the access token.
 		/// </summary>
 		/// <value>The access token.</value>
-		[MessagePart(Protocol.access_token, IsRequired = true, AllowEmpty = false)]
+		[MessagePart(Protocol.access_token, IsRequired = true)]
 		public string AccessToken { get; internal set; }
 
 		/// <summary>
@@ -70,14 +70,14 @@ namespace DotNetOpenAuth.OAuth2.Messages {
 		/// <remarks>
 		/// OPTIONAL. The refresh token used to obtain new access tokens using the same end-user access grant as described in Section 6  (Refreshing an Access Token). 
 		/// </remarks>
-		[MessagePart(Protocol.refresh_token, IsRequired = false, AllowEmpty = false)]
+		[MessagePart(Protocol.refresh_token, IsRequired = false)]
 		public string RefreshToken { get; internal set; }
 
 		/// <summary>
 		/// Gets the scope of access being requested.
 		/// </summary>
 		/// <value>The scope of the access request expressed as a list of space-delimited strings. The value of the scope parameter is defined by the authorization server. If the value contains multiple space-delimited strings, their order does not matter, and each string adds an additional access range to the requested scope.</value>
-		[MessagePart(Protocol.scope, IsRequired = false, AllowEmpty = true, Encoder = typeof(ScopeEncoder))]
+		[MessagePart(Protocol.scope, IsRequired = false, Encoder = typeof(ScopeEncoder))]
 		public HashSet<string> Scope { get; private set; }
 	}
 }
diff --git a/src/DotNetOpenAuth/OAuth2/Messages/AuthenticatedClientRequestBase.cs b/src/DotNetOpenAuth/OAuth2/Messages/AuthenticatedClientRequestBase.cs
index 66809f8..22f7461 100644
--- a/src/DotNetOpenAuth/OAuth2/Messages/AuthenticatedClientRequestBase.cs
+++ b/src/DotNetOpenAuth/OAuth2/Messages/AuthenticatedClientRequestBase.cs
@@ -26,7 +26,7 @@ namespace DotNetOpenAuth.OAuth2.Messages {
 		/// Gets the client identifier previously obtained from the Authorization Server.
 		/// </summary>
 		/// <value>The client identifier.</value>
-		[MessagePart(Protocol.client_id, IsRequired = true, AllowEmpty = false)]
+		[MessagePart(Protocol.client_id, IsRequired = true)]
 		public string ClientIdentifier { get; internal set; }
 
 		/// <summary>
@@ -36,7 +36,7 @@ namespace DotNetOpenAuth.OAuth2.Messages {
 		/// <remarks>
 		/// REQUIRED. The client secret as described in Section 2.1  (Client Credentials). OPTIONAL if no client secret was issued. 
 		/// </remarks>
-		[MessagePart(Protocol.client_secret, IsRequired = false, AllowEmpty = true)]
+		[MessagePart(Protocol.client_secret, IsRequired = false)]
 		public string ClientSecret { get; internal set; }
 	}
 }
\ No newline at end of file
diff --git a/src/DotNetOpenAuth/OAuth2/Messages/EndUserAuthorizationFailedResponse.cs b/src/DotNetOpenAuth/OAuth2/Messages/EndUserAuthorizationFailedResponse.cs
index 406a15b..8708ca2 100644
--- a/src/DotNetOpenAuth/OAuth2/Messages/EndUserAuthorizationFailedResponse.cs
+++ b/src/DotNetOpenAuth/OAuth2/Messages/EndUserAuthorizationFailedResponse.cs
@@ -43,21 +43,21 @@ namespace DotNetOpenAuth.OAuth2.Messages {
 		/// Gets or sets the error.
 		/// </summary>
 		/// <value>One of the values given in <see cref="Protocol.EndUserAuthorizationRequestErrorCodes"/>.</value>
-		[MessagePart(Protocol.error, IsRequired = true, AllowEmpty = false)]
+		[MessagePart(Protocol.error, IsRequired = true)]
 		public string Error { get; set; }
 
 		/// <summary>
 		/// Gets or sets a human readable description of the error.
 		/// </summary>
 		/// <value>Human-readable text providing additional information, used to assist in the understanding and resolution of the error that occurred.</value>
-		[MessagePart(Protocol.error_description, IsRequired = false, AllowEmpty = true)]
+		[MessagePart(Protocol.error_description, IsRequired = false)]
 		public string ErrorDescription { get; set; }
 
 		/// <summary>
 		/// Gets or sets the location of the web page that describes the error and possible resolution.
 		/// </summary>
 		/// <value>A URI identifying a human-readable web page with information about the error, used to provide the end-user with additional information about the error.</value>
-		[MessagePart(Protocol.error_uri, IsRequired = false, AllowEmpty = false)]
+		[MessagePart(Protocol.error_uri, IsRequired = false)]
 		public Uri ErrorUri { get; set; }
 
 		/// <summary>
@@ -67,7 +67,7 @@ namespace DotNetOpenAuth.OAuth2.Messages {
 		/// <remarks>
 		/// REQUIRED if the Client sent the value in the <see cref="EndUserAuthorizationRequest"/>.
 		/// </remarks>
-		[MessagePart(Protocol.state, IsRequired = false, AllowEmpty = true)]
+		[MessagePart(Protocol.state, IsRequired = false)]
 		string IMessageWithClientState.ClientState { get; set; }
 	}
 }
diff --git a/src/DotNetOpenAuth/OAuth2/Messages/EndUserAuthorizationRequest.cs b/src/DotNetOpenAuth/OAuth2/Messages/EndUserAuthorizationRequest.cs
index 4810dc3..6fb1d5c 100644
--- a/src/DotNetOpenAuth/OAuth2/Messages/EndUserAuthorizationRequest.cs
+++ b/src/DotNetOpenAuth/OAuth2/Messages/EndUserAuthorizationRequest.cs
@@ -43,10 +43,10 @@ namespace DotNetOpenAuth.OAuth2.Messages {
 		}
 
 		/// <summary>
-		/// Gets the type of the authorization that the client expects of the authorization server.
+		/// Gets the grant type that the client expects of the authorization server.
 		/// </summary>
 		/// <value>Always <see cref="EndUserAuthorizationResponseType.AuthorizationCode"/>.  Other response types are not supported.</value>
-		[MessagePart(Protocol.response_type, IsRequired = true, AllowEmpty = false, Encoder = typeof(EndUserAuthorizationResponseTypeEncoder))]
+		[MessagePart(Protocol.response_type, IsRequired = true, Encoder = typeof(EndUserAuthorizationResponseTypeEncoder))]
 		public EndUserAuthorizationResponseType ResponseType
 		{
 			get { return EndUserAuthorizationResponseType.AuthorizationCode; }
@@ -55,7 +55,7 @@ namespace DotNetOpenAuth.OAuth2.Messages {
 		/// <summary>
 		/// Gets or sets the identifier by which this client is known to the Authorization Server.
 		/// </summary>
-		[MessagePart(Protocol.client_id, IsRequired = true, AllowEmpty = false)]
+		[MessagePart(Protocol.client_id, IsRequired = true)]
 		public string ClientIdentifier { get; set; }
 
 		/// <summary>
@@ -68,7 +68,7 @@ namespace DotNetOpenAuth.OAuth2.Messages {
 		/// <remarks>
 		/// REQUIRED unless a redirection URI has been established between the client and authorization server via other means. An absolute URI to which the authorization server will redirect the user-agent to when the end-user authorization step is completed. The authorization server MAY require the client to pre-register their redirection URI. The redirection URI MUST NOT include a query component as defined by [RFC3986]  (Berners-Lee, T., Fielding, R., and L. Masinter, “Uniform Resource Identifier (URI): Generic Syntax,” January 2005.) section 3 if the state parameter is present. 
 		/// </remarks>
-		[MessagePart(Protocol.redirect_uri, IsRequired = false, AllowEmpty = false)]
+		[MessagePart(Protocol.redirect_uri, IsRequired = false)]
 		public Uri Callback { get; set; }
 
 		/// <summary>
@@ -80,14 +80,14 @@ namespace DotNetOpenAuth.OAuth2.Messages {
 		/// <remarks>
 		/// REQUIRED. The client identifier as described in Section 3.4  (Client Credentials). 
 		/// </remarks>
-		[MessagePart(Protocol.state, IsRequired = false, AllowEmpty = true)]
+		[MessagePart(Protocol.state, IsRequired = false)]
 		public string ClientState { get; set; }
 
 		/// <summary>
 		/// Gets the scope of access being requested.
 		/// </summary>
 		/// <value>The scope of the access request expressed as a list of space-delimited strings. The value of the scope parameter is defined by the authorization server. If the value contains multiple space-delimited strings, their order does not matter, and each string adds an additional access range to the requested scope.</value>
-		[MessagePart(Protocol.scope, IsRequired = false, AllowEmpty = true, Encoder = typeof(ScopeEncoder))]
+		[MessagePart(Protocol.scope, IsRequired = false, Encoder = typeof(ScopeEncoder))]
 		public HashSet<string> Scope { get; private set; }
 	}
 }
diff --git a/src/DotNetOpenAuth/OAuth2/Messages/EndUserAuthorizationSuccessAccessTokenResponse.cs b/src/DotNetOpenAuth/OAuth2/Messages/EndUserAuthorizationSuccessAccessTokenResponse.cs
index f33c8f3..025cf84 100644
--- a/src/DotNetOpenAuth/OAuth2/Messages/EndUserAuthorizationSuccessAccessTokenResponse.cs
+++ b/src/DotNetOpenAuth/OAuth2/Messages/EndUserAuthorizationSuccessAccessTokenResponse.cs
@@ -74,7 +74,7 @@ namespace DotNetOpenAuth.OAuth2.Messages {
 		/// Gets or sets the access token.
 		/// </summary>
 		/// <value>The access token.</value>
-		[MessagePart(Protocol.access_token, AllowEmpty = false, IsRequired = true)]
+		[MessagePart(Protocol.access_token, IsRequired = true)]
 		internal string AccessToken { get; set; }
 	}
 }
diff --git a/src/DotNetOpenAuth/OAuth2/Messages/EndUserAuthorizationSuccessAuthCodeResponse.cs b/src/DotNetOpenAuth/OAuth2/Messages/EndUserAuthorizationSuccessAuthCodeResponse.cs
index 085a530..d3748a9 100644
--- a/src/DotNetOpenAuth/OAuth2/Messages/EndUserAuthorizationSuccessAuthCodeResponse.cs
+++ b/src/DotNetOpenAuth/OAuth2/Messages/EndUserAuthorizationSuccessAuthCodeResponse.cs
@@ -70,14 +70,14 @@ namespace DotNetOpenAuth.OAuth2.Messages {
 		/// Gets or sets the authorization code.
 		/// </summary>
 		/// <value>The authorization code.</value>
-		[MessagePart(Protocol.code, AllowEmpty = false, IsRequired = true)]
+		[MessagePart(Protocol.code, IsRequired = true)]
 		internal string AuthorizationCode { get; set; }
 
 		/// <summary>
 		/// Gets or sets the access token.
 		/// </summary>
 		/// <value>The access token.</value>
-		[MessagePart(Protocol.access_token, AllowEmpty = false, IsRequired = false)]
+		[MessagePart(Protocol.access_token, IsRequired = false)]
 		internal string AccessToken { get; set; }
 	}
 }
diff --git a/src/DotNetOpenAuth/OAuth2/Messages/EndUserAuthorizationSuccessResponseBase.cs b/src/DotNetOpenAuth/OAuth2/Messages/EndUserAuthorizationSuccessResponseBase.cs
index 4a6aaf1..f89dc9b 100644
--- a/src/DotNetOpenAuth/OAuth2/Messages/EndUserAuthorizationSuccessResponseBase.cs
+++ b/src/DotNetOpenAuth/OAuth2/Messages/EndUserAuthorizationSuccessResponseBase.cs
@@ -51,14 +51,14 @@ namespace DotNetOpenAuth.OAuth2.Messages {
 		/// <remarks>
 		/// REQUIRED if the Client sent the value in the <see cref="EndUserAuthorizationRequest"/>.
 		/// </remarks>
-		[MessagePart(Protocol.state, IsRequired = false, AllowEmpty = true)]
+		[MessagePart(Protocol.state, IsRequired = false)]
 		string IMessageWithClientState.ClientState { get; set; }
 
 		/// <summary>
 		/// Gets the scope of the <see cref="AccessToken"/> if one is given; otherwise the scope of the authorization code.
 		/// </summary>
 		/// <value>The scope.</value>
-		[MessagePart(Protocol.scope, IsRequired = false, AllowEmpty = true, Encoder = typeof(ScopeEncoder))]
+		[MessagePart(Protocol.scope, IsRequired = false, Encoder = typeof(ScopeEncoder))]
 		public ICollection<string> Scope { get; private set; }
 
 		/// <summary>