1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
|
# encoding: utf-8
#--
# Copyright (C) 2009 Nokia Corporation and/or its subsidiary(-ies)
#
# This program is free software: you can redistribute it and/or modify
# it under the terms of the GNU Affero General Public License as published by
# the Free Software Foundation, either version 3 of the License, or
# (at your option) any later version.
#
# This program is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
# GNU Affero General Public License for more details.
#
# You should have received a copy of the GNU Affero General Public License
# along with this program. If not, see <http://www.gnu.org/licenses/>.
#++
require File.dirname(__FILE__) + '/../../test_helper'
require "gitorious/ssh/client"
require "gitorious/ssh/strainer"
class SSHStrainerTest < ActiveSupport::TestCase
should "raises if command includes a newline" do
assert_raises(Gitorious::SSH::BadCommandError) do
Gitorious::SSH::Strainer.new("foo\nbar").parse!
end
end
should "raises if command has more than one argument" do
assert_raises(Gitorious::SSH::BadCommandError) do
Gitorious::SSH::Strainer.new("git-upload-pack 'bar baz'").parse!
end
end
should "raises if command doesn't have an argument" do
assert_raises(Gitorious::SSH::BadCommandError) do
Gitorious::SSH::Strainer.new("git-upload-pack").parse!
end
end
should "raises if it gets a bad command" do
assert_raises(Gitorious::SSH::BadCommandError) do
Gitorious::SSH::Strainer.new("evil 'foo'").parse!
end
end
should "raises if it receives an unsafe argument" do
assert_raises(Gitorious::SSH::BadCommandError) do
Gitorious::SSH::Strainer.new("git-upload-pack /evil/attack").parse!
end
end
should "only allow the specified readonly command" do
assert_raises(Gitorious::SSH::BadCommandError) do
Gitorious::SSH::Strainer.new("git-pull foo bar").parse!
end
assert_raises(Gitorious::SSH::BadCommandError) do
Gitorious::SSH::Strainer.new("rm -rf /tmp/*").parse!
end
end
should "accept non-dashed version git upload-pack" do
assert_nothing_raised do
s = Gitorious::SSH::Strainer.new("git upload-pack 'foo/bar.git'").parse!
assert_equal "git upload-pack", s.verb
end
assert_nothing_raised do
s = Gitorious::SSH::Strainer.new("git upload-pack '~foo/bar.git'").parse!
assert_equal "git upload-pack", s.verb
end
assert_nothing_raised do
s = Gitorious::SSH::Strainer.new("git upload-pack '+foo/bar.git'").parse!
assert_equal "git upload-pack", s.verb
end
end
should "accept non-dashed version git receive-pack" do
assert_nothing_raised do
s = Gitorious::SSH::Strainer.new("git receive-pack 'foo/bar.git'").parse!
assert_equal "git receive-pack", s.verb
end
assert_nothing_raised do
s = Gitorious::SSH::Strainer.new("git receive-pack '~foo/bar.git'").parse!
assert_equal "git receive-pack", s.verb
end
assert_nothing_raised do
s = Gitorious::SSH::Strainer.new("git receive-pack '+foo/bar.git'").parse!
assert_equal "git receive-pack", s.verb
end
end
should "accept git+ssh style urls" do
s = Gitorious::SSH::Strainer.new("git-receive-pack '/foo/bar.git'").parse!
assert_equal "foo/bar.git", s.path
s = Gitorious::SSH::Strainer.new("git-receive-pack '/+foo/bar.git'").parse!
assert_equal "+foo/bar.git", s.path
s = Gitorious::SSH::Strainer.new("git-receive-pack '/~foo/bar.git'").parse!
assert_equal "~foo/bar.git", s.path
end
should "raise if it receives too many arguments" do
assert_raises(Gitorious::SSH::BadCommandError) do
Gitorious::SSH::Strainer.new("git-receive-pack 'foo/bar.git' baz").parse!
end
end
should "raises if it receives an unsafe argument that almost looks kosher" do
assert_raises(Gitorious::SSH::BadCommandError) do
Gitorious::SSH::Strainer.new("git-upload-pack '/evil/path'").parse!
end
assert_raises(Gitorious::SSH::BadCommandError) do
Gitorious::SSH::Strainer.new("git-upload-pack '+/evil/path'").parse!
end
assert_raises(Gitorious::SSH::BadCommandError) do
Gitorious::SSH::Strainer.new("git-upload-pack '~/evil/path'").parse!
end
assert_raises(Gitorious::SSH::BadCommandError) do
Gitorious::SSH::Strainer.new("git-upload-pack /evil/\\\\\\//path").parse!
end
assert_raises(Gitorious::SSH::BadCommandError) do
Gitorious::SSH::Strainer.new("git-upload-pack +/evil/\\\\\\//path").parse!
end
assert_raises(Gitorious::SSH::BadCommandError) do
Gitorious::SSH::Strainer.new("git-upload-pack ~/evil/\\\\\\//path").parse!
end
assert_raises(Gitorious::SSH::BadCommandError) do
Gitorious::SSH::Strainer.new("git-upload-pack ../../evil/path").parse!
end
assert_raises(Gitorious::SSH::BadCommandError) do
Gitorious::SSH::Strainer.new("git-upload-pack 'evil/path.git.bar'").parse!
end
assert_raises(Gitorious::SSH::BadCommandError) do
Gitorious::SSH::Strainer.new("git-upload-pack +../../evil/path").parse!
end
assert_raises(Gitorious::SSH::BadCommandError) do
Gitorious::SSH::Strainer.new("git-upload-pack ~../../evil/path").parse!
end
end
should "raises if it receives an empty path" do
assert_raises(Gitorious::SSH::BadCommandError) do
Gitorious::SSH::Strainer.new("git-upload-pack ''").parse!
end
assert_raises(Gitorious::SSH::BadCommandError) do
Gitorious::SSH::Strainer.new("git-upload-pack ").parse!
end
end
should "returns self when running #parse" do
strainer = Gitorious::SSH::Strainer.new("git-upload-pack 'foo/bar.git'")
strainer2 = strainer.parse!
assert_instance_of Gitorious::SSH::Strainer, strainer2
assert_equal strainer, strainer2
end
should "sets the path of the parsed command" do
cmd = Gitorious::SSH::Strainer.new("git-upload-pack 'foo/bar.git'").parse!
assert_equal "foo/bar.git", cmd.path
end
should "can parse user-style urls prefixed with a tilde" do
assert_nothing_raised(Gitorious::SSH::BadCommandError) do
cmd = Gitorious::SSH::Strainer.new("git-upload-pack '~foo/bar.git'").parse!
assert_equal "~foo/bar.git", cmd.path
end
end
should "allow user names with an uppercase first letter" do
assert_nothing_raised do
strainer = Gitorious::SSH::Strainer.new("git-upload-pack '~Oldtimer/repo.git'").parse!
assert_equal "~Oldtimer/repo.git", strainer.path
end
end
should "allow group names with an uppercase first letter" do
assert_nothing_raised do
strainer = Gitorious::SSH::Strainer.new("git upload-pack '+Oldtimers/repo.git'").parse!
assert_equal "+Oldtimers/repo.git", strainer.path
end
end
should "can parse team-style urls prefixed with a plus" do
assert_nothing_raised(Gitorious::SSH::BadCommandError) do
cmd = Gitorious::SSH::Strainer.new("git-upload-pack '+foo/bar.git'").parse!
assert_equal "+foo/bar.git", cmd.path
end
end
should "can parse user-style urls with project name and prefixed with a tilde" do
assert_nothing_raised(Gitorious::SSH::BadCommandError) do
cmd = Gitorious::SSH::Strainer.new("git-upload-pack '~foo/bar/baz.git'").parse!
assert_equal "~foo/bar/baz.git", cmd.path
end
end
should "can parse team-style urls with project name and prefixed with a plus" do
assert_nothing_raised(Gitorious::SSH::BadCommandError) do
cmd = Gitorious::SSH::Strainer.new("git-upload-pack '+foo/bar/baz.git'").parse!
assert_equal "+foo/bar/baz.git", cmd.path
end
end
end
|
