1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
|
# encoding: utf-8
#--
# Copyright (C) 2009 Nokia Corporation and/or its subsidiary(-ies)
# Copyright (C) 2007 Johan Sørensen <johan@johansorensen.com>
#
# This program is free software: you can redistribute it and/or modify
# it under the terms of the GNU Affero General Public License as published by
# the Free Software Foundation, either version 3 of the License, or
# (at your option) any later version.
#
# This program is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
# GNU Affero General Public License for more details.
#
# You should have received a copy of the GNU Affero General Public License
# along with this program. If not, see <http://www.gnu.org/licenses/>.
#++
require File.dirname(__FILE__) + '/../test_helper'
class UsersControllerTest < ActionController::TestCase
def turn_ssl_on
@request.env["HTTPS"] = "on"
end
without_ssl_context do
context "GET :new" do
setup { get :new }
should_redirect_to_ssl
end
context "POST :create" do
setup { post :create }
should_redirect_to_ssl
end
context "GET :edit" do
setup { get :edit }
should_redirect_to_ssl
end
context "PUT :update" do
setup { put :update }
should_redirect_to_ssl
end
context "GET :password" do
setup { get :password }
should_redirect_to_ssl
end
context "POST :forgot_password_create" do
setup { post :forgot_password_create }
should_redirect_to_ssl
end
context "PUT :update_password" do
setup { put :update_password }
should_redirect_to_ssl
end
context "GET :forgot_password" do
setup { get :forgot_password }
should_redirect_to_ssl
end
context "GET :reset_password" do
setup { get :reset_password }
should_redirect_to_ssl
end
end
should_render_in_global_context
should "show pending activation" do
get :pending_activation
assert_response :success
end
should "redirect from pending activation if logged in" do
login_as :johan
get :pending_activation
assert_response :redirect
end
should " activate user" do
assert_nil User.authenticate('moe', 'test')
get :activate, :activation_code => users(:moe).activation_code
assert_redirected_to('/')
assert_not_nil flash[:notice]
assert_equal users(:moe), User.authenticate('moe@example.com', 'test')
end
should "flashes a message when the activation code is invalid" do
get :activate, :activation_code => "fubar"
assert_redirected_to('/')
assert_nil flash[:notice]
assert_equal "Invalid activation code", flash[:error]
assert_nil User.authenticate('moe@example.com', 'test')
end
context "Routing" do
setup do
@user = users(:johan)
end
should "recognizes routes starting with tilde as users/show/<name>" do
assert_generates("/~#{@user.to_param}", {
:controller => "users",
:action => "show",
:id => @user.to_param})
assert_recognizes({
:controller => "users", :action => "show", :id => @user.to_param
}, {:path => "/~#{@user.to_param}", :method => :get})
end
should "doesn't recognize controller collection actions as repositories" do
assert_recognizes({
:controller => "users", :action => "forgot_password"
}, {:path => "/users/forgot_password", :method => :get})
end
should "doesn't recognize controller member actions as repositories" do
assert_recognizes({
:controller => "users", :action => "activate", :activation_code => "123"
}, {:path => "/users/activate/123", :method => :get})
end
end
def create_user(options = {})
post :create, :user => { :login => 'quire', :email => 'quire@example.com',
:password => 'quire', :password_confirmation => 'quire',
:terms_of_use => '1' }.merge(options)
end
with_ssl_context do
should "allow signups" do
assert_difference("User.count") do
create_user
assert_redirected_to :action => "pending_activation"
end
end
should "require login on signup" do
assert_no_difference("User.count") do
create_user(:login => nil)
assert_not_nil assigns(:user).errors.on(:login)
assert_template("users/new")
end
end
should "require password on signup" do
assert_no_difference("User.count") do
create_user(:password => nil)
assert !assigns(:user).errors.on(:password).empty?
assert_template(("users/new"))
end
end
should "require password confirmation on signup" do
assert_no_difference("User.count") do
create_user(:password_confirmation => nil)
assert !assigns(:user).errors.on(:password_confirmation).empty?, 'empty? should be false'
assert_template(("users/new"))
end
end
should "require email on signup" do
assert_no_difference("User.count") do
create_user(:email => nil)
assert !assigns(:user).errors.on(:email).empty?, 'empty? should be false'
assert_template(("users/new"))
end
end
should 'require acceptance of end user license agreement' do
assert_no_difference("User.count") do
create_user(:terms_of_use => nil)
end
end
should "be successful with valid data" do
assert_difference("User.count") do
create_user
end
end
should "requires the user to activate himself after posting valid data" do
create_user
assert_equal nil, User.authenticate('quire@example.com', 'quire')
assert !@controller.send(:logged_in?), 'controller.send(:logged_in?) should be false'
end
end
should "shows the user" do
get :show, :id => users(:johan).login
assert_response :success
assert_equal users(:johan), assigns(:user)
end
should "not display the users email if he decides so" do
user = users(:johan)
user.update_attribute(:public_email, false)
get :show, :id => user.to_param
assert_response :success
assert_select "#sidebar ul li.email", 0
end
should "recognizes routing with dots in it" do
assert_recognizes({
:controller => "users",
:action => "show",
:id => "j.s"
}, "/users/j.s")
assert_recognizes({
:controller => "users",
:action => "show",
:id => "j.s"
}, "/~j.s")
end
should "recognizes sub-resource routing with dots in it" do
assert_recognizes({
:controller => "licenses",
:action => "edit",
:user_id => "j.s"
}, "/users/j.s/license/edit")
assert_recognizes({
:controller => "licenses",
:action => "edit",
:user_id => "j.s"
}, "/~j.s/license/edit")
end
should "recognizes activate routes" do
assert_recognizes({
:controller => "users",
:action => "activate",
:activation_code => "abc123",
}, "/users/activate/abc123")
end
context "GET show" do
should "#show sets atom feed autodiscovery" do
user = users(:johan)
get :show, :id => user.login
assert_equal feed_user_path(user, :format => :atom), assigns(:atom_auto_discovery_url)
end
should "not display inactive users" do
user = users(:johan)
user.update_attribute(:activation_code, "123")
assert !user.activated?
get :show, :id => user.to_param
assert_response :redirect
assert_match(/is not public/, flash[:notice])
end
end
should "has an atom feed" do
user = users(:johan)
get :feed, :id => user.login, :format => "atom"
assert_response :success
assert_equal user, assigns(:user)
assert_equal user.events.find(:all, :limit => 30, :order => "created_at desc"), assigns(:events)
end
with_ssl_context do
context "#forgot_password" do
should "GETs the page fine for everyone" do
get :forgot_password
assert_response :success
assert_template(("forgot_password"))
end
end
context "#reset" do
setup do
@user = users(:johan)
@user.update_attribute(:password_key, "s3kr1t")
turn_ssl_on
end
should "redirect if the token is invalid" do
get :reset_password, :token => "invalid"
assert_response :redirect
assert_redirected_to forgot_password_users_path
assert_not_nil flash[:error]
end
should "render the form if the token is valid" do
get :reset_password, :token => "s3kr1t"
assert_response :success
assert_equal @user, assigns(:user)
assert_nil flash[:error]
end
should "re-render if password confirmation doesn't match" do
put :reset_password, :token => "s3kr1t", :user => {
:password => "qwertyasdf",
:password_confirmation => "asdf"
}
assert_response :success
assert !assigns(:user).valid?
assert_nil User.authenticate(@user.email, "qwertyasdf")
end
should "update the password" do
put :reset_password, :token => "s3kr1t", :user => {
:password => "qwertyasdf",
:password_confirmation => "qwertyasdf"
}
assert_response :redirect
assert_redirected_to new_sessions_path
assert User.authenticate(@user.email, "qwertyasdf")
assert_match(/Password updated/i, flash[:success])
end
end
context "#forgot_password_create" do
should "redirects to forgot_password if nothing was found" do
post :forgot_password_create, :user => {:email => "xxx"}
assert_redirected_to(forgot_password_users_path)
assert_match(/invalid email/i, flash[:error])
end
should "sends a new password if email was found" do
u = users(:johan)
User.expects(:generate_reset_password_key).returns("secret")
Mailer.expects(:deliver_forgotten_password).with(u, "secret")
post :forgot_password_create, :user => {:email => u.email}
assert_redirected_to(root_path)
assert_match(/A password confirmation link has been sent/, flash[:success])
end
should 'notify non-activated users that they need to activate their accounts before resetting the password' do
user = users(:johan)
user.expects(:activated?).returns(false)
User.expects(:find_by_email).returns(user)
post :forgot_password_create, :user => {:email => user.email}
assert_redirected_to forgot_password_users_path
assert_match(/activated yet/, flash[:error])
end
end
end
context "in Private Mode" do
setup do
GitoriousConfig['public_mode'] = false
end
teardown do
GitoriousConfig['public_mode'] = true
end
should "activate user" do
assert_nil User.authenticate('moe', 'test')
get :activate, :activation_code => users(:moe).activation_code
assert_redirected_to('/')
assert !flash[:notice].nil?
assert_equal users(:moe), User.authenticate('moe@example.com', 'test')
end
should "flashes a message when the activation code is invalid" do
get :activate, :activation_code => "fubar"
assert_redirected_to('/')
assert_nil flash[:notice]
assert_equal "Invalid activation code", flash[:error]
assert_nil User.authenticate('moe@example.com', 'test')
end
should "GET /users/johan" do
get :show, :id => users(:johan).to_param
assert_redirected_to(root_path)
assert_match(/Action requires login/, flash[:error])
end
should "GET /users/new" do
turn_ssl_on
get :new
assert_redirected_to(root_path)
assert_match(/Action requires login/, flash[:error])
end
should "GET /users/forgot_password" do
turn_ssl_on
get :forgot_password
assert_response :success
end
end
context "account-related tests" do
setup do
login_as :johan
turn_ssl_on
end
should "require current_user" do
login_as :moe
get :edit, :id => users(:johan).to_param
assert_response :redirect
assert_redirected_to user_path(users(:moe))
end
should "GET /users/johan/edit is successful" do
get :edit, :id => users(:johan).to_param
assert_response :success
end
should "PUT /users/create with valid data is successful" do
put :update, :id => users(:johan).to_param, :user => {
:password => "fubar",
:password_confirmation => "fubar"
}
assert !flash[:success].nil?
assert_redirected_to(user_path(assigns(:user)))
end
should "GET require current_user" do
login_as :moe
get :password, :id => users(:johan).to_param
assert_response :redirect
assert_redirected_to user_path(users(:moe))
end
should "GET /users/johan/password is a-ok" do
get :password, :id => users(:johan).to_param
assert_response :success
assert_equal users(:johan), assigns(:user)
end
should "PUT requires current_user" do
login_as :moe
put :update_password, :id => users(:johan).to_param, :user => {
:current_password => "test",
:password => "fubar",
:password_confirmation => "fubar" }
assert_response :redirect
assert_redirected_to user_path(users(:moe))
end
should "PUT /users/joan/update_password updates password if old one matches" do
user = users(:johan)
put :update_password, :id => user.to_param, :user => {
:current_password => "test",
:password => "fubar",
:password_confirmation => "fubar" }
assert_redirected_to(user_path(user))
assert_match(/Your password has been changed/i, flash[:success])
assert_equal user, User.authenticate(user.email, "fubar")
end
should "PUT /users/johan/update_password does not update password if old one is wrong" do
put :update_password, :id => users(:johan).to_param, :user => {
:current_password => "notthecurrentpassword",
:password => "fubar",
:password_confirmation => "fubar" }
assert_nil flash[:notice]
assert_match(/doesn't seem to match/, flash[:error])
assert_template("users/password")
assert_equal users(:johan), User.authenticate(users(:johan).email, "test")
assert_nil User.authenticate(users(:johan).email, "fubar")
end
should " be able to update password, even if user is openid enabled" do
user = users(:johan)
user.update_attribute(:identity_url, "http://johan.someprovider.com/")
put :update_password, :id => user.to_param, :user => {
:current_password => "test",
:password => "fubar",
:password_confirmation => "fubar" }
assert_match(/Your password has been changed/i, flash[:success])
assert_equal users(:johan), User.authenticate(users(:johan).email, "fubar")
end
should "be able to update password, even if user created his account with openid" do
user = users(:johan)
user.update_attribute(:crypted_password, nil)
put :update_password, :id => user.to_param, :user => {
:password => "fubar",
:password_confirmation => "fubar" }
assert_redirected_to user_path(user)
assert_match(/Your password has been changed/i, flash[:success])
assert_equal users(:johan), User.authenticate(users(:johan).email, "fubar")
end
should 'be able to delete his avatar' do
user = users(:johan)
user.update_attribute(:avatar_file_name, "foo.png")
assert user.avatar?
delete :avatar, :id => user.to_param
assert_redirected_to user_path(user)
assert !user.reload.avatar?
end
end
context "Viewing ones own favorites" do
setup {
login_as(:johan)
@user = users(:johan)
@merge_request = merge_requests(:moes_to_johans)
@user.favorites.create(:watchable => @merge_request)
@project = projects(:johans)
@user.favorites.create(:watchable => @project)
}
should "render all" do
get :show, :id => @user.login
assert_response :success
end
end
context "Watchlist" do
setup { @user = users(:johan) }
should "render activities watched by the user" do
get :watchlist, :id => @user.to_param, :format => "atom"
assert_response :success
end
end
context "Message privacy" do
setup {@username = :johan}
should "not expose messages unless current user" do
login_as :moe
get :show, :id => @username.to_s
assert_nil assigns(:messages)
end
should "expose messages if current user" do
login_as @username
get :show, :id => @username.to_s
assert_not_nil assigns(:messages)
end
end
context 'Creation from OpenID' do
setup do
@valid_session_options = {:openid_url => 'http://moe.example/', :openid_nickname => 'schmoe'}
end
should 'deny access unless OpenID information is present in the session' do
get :openid_build
assert_response :redirect
end
should 'build a user from the OpenID information and render the form' do
get :openid_build, {}, @valid_session_options
user = assigns(:user)
assert_not_nil user
assert_equal 'http://moe.example/', user.identity_url
assert_response :success
end
should 'render the form unless all required fields have been filled' do
post :openid_create, {:user => {}}, @valid_session_options
user = assigns(:user)
assert_response :success
assert_template 'users/openid_build'
end
should 'create a user with the provided credentials and openid url on success' do
assert_incremented_by(ActionMailer::Base.deliveries, :size, 1) do
post :openid_create, {:user => {
:fullname => 'Moe Schmoe',
:email => 'moe@schmoe.example',
:login => 'schmoe',
:terms_of_use => '1'
}
}, @valid_session_options
end
user = assigns(:user)
assert user.activated?
assert user.terms_accepted?
assert_nil session[:openid_url]
assert_equal user, @controller.send(:current_user)
assert_response :redirect
end
end
end
|