| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
| |
Thanks to Saur on #gitorious
|
| |
|
|
|
|
| |
owner's favorites upon creation
|
|
|
|
|
|
|
|
|
|
| |
When a merge request is created, each reviewer has this added as a favorite. In the same process, a FeedItem is created
for the event associated (now created in the model and accessible as #creation_event). Messages are no longer sent to the
reviewers, as this gave a lot of email to the reviewers. Instead, they will now be able to track the creation (and updates) of merge
requests through their newsfeed.
Since notifications are no longer sent to reviewers, the checkbox on Repositories#edit is no longer displayed (it has no effect). It
is still in the database, though.
|
|
|
|
|
|
| |
a favorite created.
- Support creation of favorites without creating an event.
|
|
|
|
|
| |
- Moved linking logic into FavoritesHelper
- Favorites know of their project
|
| |
|
|
|
|
|
|
|
|
|
|
| |
A summary of what's changed:
- Routing
- Links, where necessary
- Git branch names use seq instead of id
Also made some refactorings in PushEventProcessor to make it testable without a full stack test. And set some
revealing sequence numbers in the fixtures.
|
| |
|
| |
|
| |
|
|
|
|
|
|
|
|
|
| |
them properly
Some MergeRequestController test cases had to be reworked as an effect
of this, since they stub out too much internal logic of ActiveRecord,
by stubbing out the association proxies, which is not a good thing to
do anyway.
|
|
|
|
|
|
| |
With this we don't need to Refresh header, which causes confusion
among users. Be able to supply an options hash to render_if_ready()
that swaps out the spinner image with a refresh page
|
| |
|
| |
|
| |
|
| |
|
|
|
|
|
|
|
|
|
| |
The "New version 1" event created when a new merge request is created
just leads to clutter and provide only what the MERGE_REQUEST_CREATED
event already does
Also clean up a few of the silly long lines (lets keep within 82 chars
or so shall we)
|
| |
|
| |
|
| |
|
|
|
|
| |
We have no interest in showing merge requests in a pending state
|
|
|
|
|
|
| |
existing ones
also made the tests pass with the new required summary field
|
|\
| |
| |
| |
| |
| |
| |
| |
| |
| | |
* commit 'qt/restructure-merge-request-view':
Move merge-request help box to the bottom of the page
Remove sidebar from merge-requests and move links to the bottom
Use merge-request number for breadcrumb title instead of source branch
Conflicts:
app/views/merge_requests/show.html.erb
|
| | |
|
| |
| |
| |
| | |
And use that as the default status for all new merge requests
|
| | |
|
|/ |
|
|
|
|
|
|
|
|
|
|
|
| |
open&closed custom states
- Introduce a StatusTag class for abstracting the loosely bounded MergeRequest#status_tag
- Move to the "legacy" merge_requests closer to the normal ones
- Simplify the internal MergeRequest statemachine to only have STATUS_OPEN and STATUS_CLOSED
- Introduce a MergeRequestStatus model that users add to a project with one of the states
above
- Remove the legacy merge_requests_controller actions
|
| |
|
|
|
|
| |
confirmed_by_user
|
|
|
|
| |
#from_filter
|
|
|
|
|
|
|
|
| |
after_destroy hook
Pass along all the data needed for the processor in the message body when the
after_destroy hook is called. That way users don't get confused and delete it
multiple times (since there's a small delay in the msg processing
|
|
|
|
|
|
|
|
| |
Replacing MergeRequests#destroy with a call to #soft_delete, which posts a message to the MQ.
This processor will both delete the ref in the target repository and delete the merge request itself.
The ref in the tracking repository is not deleted yet, nor are updates in the backend handled for merge requests
that are closed or reopened.
|
|
|
|
|
| |
Also added support for deleting the merge request ref in the target repository.
This will be done before the merge request is deleted.
|
|
|
|
|
| |
- This is set when MergeRequest#confirmed_by_user is called, meaning merge requests needing acceptance of
contribution agreements will be set to open as soon as the agreement is accepted
|
| |
|
| |
|
|
|
|
| |
new state.
|
|
|
|
|
|
|
|
| |
- add a list of unique status_tags
- MergeRequest.from_filter uses a named scope by filter when given a non-defined string
MergeRequest.from_filter now uses either a predefined name scope, the by_status named scope
or open (when given nil)
|
| |
|
|
|
|
| |
removed debug logger statement
|
|
|
|
|
|
|
| |
- added a migration method for getting existing merge request up to the current version
- use the status_tag instead of status_string in the views
- commenting on a merge request and assigning a new status should
notify the owner of the new status as well
|
|
|
|
| |
- when changing the state from a comment, create an event
- display status field in merge request form
|
| |
|
|
|
|
| |
title
|
| |
|
|
|
|
|
|
| |
- Cache the merge status of each commit for merge requests
- Load commit status with AJAX for each commit in merge request
(- add some graphics)
|
| |
|
|
|
|
| |
ending_commit as limit
|
|
|
|
|
|
|
|
|
| |
- Another show page is displayed
- When a merge request is created, the page will reload
after 5 seconds until a version is created in the background.
- The commits_to_be_merged either returns the delta (legacy objects)
or data loaded from the tracking branch (new objects)
- Hide the selector for new versions
|
|
|
|
|
| |
- Edit will let the user choose a proposal and ending comit
- Update will update and send a notification
|
|
|
|
| |
- Use dropdown for selecting versions instead of list
|
|
|
|
|
| |
- show if a commit is merged in target_repo
- rendering of merge request update events
|
|
|
|
|
|
| |
and target repo
- Also do not require subdomains for Repositories#real_path
|
|
|
|
| |
doesn't exist in the source repository by issuing a warning.
|
|
|
|
|
|
| |
- Adding MergeRequests#version
- Adding MergeRequest#versions
- Moving commits into a partial
|
|
|
|
|
|
| |
- Giving MergeRequest a ready? method for determining whether
the backend branch has been created or not
- Setting refresh header&use render_if_ready
|
|
|
|
|
|
|
| |
- Add a list of status tags
- Also remove the update_status method in MergeRequest, as
this wasn't being used
- Add tests for changing the status through comments
|
|
|
|
|
|
|
|
|
|
|
| |
comments.
- Adding a comment to a merge request now potentially sets or changes the loose state
of the merge request (target)
This way, target repository owners can mark that a merge request should change state
when adding comments. This will eventually replace the more final reason from merge requests,
replacing it with comments with an added context
|
| |
|
|
|
|
|
|
|
|
|
|
| |
- script/gitorious only checks whether the repo exists, and
sets an environment var for the URL for auth checking
- hooks/pre-receive performs the access control, as before
Currently, users should be allowed to push normally, like before.
In addition to that, owners of merge requests are allowed to push
to the special ref for the merge request in the target repository
|
| |
|
|
|
|
|
|
| |
Requests are now living inside a ref/reviews branch in the tracking repository, and can be updated though normal pushes to the real repository.
No authorization yet on pushing updates to a review - merge request owners will not yet be able to push to the target repository, but users with commit access will.
|
|
|
|
| |
instead of refs/reviews/<id> - in order to keep history
|
|
|
|
| |
when creating a merge request
|
|
|
|
| |
clearer; this renames it accordingly
|
|
|
|
| |
repository, we'll only push the ending commit.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
is used for tracking the merge requests in the
target repository.
- If the tracking repository doesn't exist, it will
be created through a separate message to the repository
creation queue
- The repository creation processor will resend another
message in this case
- Given an existing tracking repository, the source
branch will be pushed to the tracking repository as
merge_requests/<id>
- These events are fired by MergeRequest#confirmed_by_user
|
| |
|
| |
|
|
|
|
| |
Not the other way around.
|
|
|
|
|
|
|
|
|
| |
are destroyed (which could lead to messages becoming
invisible), we nullify the notifiable references.
Since AR's dependent => nullify only nullifies the
id, not the type, a before_destroy filter is introduced.
|
|
|
|
|
|
|
|
|
| |
- Added #to_xml to merge requests
- Added support for merge_requests.xml
- Added support for merge_request/id.xml
- Added support for merge_requests/id.patch
This way one can fetch a patch from Gitorious
|
|
|
|
|
|
|
| |
the AuthenticationedSystem module works.
I mean christ, who thinks this kinda bullshit up? Returning a :false symbol
instead of nil, making us jump through hoops in the rest of the app.
|
|
|
|
|
|
|
| |
This is an explicit action, wrapped inside a
separate method in MergeRequest which passes along
the user who wants to re-open.
- Also added a new Action and rendering of the events
|
| |
|
|
|
|
|
|
|
|
|
| |
By default, this is the user who created the merge
request, but is updated when the merge request
enters another state.
The updated_by information is displayed along with
the rest of the information about the request.
|
|
|
|
|
|
|
|
| |
telling users that we are working on the request, but need to verify some issues.
- Adding a new transition
- Adding a method for displaying the key/values for new states in the GUI
- Still send the user an email when changing the state
|
|
|
|
| |
skip validation of ending commit for existing merge requests.
|
|
|
|
|
|
| |
- Add link in the view
- Don't create an event when destroying mr (would cause an invalid target)
- Delete comments along with merge requests
|
|
|
|
|
|
|
|
|
|
| |
users who have already accepted the contribution agreement should be reminded of their confirmation when sending new contributions.
- Instead of extracting the agreement version checksum from the response body, it is extracted from a response header (X-Contribution-Agreement-Version).
- The response code (from the oauth provider) tells us whether this is the first or subsequent time a user accepts the license: 202 (Accepted) means it has been accepted before while other codes (preferably 201 Created) means it has been accepted for the first time
- The response body is now used for providing the message to be displayed to the user
The contribution notice is put into flash[:notice] and thus displayed to the user.
|
|
|
|
|
| |
This requires the comments_controller to be able to deal with the
polymorphic targets on the comment
|
| |
|
|
|
|
| |
Also posting it when calling back after successful merge request creation.
|
|
|
|
|
|
| |
- URL-encoding the OAuth parameters sent off after creating a merge request.
- Fixing a typo in the parameters for the OAuth parameters (extra _path appended)
- Some more encoding:utf-8 statements
|
| |
|
|
|
|
|
|
|
|
| |
current version and a checkbox including the checksum for this version.
For now, if the user chooses not to accept he will still be created, but required to accept the EULA afterwards.
Also, added the passing of more parameters when handing off a merge request to an OAuth server.
|
|
|
|
|
|
|
|
|
| |
- Project has got settings for OAuth settings (ie. consumer)
- MergeRequest has got settings for access token information. Instead of storing it in the user's session we store it in the db, giving us the possibility to call back when the state changes
- The Project now builds an OAuth consumer from the settings in the db
- The MergeRequests use this consumer (which is stubbed out when testing)
- Removed the passed arguments when performing OAuth validations, as these are now stored
- Removed the now obsolete CONSUMER constant (OAuth settings can now safely be removed from gitorious.yml)
|
| |
|
| |
|
| |
|
| |
|
|
|
|
| |
machine.
|
|
|
|
| |
- Also refactoring the can_transition_to? so it can return a list of allowed transitions
|
|
|
|
| |
(MergeRequestsController#resolve). Also let MergeRequest#can_transition_to? accept String values, as this is what they're passed as from the controllers
|
|
|
|
|
|
| |
returns whether this is allowed and another method that lets you wrap a block to be executed if allowed.
Added another merge request fixture that allows the state change.
|
|
|
|
|
| |
- Link a merge request with a message
- Display link in message (web)
|
|
|
|
|
|
| |
has been pulled into the Message class.
Also added description to Message, so that it displays its type based on whether there is a notifiable or not
|
|
|
|
| |
submitted
|