diff options
author | Lea Verou <lea@verou.me> | 2016-01-13 16:03:40 +0200 |
---|---|---|
committer | Lea Verou <lea@verou.me> | 2016-01-13 16:03:40 +0200 |
commit | 50857ff2412d8f3db624140ae45d335009622064 (patch) | |
tree | 0eb0e5b2559f1f10dd11b162ceaeca0dd832dfac | |
parent | c69149e7adb01f8e646ea94708cdba6215136e33 (diff) | |
parent | 28ea949a67aacff5e85bb695d3b0cdcedcb9ba03 (diff) | |
download | awesomplete-50857ff2412d8f3db624140ae45d335009622064.zip awesomplete-50857ff2412d8f3db624140ae45d335009622064.tar.gz awesomplete-50857ff2412d8f3db624140ae45d335009622064.tar.bz2 |
Merge pull request #16813 from vlazar/fix/input-loses-focus-on-select-with-mouse
Fix #16808. Input loses focus if item selected with mouse.
-rw-r--r-- | awesomplete.js | 1 | ||||
-rw-r--r-- | package.json | 6 | ||||
-rw-r--r-- | test/events/mousedownSpec.js | 3 |
3 files changed, 6 insertions, 4 deletions
diff --git a/awesomplete.js b/awesomplete.js index 41f94ee..a0eda9c 100644 --- a/awesomplete.js +++ b/awesomplete.js @@ -96,6 +96,7 @@ var _ = function (input, o) { } if (li && evt.button === 0) { // Only select on left click + evt.preventDefault(); me.select(li, evt); } } diff --git a/package.json b/package.json index 5064d56..cafa76e 100644 --- a/package.json +++ b/package.json @@ -18,9 +18,9 @@ "gulp-closure-compiler-service": "^0.5.0", "gulp-header": "^1.7.1", "gulp-rename": "^1.2.2", - "jasmine-core": "^2.3.0", - "karma": "^0.13.15", - "karma-chrome-launcher": "^0.2.1", + "jasmine-core": "^2.4.1", + "karma": "^0.13.19", + "karma-chrome-launcher": "^0.2.2", "karma-coverage": "^0.5.3", "karma-fixture": "^0.2.5", "karma-html2js-preprocessor": "^0.1.0", diff --git a/test/events/mousedownSpec.js b/test/events/mousedownSpec.js index 8b75b84..da5427e 100644 --- a/test/events/mousedownSpec.js +++ b/test/events/mousedownSpec.js @@ -10,7 +10,6 @@ describe("mousedown event", function () { this.subject.input.focus(); this.subject.open(); $.type(this.subject.input, "ite"); - this.subject.next(); spyOn(this.subject, "select"); }); @@ -33,6 +32,7 @@ describe("mousedown event", function () { it("selects item", function () { var event = $.fire(this.target, "mousedown", { button: 0 }); expect(this.subject.select).toHaveBeenCalledWith(this.li, event); + expect(event.defaultPrevented).toBe(true); }); }); @@ -50,6 +50,7 @@ describe("mousedown event", function () { it("selects item", function () { var event = $.fire(this.target, "mousedown", { button: 0 }); expect(this.subject.select).toHaveBeenCalledWith(this.li, event); + expect(event.defaultPrevented).toBe(true); }); }); }); |