summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMichael Leibman <michael.leibman@gmail.com>2012-01-16 15:02:21 -0800
committerMichael Leibman <mleibman@google.com>2012-01-16 15:02:21 -0800
commit6634f168da6a03ce36a4a63c83f9acd1c33cbd5d (patch)
tree5bc37a93a96e706e2be3859c3c98c7002134e33f
parentadac3d8f861ee11ac290250e5d3667b23405cda7 (diff)
downloadSlickGrid-6634f168da6a03ce36a4a63c83f9acd1c33cbd5d.zip
SlickGrid-6634f168da6a03ce36a4a63c83f9acd1c33cbd5d.tar.gz
SlickGrid-6634f168da6a03ce36a4a63c83f9acd1c33cbd5d.tar.bz2
Fixed issue #200 - Calculate maxSupportedCssHeight only once and share between grid instances.
-rw-r--r--slick.grid.js10
1 files changed, 8 insertions, 2 deletions
diff --git a/slick.grid.js b/slick.grid.js
index 35a4b0a..37500e3 100644
--- a/slick.grid.js
+++ b/slick.grid.js
@@ -35,7 +35,9 @@ if (typeof Slick === "undefined") {
}
});
- var scrollbarDimensions; // shared across all grids on this page
+ // shared across all grids on the page
+ var scrollbarDimensions;
+ var maxSupportedCssHeight; // browser's breaking point
//////////////////////////////////////////////////////////////////////////////////////////////
// SlickGrid class implementation (available as Slick.Grid)
@@ -95,7 +97,6 @@ if (typeof Slick === "undefined") {
};
// scroller
- var maxSupportedCssHeight; // browser's breaking point
var th; // virtual height
var h; // real scrollable height
var ph; // page height
@@ -356,6 +357,11 @@ if (typeof Slick === "undefined") {
}
function getMaxSupportedCssHeight() {
+ // return cached value if already calculated
+ if (maxSupportedCssHeight) {
+ return maxSupportedCssHeight;
+ }
+
var increment = 1000000;
var supportedHeight = increment;
// FF reports the height back but still renders blank after ~6M px