diff options
author | ville <ville@localhost> | 2002-11-25 19:24:51 +0000 |
---|---|---|
committer | ville <ville@localhost> | 2002-11-25 19:24:51 +0000 |
commit | f7cf4d1fc04d2b938c2fbb45e569b5d1ff7c35aa (patch) | |
tree | 8e94dd5f7fb461022c03fd88e2ad00921a810ca6 | |
parent | b20d3c352697144ce6f430b64a85758a1cc5c46b (diff) | |
download | markup-validator-f7cf4d1fc04d2b938c2fbb45e569b5d1ff7c35aa.zip markup-validator-f7cf4d1fc04d2b938c2fbb45e569b5d1ff7c35aa.tar.gz markup-validator-f7cf4d1fc04d2b938c2fbb45e569b5d1ff7c35aa.tar.bz2 |
Get rid of empty-string-valued checkboxen. They're dangerous an non-intuitive.
Yes, I believe this is safe to apply so close to 0.6.0, I need to get this out
of the way of other changes for The Release, spank me if I broke something
with this (can't be...). See also:
<http://koti.welho.com/vskytta/empty-valued-checkbox.html>
-rwxr-xr-x | htdocs/detailed.html | 14 | ||||
-rwxr-xr-x | httpd/cgi-bin/check | 16 |
2 files changed, 15 insertions, 15 deletions
diff --git a/htdocs/detailed.html b/htdocs/detailed.html index bb9e397..3122bac 100755 --- a/htdocs/detailed.html +++ b/htdocs/detailed.html @@ -1,5 +1,5 @@ -<!--#set var="revision" value="\$Id: detailed.html,v 1.10 2002-11-01 19:34:50 ville Exp $" ---><!--#set var="date" value="\$Date: 2002-11-01 19:34:50 $" +<!--#set var="revision" value="\$Id: detailed.html,v 1.11 2002-11-25 19:24:51 ville Exp $" +--><!--#set var="date" value="\$Date: 2002-11-25 19:24:51 $" --><!--#set var="title" value="The W3C MarkUp Validation Service" --><!--#set var="relroot" value="./" --><!--#include virtual="header.html" --> @@ -81,15 +81,15 @@ </tr> <tr> <th rowspan="3">Options:</th> - <td><label><input name="ss" type="checkbox" value="" /> Show Source</label></td> - <td><label><input name="sp" type="checkbox" value="" /> Show Parse Tree</label></td> + <td><label><input name="ss" type="checkbox" value="1" /> Show Source</label></td> + <td><label><input name="sp" type="checkbox" value="1" /> Show Parse Tree</label></td> </tr> <tr> - <td><label><input name="outline" type="checkbox" value="" /> Show Outline</label></td> - <td><label><input name="noatt" type="checkbox" value="" /> ...exclude attributes</label></td> + <td><label><input name="outline" type="checkbox" value="1" /> Show Outline</label></td> + <td><label><input name="noatt" type="checkbox" value="1" /> ...exclude attributes</label></td> </tr> <tr> - <td><label><input name="No200" type="checkbox" value="" /> Validate error pages</label></td> + <td><label><input name="No200" type="checkbox" value="1" /> Validate error pages</label></td> </tr> <tr> <td></td> diff --git a/httpd/cgi-bin/check b/httpd/cgi-bin/check index 4b79d6c..c968863 100755 --- a/httpd/cgi-bin/check +++ b/httpd/cgi-bin/check @@ -9,7 +9,7 @@ # This source code is available under the license at: # http://www.w3.org/Consortium/Legal/copyright-software # -# $Id: check,v 1.304 2002-11-24 19:03:30 link Exp $ +# $Id: check,v 1.305 2002-11-25 19:24:51 ville Exp $ # # Disable buffering on STDOUT! @@ -95,7 +95,7 @@ BEGIN { # # Strings - $VERSION = q$Revision: 1.304 $; + $VERSION = q$Revision: 1.305 $; $VERSION =~ s/Revision: ([\d\.]+) /$1/; @@ -157,7 +157,7 @@ $File->{'Header'} = &prepSSI({ }); $File->{'Footer'} = &prepSSI({ File => $CFG->{'Footer'}, - Date => q$Date: 2002-11-24 19:03:30 $, + Date => q$Date: 2002-11-25 19:24:51 $, }); # @@ -774,24 +774,24 @@ sub print_table { add_table($Options, '', # Show source? - q(<label title="Show Page Source (accesskey: 5)"><input type="checkbox" value="" name="ss" ) . + q(<label title="Show Page Source (accesskey: 5)"><input type="checkbox" value="1" name="ss" ) . q(accesskey="5" ) . ($File->{Opt}->{'Show Source'} ? q(checked="checked" ) : '') . q(/>Show Source</label>), # Outline? - q(<label title="Show an Outline of the document (accesskey: 6)"><input type="checkbox" value="" name="outline" ) . + q(<label title="Show an Outline of the document (accesskey: 6)"><input type="checkbox" value="1" name="outline" ) . q(accesskey="6" ) . ($File->{Opt}->{'Outline'} ? q(checked="checked" ) : '') . q(/>Outline</label>) ); add_table($Options, '', # Parse tree? - q(<label title="Show Parse Tree (accesskey: 7)"><input type="checkbox" value="" name="sp" ) . + q(<label title="Show Parse Tree (accesskey: 7)"><input type="checkbox" value="1" name="sp" ) . q(accesskey="7" ) . ($File->{Opt}->{'Show Parsetree'} ? q(checked="checked" ) : '') . q(/>Parse Tree</label>), # No attributes? - q(<label title="Exclude Attributes from Parse Tree (accesskey: 8)"><input type="checkbox" value="" name="noatt" ) . + q(<label title="Exclude Attributes from Parse Tree (accesskey: 8)"><input type="checkbox" value="1" name="noatt" ) . q(accesskey="8" ) . ($File->{Opt}->{'No Attributes'} ? q(checked="checked" ) : '') . q(/>...no attributes</label>) @@ -799,7 +799,7 @@ sub print_table { add_table($Options, '', # Validate error pages? [1, $File->{Table}->{Max}, - q(<label title="Validate also pages for which the HTTP status code indicates an error"><input type="checkbox" value="" name="No200" ) . + q(<label title="Validate also pages for which the HTTP status code indicates an error"><input type="checkbox" value="1" name="No200" ) . # @@@ accesskey missing ($File->{Opt}->{'No200'} ? q(checked="checked" ) : '') . q(/>Validate error pages</label>) |