diff options
| author | kpdecker <kpdecker@gmail.com> | 2014-08-23 07:36:01 -0500 |
|---|---|---|
| committer | kpdecker <kpdecker@gmail.com> | 2014-08-23 07:36:01 -0500 |
| commit | 19ce9812965d1dcd15b93cf4e993f958d147179b (patch) | |
| tree | b90e591352256e63bc390a85d90b8a67f69ac21c /lib/handlebars/compiler/javascript-compiler.js | |
| parent | f4b8c5260c203d6ab7631fa394696f5c7a442586 (diff) | |
| download | handlebars.js-19ce9812965d1dcd15b93cf4e993f958d147179b.zip handlebars.js-19ce9812965d1dcd15b93cf4e993f958d147179b.tar.gz handlebars.js-19ce9812965d1dcd15b93cf4e993f958d147179b.tar.bz2 | |
Do not flush subexpressions
They are no longer duplicated with the new helper calling pattern and this also introduced stack corruption issues due to improper value lookups.
Fixes #767
Fixes #768
Diffstat (limited to 'lib/handlebars/compiler/javascript-compiler.js')
| -rw-r--r-- | lib/handlebars/compiler/javascript-compiler.js | 7 |
1 files changed, 0 insertions, 7 deletions
diff --git a/lib/handlebars/compiler/javascript-compiler.js b/lib/handlebars/compiler/javascript-compiler.js index a6930f0..7a4d987 100644 --- a/lib/handlebars/compiler/javascript-compiler.js +++ b/lib/handlebars/compiler/javascript-compiler.js @@ -545,13 +545,6 @@ JavaScriptCompiler.prototype = { var lookup = (isSimple ? helper.name + ' || ' : '') + nonHelper + ' || helperMissing'; this.push('((' + lookup + ').call(' + helper.callParams + '))'); - - // Always flush subexpressions. This is both to prevent the compounding size issue that - // occurs when the code has to be duplicated for inlining and also to prevent errors - // due to the incorrect options object being passed due to the shared register. - if (!isRoot) { - this.flushInline(); - } }, // [invokeKnownHelper] |