summaryrefslogtreecommitdiffstats
path: root/Core
Commit message (Collapse)AuthorAgeFilesLines
* fix some docblocksChristian Flothmann2014-08-022-0/+4
|
* added @Target annotationsv2.3.13Fabien Potencier2014-04-231-0/+1
|
* minor #10717 unified return null usages (fabpot)Fabien Potencier2014-04-184-4/+3
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This PR was merged into the 2.3 branch. Discussion ---------- unified return null usages | Q | A | ------------- | --- | License | MIT This PR unifies the way we return `null` from a function or method: * always use `return;` instead of `return null;` (the current code base uses both); * never use `return;` at the end of a function/method. Commits ------- d1d569b unified return null usages
| * unified return null usagesFabien Potencier2014-04-164-4/+3
| |
* | fixed types in phpdocsFabien Potencier2014-04-1613-23/+23
|/
* made {@inheritdoc} annotations consistent across the boardFabien Potencier2014-04-1622-31/+31
|
* made phpdoc types consistent with those defined in HackFabien Potencier2014-04-1511-15/+15
|
* made types consistent with those defined in HackFabien Potencier2014-04-133-5/+5
|
* Update BCryptPasswordEncoder.phpv2.3.11szymek2014-02-191-0/+1
|
* [Component/Security] Fixed some phpdocs in Security/CoreJoseph Bielawski2014-01-1715-41/+94
|
* minor #9920 removed unneeded use statements (fabpot)v2.3.9Fabien Potencier2014-01-012-3/+0
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This PR was merged into the 2.3 branch. Discussion ---------- removed unneeded use statements | Q | A | ------------- | --- | License | MIT Commits ------- 7f9a366 removed unneeded use statements
| * removed unneeded use statementsFabien Potencier2014-01-012-3/+0
| |
* | [Security] fixed pre/post authentication checksFabien Potencier2013-12-311-16/+16
|/
* bug #8997 [Security] Fixed problem with losing ROLE_PREVIOUS_ADMIN role. ↵Fabien Potencier2013-12-291-1/+25
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | (pawaclawczyk) This PR was squashed before being merged into the 2.3 branch (closes #8997). Discussion ---------- [Security] Fixed problem with losing ROLE_PREVIOUS_ADMIN role. <table> <tr> <td><b>Q</b></td> <td><b>A</b></td> </tr> <tr> <td>Bug fix?</td> <td>yes</td> </tr> <tr> <td>New feature</td> <td>no</td> </tr> <tr> <td>BC breaks?</td> <td>no</td> </tr> <tr> <td>Deprecations?</td> <td>no</td> </tr> <tr> <td>Tests pass?</td> <td>yes</td> </tr> <tr> <td>Fixed tickets</td> <td>#3085, #8974</td> </tr> <tr> <td>License</td> <td>MIT</td> </tr> <tr> <td>Doc PR</td> <td>n/a</td> </tr> </table> Problem occurs while user is impersonated. Authentication process generates new token and doeas not preserve role ```ROLE_PREVIOUS_ADMIN```. Ex. when parameter ```security.always_authenticate_before_granting``` is enabled. Commits ------- a7baa3b [Security] Fixed problem with losing ROLE_PREVIOUS_ADMIN role.
| * [Security] Fixed problem with losing ROLE_PREVIOUS_ADMIN role.Paweł Wacławczyk2013-12-291-1/+25
| |
* | Fix parent serialization of user objectDavid de Boer2013-12-231-1/+8
| |
* | Merge branch '2.2' into 2.3Fabien Potencier2013-10-261-1/+1
|\ \ | | | | | | | | | | | | | | | * 2.2: Fixed English usage for existing users. [Process] Fix #9343 : revert file handle usage on Windows platform
| * | Fixed English usage for existing users.Michael Genereux2013-10-241-1/+1
| | |
* | | Merge branch '2.2' into 2.3v2.3.6Fabien Potencier2013-10-105-3/+42
|\ \ \ | |/ / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * 2.2: bumped Symfony version to 2.2.10 updated VERSION for 2.2.9 update CONTRIBUTORS for 2.2.9 updated CHANGELOG for 2.2.9 [Security] limited the password length passed to encoders assets:install command should mirror .dotfiles (.htaccess) PoFileDumper - PO headers removed whitespaces Conflicts: src/Symfony/Component/HttpKernel/Kernel.php src/Symfony/Component/Security/Core/Encoder/BCryptPasswordEncoder.php
| * | [Security] limited the password length passed to encodersv2.2.9Fabien Potencier2013-10-105-2/+45
| | |
* | | Set cost type to integerv2.3.5datibbaw2013-09-271-1/+1
| | | | | | | | | | | | This seems to be a remnant of when the code dealt with crypt() directly. The password_hash() function expects the cost option to be an LVAL (it does a type conversion for strings).
* | | Merge branch '2.2' into 2.3Fabien Potencier2013-09-195-1/+9
|\ \ \ | |/ / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * 2.2: Fix some annotates [FrameworkBundle] made sure that the debug event dispatcher is used everywhere [HttpKernel] remove unneeded strtoupper updated the composer install command to reflect changes in Composer Conflicts: src/Symfony/Component/Console/Application.php src/Symfony/Component/Console/Command/Command.php src/Symfony/Component/Console/Input/InputDefinition.php src/Symfony/Component/CssSelector/Node/CombinedSelectorNode.php src/Symfony/Component/Form/Form.php src/Symfony/Component/HttpKernel/Debug/ErrorHandler.php src/Symfony/Component/HttpKernel/DependencyInjection/RegisterListenersPass.php src/Symfony/Component/HttpKernel/Tests/DependencyInjection/RegisterListenersPassTest.php src/Symfony/Component/Locale/Locale.php src/Symfony/Component/Locale/README.md src/Symfony/Component/Locale/Stub/DateFormat/FullTransformer.php
| * | Fix some annotatesbronze1man2013-09-195-1/+9
| | |
* | | Merge branch '2.2' into 2.3Fabien Potencier2013-09-131-2/+0
|\ \ \ | |/ / | | / | |/ |/| | | | | | | | | | | | | | | | | | | | | | | * 2.2: [FrameworkBundle][Security] Replaced void return type with null for consistency fixed CS NativeSessionStorage regenerate removed unneeded comment Use setTimeZone if this method exists. Fix FileResource test fixed wrong usage of unset() [HttpFoundation] Fixed the way path to directory is trimmed. [Console] Fixed argument parsing when a single dash is passed. Conflicts: src/Symfony/Component/HttpKernel/Debug/ErrorHandler.php
| * [FrameworkBundle][Security] Replaced void return type with null for consistencyJakub Zalas2013-09-131-2/+0
| |
* | Merge branch '2.2' into 2.3Fabien Potencier2013-09-101-1/+1
|\ \ | |/ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * 2.2: Fixed docblock in UserInterface::getSalt() [Process] Fix #8970 : read output once the process is finished, enable pipe tests on Windows [DoctrineBridge] Improved test coverage of EntityChoiceList [Form] Improved test coverage of ChoiceList classes [Form] Fixed expanded choice field to be marked invalid when unknown choices are submitted [Form] Fixed ChoiceList::get*By*() methods to preserve order and array keys [Form] Removed usage of the ChoiceList::getIndicesFor*() methods where they don't offer any performance benefit [HttpKernel] made code more reliable Conflicts: src/Symfony/Bridge/Doctrine/Tests/Form/ChoiceList/EntityChoiceListTest.php src/Symfony/Component/Form/Extension/Core/ChoiceList/ChoiceListInterface.php src/Symfony/Component/Form/Extension/Core/EventListener/FixRadioInputListener.php src/Symfony/Component/Form/Extension/Core/Type/ChoiceType.php src/Symfony/Component/Form/Form.php src/Symfony/Component/Form/Tests/Extension/Core/Type/ChoiceTypeTest.php src/Symfony/Component/Process/Process.php src/Symfony/Component/Process/Tests/AbstractProcessTest.php
| * Fixed docblock in UserInterface::getSalt()Jannik Zschiesche2013-09-101-1/+1
| | | | | | | | | | | | | | This method can return null, too. See the line above: > "This can return null if the password was not encoded using a salt."
* | Merge branch '2.2' into 2.3Fabien Potencier2013-08-131-1/+1
|\ \ | |/ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * 2.2: corrected English grammar (s/does not exists/does not exist) [Process] Add more precision to Process::stop timeout [Process] Avoid zombie process in case of unit tests failure [Process] Fix #8739 [Process] Add failing test for #8739 [Process] Fix CS Fixed documentation grammar for AuthenticationManagerInterface::authenticate() [Validator] fixed the wrong isAbstract() check against the class (fixed #8589) [TwigBridge] Prevent code extension to display warning Use strstr instead of strpos Conflicts: src/Symfony/Component/Finder/Shell/Command.php src/Symfony/Component/Process/Process.php
| * Fixed documentation grammar for AuthenticationManagerInterface::authenticate()Jaik Dean2013-08-131-1/+1
| |
* | [Security] fixed usage of the salt for the bcrypt encoder (refs #8210)Fabien Potencier2013-06-131-1/+11
| |
* | Merge branch '2.2' into 2.3v2.3.0Fabien Potencier2013-05-271-1/+1
|\ \ | |/ | | | | | | | | | | | | | | | | | | | | * 2.2: Fix several instances of doubled words [Finder] Fix iteration fails with non-rewindable streams [Finder] Fix unexpected duplicate sub path related AppendIterator issue Added type of return value in VoterInterface. Fixed two bugs in HttpCache Conflicts: src/Symfony/Component/Finder/Iterator/RecursiveDirectoryIterator.php
| * Merge branch '2.1' into 2.2v2.2.3v2.2.2Fabien Potencier2013-05-271-1/+1
| |\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * 2.1: Fix several instances of doubled words [Finder] Fix iteration fails with non-rewindable streams [Finder] Fix unexpected duplicate sub path related AppendIterator issue Added type of return value in VoterInterface. Fixed two bugs in HttpCache Conflicts: src/Symfony/Component/Finder/Tests/FinderTest.php
| | * Added type of return value in VoterInterface.v2.1.12v2.1.11Rich Sage2013-05-231-1/+1
| | |
* | | [Security] Disabled the BCryptPasswordEncoder tests for PHP versions lower ↵Jakub Zalas2013-05-101-1/+11
| | | | | | | | | | | | | | | | | | than 5.3.7. See https://github.com/ircmaxell/password_compat/issues/10#issuecomment-11203833.
* | | [Security] added an exception when the BCrypt encoder cannot be used (refs ↵Fabien Potencier2013-04-261-0/+4
| | | | | | | | | | | | #7853)
* | | [Security] tweaked previous commitFabien Potencier2013-04-251-3/+1
| | |
* | | Outsource all the BCrypt heavy lifting to a libraryElnur Abdurrakhimov2013-04-251-94/+7
| | |
* | | Added a DoktrineTokenProvider in Security/Bridge/Doctrine/security/RememberMeTerje Bråten2013-04-211-2/+3
| | |
* | | Fixed typosPascal Borreli2013-04-211-2/+2
| | |
* | | merged branch elnur/chain-user-provider-getter (PR #7077)Fabien Potencier2013-04-091-0/+8
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This PR was merged into the master branch. Discussion ---------- [2.3] [Security] Add a getter for providers to the ChainUserProvider class | Q | A | ------------- | --- | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes I've got a use case where I need to check if any of the chained user providers implement a particular interface. This getter would really help with that. Commits ------- 0a82d73 Add a getter for providers to the ChainUserProvider class
| * | | Add a getter for providers to the ChainUserProvider classElnur Abdurrakhimov2013-02-151-0/+8
| | | |
* | | | [CS Fix] Consistent coding-style of concatenation operator usageDariusz Górecki2013-04-021-1/+1
| | | |
* | | | [Security] removed deprecated classesFabien Potencier2013-03-232-58/+0
| |/ / |/| |
* | | Merge branch '2.1' into 2.2Fabien Potencier2013-03-191-1/+1
|\ \ \ | |/ / |/| / | |/ | | | | | | | | | | * 2.1: Add a public modifier to an interface method [HttpRequest] fixes Request::getLanguages() bug [HttpCache] added a test (cached content should be kept after purging) [DoctrineBridge] Fixed non-utf-8 recognition [Security] fixed HttpUtils class tests
| * Add a public modifier to an interface methodv2.1.9Elnur Abdurrakhimov2013-03-181-1/+1
| |
* | [Security] fixed interface implementation (closes #6974)Fabien Potencier2013-02-051-2/+2
| |
* | fixed CSFabien Potencier2013-02-051-12/+14
| |
* | Added BCrypt password encoder.Elnur Abdurrakhimov2013-02-051-0/+146
| |
* | merged branch hhamon/user_password_constraints_namespace (PR #6960)Fabien Potencier2013-02-044-31/+89
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This PR was merged into the 2.2 branch. Commits ------- 35b62ac [Security] renamed Constraint namespace to Constraints for validator classes in order to be consistent with the whole current validator API. Discussion ---------- [Security] renamed Constraint namespace to Constraints for validator classes in order to be consistent with the whole current validator API. | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | yes (for people already using the ``UserPassword`` constraint class in their code) | Deprecations? | yes | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | -
| * | [Security] renamed Constraint namespace to Constraints for validator classes ↵Hugo Hamon2013-02-044-31/+89
| | | | | | | | | | | | in order to be consistent with the whole current validator API.
* | | Merge branch '2.1' into 2.2Fabien Potencier2013-02-041-0/+19
|\ \ \ | |/ / |/| / | |/ | | | | | | * 2.1: fixed a circular call (closes #6864) Correct comment in NativeSessionStorage regarding session.save_handler [Security] Add PHPDoc to AuthenticationEvents
| * [Security] Add PHPDoc to AuthenticationEventsFran Moreno2013-01-221-0/+19
| |
* | [Security] [Tests] added unit tests for the UserPasswordValidator class and ↵Hugo Hamon2013-02-021-1/+2
| | | | | | | | made the validator service for the UserPassword constraint configurable.
* | merged branch Seldaek/psr3 (PR #6628)Fabien Potencier2013-01-101-1/+1
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This PR was merged into the master branch. Commits ------- 67d7423 Remove use of deprecated HttpKernel LoggerInterface dca4528 [HttpKernel] Extend psr/log's NullLogger class 1e5a890 [Monolog] Mark old non-PSR3 methods as deprecated 91a86f8 [HttpKernel][Monolog] Add PSR-3 support to the LoggerInterface Discussion ---------- [HttpKernel][MonologBridge] PSR-3 support This enables PSR-3 support and monolog 1.3+. The first commit is the main part. The rest deals with deprecation of short-hand methods (warn/err/crit/emerg) that are fully expanded in PSR-3 (warning/error/critical/emergency). The downside of deprecating them is that for bundles it's a bit harder to support older and newer versions. If that is too much of a hassle you can drop that for now and cherry pick the first commit. The upside is that it forces people to move towards PSR-3 compatible stuff, which means eventually we could completely drop the LoggerInterface from the framework. In any case I think the documentation should only mention the `Psr\Log\LoggerInterface` and people should start hinting against that. The change should be done in core as well I suppose. Anyway I wanted to throw this out there as it is to get feedback. --------------------------------------------------------------------------- by stof at 2013-01-09T09:15:15Z @Seldaek I also think you should change the typehint to use the PSR LoggerInterface in all classes using the logger --------------------------------------------------------------------------- by Seldaek at 2013-01-09T09:54:55Z OK updated according to all the feedback. I tested it in an app and it still seems to work so there shouldn't be any major issues. --------------------------------------------------------------------------- by Seldaek at 2013-01-09T09:59:55Z @fabpot if you merge please merge also the bundle PR, otherwise it won't be possible to update without conflict. --------------------------------------------------------------------------- by frosas at 2013-01-10T14:59:20Z I'm trying to understand why a `composer update` of a Symfony 2.1.* resulted in a fatal error. Shouldn't a stable version don't break like this? As @olaurendeau points, why Symfony depends 1.* instead of 1.2.*? Or why Monolog 1.3 breaks its public interface (EDIT: I'm not sure about it)? Or why isn't this PR being merged (into branch 2.1) at the same time Monolog 1.3 is released? Please, understand I'm not looking for who to blame, it's just I want to know if this situation is unexpected or if otherwise a `composer update` on a stable branch is not as innocent as it seems. --------------------------------------------------------------------------- by stof at 2013-01-10T15:06:51Z @frosas it cannot be merged into 2.1 as it is a BC break. The 2.1 branch has been updated to forbid Monolog 1.3 already --------------------------------------------------------------------------- by Seldaek at 2013-01-10T15:11:58Z @frosas you can blame me for releasing as 1.3.0 and not 2.0, but technically for monolog this isn't really a BC break, I just added an interface. The problem is due to the way it's used in symfony, it ended up as a fatal error. In any case the situation is now sorted out I think. --------------------------------------------------------------------------- by frosas at 2013-01-10T15:26:43Z @stof now I see this `>=1.0,<1.3-dev` change in the 2.1 branch. Now, shouldn't a new (2.1.7) version be released for all of us not in the dev minimum-stability? @Seldaek then do you see feasible to rely only in X.Y.* versions to avoid this kind of errors? --------------------------------------------------------------------------- by Seldaek at 2013-01-10T15:45:22Z @frosas relying on X.Y.* is painful because you always need to wait until someone updates the constraint to get the new version. Of course using ~1.3 like in this PR means if I fuck up and break BC people will update to it, but that's a less likely occurrence than the alternative I think, so I would rather not use X.Y.* --------------------------------------------------------------------------- by frosas at 2013-01-10T15:50:50Z @Seldaek you are right about this, but I was thinking more in changing it only for the stable versions. EDIT: I mean, how often do you need a new feature in a branch you only apply fixes to? --------------------------------------------------------------------------- by stof at 2013-01-10T15:57:32Z @frosas Monolog and Symfony have separate release cycles. Foorcing Symfony users to use an old version of Monolog until they update to a new version of Symfony whereas the newer Monolog is compatible is a bad idea. Thus, as Monolog keeps BC, it does not maintain bugfix releases for all older versions (just like Twig does too). So it would also forbid you to get the fixes done in newer Monolog versions. The incompatibility between Symfony 2.1 LoggerInterface and PSR-3 (whereas they expect exactly the same behavior and signature for methods with the same name) is unfortunate and is the reason why we get some issues here. --------------------------------------------------------------------------- by frosas at 2013-01-10T16:21:06Z @stof I appreciate you prefer to allow newer versions at the price of having to be constantly monitoring its changes to avoid breaks. Another similar but safer strategy would be to stick to X.Y.* versions and upgrade to X.Y+1.* once the new version integration is tested, but I understand this is discutible in projects as close to Symfony as Monolog. Returning to the issue, what do you say to release this 2.1.7 version? Or is it only me who is having issues here? --------------------------------------------------------------------------- by stof at 2013-01-10T16:26:20Z @frosas a minor release should not break BC when following smeantic versionning (Symfony warned about the fact it is not strictly followed for the first releases of 2.x). But as far as monolog is concerned, 1.3 is BC with 1.2. --------------------------------------------------------------------------- by Seldaek at 2013-01-10T16:49:55Z @frosas sorry I didn't get you still had the problem. I tagged a 2.1.7 of monologbundle which hopefully fixes your issue.
| * | Remove use of deprecated HttpKernel LoggerInterfaceJordi Boggiano2013-01-091-1/+1
| | |
* | | [Security] Switch to English messages as message keysAlexander2013-01-0716-17/+18
| | |
* | | [Security] Fix CS + unreachable codeAlexander2013-01-073-9/+5
| | |
* | | [Security] Fix `AuthenticationException` serializationAlexander2013-01-073-2/+48
| | |
* | | [Security] Introduced `UsernameNotFoundException#get/setUsername`Alexander2013-01-075-3/+34
| | |
* | | [Security] Removed `get/setExtraInformation`, added `get/set(Token|User)`Alexander2013-01-075-12/+48
| | |
* | | [Security] Fix exception constructors called in `UserChecker`Alexander2013-01-071-4/+12
| | |
* | | [Security] Add custom `getMessageKey` AccountStatusException childsAlexander2013-01-074-0/+32
| | |
* | | [Security] Fix AuthenticationServiceException constructor callsAlexander2013-01-071-1/+3
| | |
* | | [Security] Add `getMessageKey` and `getMessageData` to auth exceptionsAlexander2013-01-0712-2/+106
| | |
* | | [Security] Change signature of `AuthenticationException` to match `\Exception`Alexander2013-01-071-7/+1
|/ /
* | fixed CSFabien Potencier2012-12-291-1/+1
| |
* | Improve timing safe comparison functionAnthony Ferrara2012-12-291-10/+21
| | | | | | | | | | Improve the timing safe comparison function to better handle cases where input is of different length. Note that it is now important to always pass any string that the user can directly control to the second parameter of the function. Otherwise, length information may be leaked.
* | Fixed most of the docblocks/unused namespacesFlorin Patan2012-12-199-0/+18
| |
* | fixed CSFabien Potencier2012-12-111-1/+0
| |
* | merged branch raziel057/COMPONENT_Form (PR #5888)Fabien Potencier2012-11-195-15/+23
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This PR was squashed before being merged into the master branch (closes #5888). Commits ------- 2379d86 CS Fixes - Replaced "array of type" by "Type[]" in PHPDoc block Discussion ---------- CS Fixes - Replaced "array of type" by "Type[]" in PHPDoc block Bug fix: no Feature addition: no Backwards compatibility break: no Symfony2 tests pass: no (but tests doesn't pass on master too). See Travis. License of the code: MIT Documentation PR: Not Applicable Status: Finished To improve support of the eclipse PDT pluggin (for autocompletion), I propose to change the array notation in PHPDoc blocks to match the phpDocumentor notation for "array of type". Modifications are made for the following components: - BrowserKit - ClassLoader - Config - Console - CssSelector - DependencyInjection - DomCrawler - EventDispatcher (no changes) - Filesystem (no changes) - Finder - Form - HttpFoundation - HttpKernel - Locale - OptionResolver (no changes) - Process (no changes) - Routing (no changes) - Serializer (no changes) - Templating - Translation - Validator - Yaml (no changes) - Security - Stopwatch (no changes) See Proposal https://github.com/symfony/symfony/pull/5852 --------------------------------------------------------------------------- by pborreli at 2012-11-01T15:19:27Z will you make a PR for each component ? why not only one PR with one commit for each component instead ? --------------------------------------------------------------------------- by raziel057 at 2012-11-01T15:32:39Z Ok, I'm going try to do it. --------------------------------------------------------------------------- by raziel057 at 2012-11-01T16:12:56Z I would like to rename my branch from COMPONENT_Form to changes-phpdoc (as all modifications would be commited in only one branch), so I tried to execute the following command but I have an error. git remote rename COMPONENT_Form changes-phpdoc error: Could not rename config section 'remote.COMPONENT_Form' to 'remote.changes-phpdoc' Do you know how to do it? --------------------------------------------------------------------------- by pborreli at 2012-11-01T16:14:26Z don't rename it, you will have to close and make another PR which is useless here, just edit the title. --------------------------------------------------------------------------- by stof at 2012-11-01T16:16:17Z and ``git remote rename`` is about renaming a remote repo, not a branch --------------------------------------------------------------------------- by raziel057 at 2012-11-03T11:36:02Z Is it normal that all my commit are duplicated? I would like just update my master and merge with my branch. --------------------------------------------------------------------------- by fabpot at 2012-11-06T10:22:55Z @raziel057 Can you rebase on master? That should fix your problem. --------------------------------------------------------------------------- by fabpot at 2012-11-09T13:28:53Z @raziel057 Can you finish this PR? --------------------------------------------------------------------------- by Tobion at 2012-11-09T13:34:45Z I'll do it for the routing component this evening because I know it by heart. ^^ --------------------------------------------------------------------------- by raziel057 at 2012-11-09T15:06:26Z @Tobion ok Thanks! @fabpot Yes, I will try to finish it this week end. --------------------------------------------------------------------------- by raziel057 at 2012-11-11T13:04:07Z @Tobion Did you already change PHPDoc in the Routing component? --------------------------------------------------------------------------- by Tobion at 2012-11-11T15:21:18Z @raziel057 Yes I'm working on it. --------------------------------------------------------------------------- by Tobion at 2012-11-12T15:16:31Z @raziel057 Done. See #5994
| * | CS Fixes - Replaced "array of type" by "Type[]" in PHPDoc blockThomas Lallement2012-11-195-15/+23
| | |
* | | merged branch Inori/consistent-util-classes (PR #5879)Fabien Potencier2012-11-132-4/+10
|\ \ \ | |/ / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This PR was squashed before being merged into the master branch (closes #5879). Commits ------- 07bd5c6 Make non-instantiable utils classes consistent with each other Discussion ---------- Make non-instantiable utils classes consistent with each other Bug fix: no Feature addition: no Backwards compatibility break: no Symfony2 tests pass: yes License of the code: MIT As per discussion in #5875 turned out that we don't have a consistent way to define non-instantiatable classes. I don't like `final` as it removes flexibility with no visible gain. I don't like `abstract` since it's not specifically clear what is meant by that. Is this class not complete? Should it be extended?
| * | Make non-instantiable utils classes consistent with each otherRoman Marintsenko2012-11-132-4/+10
| | |
* | | fixed typoFabien Potencier2012-11-061-1/+1
| | |
* | | removed unused use statementsFabien Potencier2012-11-041-1/+0
|/ /
* | fixed CSFabien Potencier2012-10-282-2/+2
| |
* | added a SecureRandomInterfaceFabien Potencier2012-10-282-5/+33
| |
* | rename String to StringUtilsFabien Potencier2012-10-282-3/+3
| |
* | renamed Prng to SecureRandomFabien Potencier2012-10-281-1/+1
| |
* | simplified the Prng codeFabien Potencier2012-10-282-52/+28
| |
* | moved the secure random class from JMSSecurityExtraBundle to Symfony (closes ↵Fabien Potencier2012-10-284-10/+192
| | | | | | | | #3595)
* | Merge branch '2.1'Fabien Potencier2012-10-242-8/+8
|\ \ | |/ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * 2.1: added missing use statment (closes #5825) Code cleanup [WebProfilerBundle] Fixed the use of nested macros Removed unused use statements. Nsdocblocks [ConfigDumpReference] avoid notice for variable nodes fixed fallback locale UniqueValidatorTest, Change message on assertions Documented removed _form_is_choice_group function Conflicts: src/Symfony/Bundle/FrameworkBundle/Command/ConfigDumpReferenceCommand.php src/Symfony/Bundle/WebProfilerBundle/Profiler/TemplateManager.php
| * NsdocblocksDrak2012-10-202-8/+8
| |
* | Merge branch '2.1'Fabien Potencier2012-10-181-1/+1
|\ \ | |/ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * 2.1: (28 commits) Delete use of CreationExeption [Form] Fixed error message in PropertyPath to not advice to use a non-existing feature [Form] Fixed creation of multiple money fields with different currencies [Form] Fixed setting the "data" option to an object in "choice" and "entity" type Fixed Serbian plural translations. Fixed IPv6 Check in RequestMatcher Fix typo change what I think is a typo [Console] Fix error when mode is not in PATH [WebProfilerBundle] fixed macro usage (to be forward compatible with Twig 2.x) Change monolog require-dev to use the branch alias instead of dev-master [FrameworkBundle] partially reverted previous merge [2.1] Added missing error return codes in commands Made the router lazy when setting the context [WebProfilerBundle] fixed typos Fix incorrect variable in FileProfilerStorage UnitTest fix UnitTest fix added a unit test fixed #5384 ...
| * change what I think is a typoGrégoire Paris2012-10-161-1/+1
| |
* | [Security] Added Pbkdf2PasswordEncoderSebastiaan Stok2012-10-081-0/+97
|/ | | | | | | | | | | | | | | | [Security] changed default iterations of Pbkdf2PasswordEncoder to 1000 instead of 5000 [Security] Improved description of PBKDF2 encoder [SecurityBundle] added PBKDF2 PasswordEncoder updated CHANGELOG.md [Security] Use the build-in hash_pbkdf2() when available [SecurityBundle] added information about hash_algorithm for configuration [Security] always check algorithm and fixed CS
* merged 2.0Fabien Potencier2012-07-231-0/+1
|\
| * Added missing propertyGrégoire Pineau2012-07-231-0/+1
| |
| * fixed CS (mainly method signatures)v2.0.16Fabien Potencier2012-07-0917-57/+57
| |
* | Revert "merged branch stof/serializable_role (PR #4925)"Fabien Potencier2012-07-152-35/+1
| | | | | | | | | | This reverts commit b0750f6dcd1e6f8b1be2c1e6604d4cbb785c9a8e, reversing changes made to d09bfe7552148d1d36b65487dfcbd378830b55a0.
* | fixed the serialization of the SwitchUserRoleChristophe Coevoet2012-07-141-0/+18
| |
* | [Security] Implemented the Serializable interface in the Role classChristophe Coevoet2012-07-141-1/+17
| |
* | added missing dotChristian Raue2012-07-121-1/+1
| |
* | fixed CSFabien Potencier2012-07-0919-59/+57
| |
* | merged 2.0Fabien Potencier2012-06-202-2/+2
|\ \ | |/
| * merged branch Maks3w/patch-4 (PR #4616)Fabien Potencier2012-06-201-1/+1
| |\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Commits ------- fa050b7 [Security] Change return value in DocBlock Discussion ---------- [Security] Change return value in DocBlock Change the return value for avoid confusions. ```php if (!$user instanceof UserInterface) { throw new AuthenticationServiceException('retrieveUser() must return a UserInterface.'); } ``` [UserAuthenticationProvider.php#L67](https://github.com/symfony/symfony/tree/2.0/src/Symfony/Component/Security/Core/Authentication/Provider/UserAuthenticationProvider.php#L67) --------------------------------------------------------------------------- by travisbot at 2012-06-19T21:03:07Z This pull request [passes](http://travis-ci.org/symfony/symfony/builds/1659148) (merged fa050b77 into e78a7bae).
| | * [Security] Change return value in DocBlockMaks2012-06-191-1/+1
| | | | | | | | | Change the return value for avoid confusions.
| * | [Security] Allow "0" as a passwordVictor Berchet2012-06-201-1/+1
| |/
| * fixed CSFabien Potencier2012-05-181-1/+1
| |
| * fixed phpdoc @param alignmentv2.0.14Fabien Potencier2012-05-153-3/+3
| |
generated by cgit v1.1 at 2025-06-07 05:49:31 +0000