summaryrefslogtreecommitdiffstats
path: root/Core
Commit message (Collapse)AuthorAgeFilesLines
* [Security] Switch to English messages as message keysAlexander2013-01-0716-17/+18
|
* [Security] Fix CS + unreachable codeAlexander2013-01-073-9/+5
|
* [Security] Fix `AuthenticationException` serializationAlexander2013-01-073-2/+48
|
* [Security] Introduced `UsernameNotFoundException#get/setUsername`Alexander2013-01-075-3/+34
|
* [Security] Removed `get/setExtraInformation`, added `get/set(Token|User)`Alexander2013-01-075-12/+48
|
* [Security] Fix exception constructors called in `UserChecker`Alexander2013-01-071-4/+12
|
* [Security] Add custom `getMessageKey` AccountStatusException childsAlexander2013-01-074-0/+32
|
* [Security] Fix AuthenticationServiceException constructor callsAlexander2013-01-071-1/+3
|
* [Security] Add `getMessageKey` and `getMessageData` to auth exceptionsAlexander2013-01-0712-2/+106
|
* [Security] Change signature of `AuthenticationException` to match `\Exception`Alexander2013-01-071-7/+1
|
* fixed CSFabien Potencier2012-12-291-1/+1
|
* Improve timing safe comparison functionAnthony Ferrara2012-12-291-10/+21
| | | | | Improve the timing safe comparison function to better handle cases where input is of different length. Note that it is now important to always pass any string that the user can directly control to the second parameter of the function. Otherwise, length information may be leaked.
* Fixed most of the docblocks/unused namespacesFlorin Patan2012-12-199-0/+18
|
* fixed CSFabien Potencier2012-12-111-1/+0
|
* merged branch raziel057/COMPONENT_Form (PR #5888)Fabien Potencier2012-11-195-15/+23
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This PR was squashed before being merged into the master branch (closes #5888). Commits ------- 2379d86 CS Fixes - Replaced "array of type" by "Type[]" in PHPDoc block Discussion ---------- CS Fixes - Replaced "array of type" by "Type[]" in PHPDoc block Bug fix: no Feature addition: no Backwards compatibility break: no Symfony2 tests pass: no (but tests doesn't pass on master too). See Travis. License of the code: MIT Documentation PR: Not Applicable Status: Finished To improve support of the eclipse PDT pluggin (for autocompletion), I propose to change the array notation in PHPDoc blocks to match the phpDocumentor notation for "array of type". Modifications are made for the following components: - BrowserKit - ClassLoader - Config - Console - CssSelector - DependencyInjection - DomCrawler - EventDispatcher (no changes) - Filesystem (no changes) - Finder - Form - HttpFoundation - HttpKernel - Locale - OptionResolver (no changes) - Process (no changes) - Routing (no changes) - Serializer (no changes) - Templating - Translation - Validator - Yaml (no changes) - Security - Stopwatch (no changes) See Proposal https://github.com/symfony/symfony/pull/5852 --------------------------------------------------------------------------- by pborreli at 2012-11-01T15:19:27Z will you make a PR for each component ? why not only one PR with one commit for each component instead ? --------------------------------------------------------------------------- by raziel057 at 2012-11-01T15:32:39Z Ok, I'm going try to do it. --------------------------------------------------------------------------- by raziel057 at 2012-11-01T16:12:56Z I would like to rename my branch from COMPONENT_Form to changes-phpdoc (as all modifications would be commited in only one branch), so I tried to execute the following command but I have an error. git remote rename COMPONENT_Form changes-phpdoc error: Could not rename config section 'remote.COMPONENT_Form' to 'remote.changes-phpdoc' Do you know how to do it? --------------------------------------------------------------------------- by pborreli at 2012-11-01T16:14:26Z don't rename it, you will have to close and make another PR which is useless here, just edit the title. --------------------------------------------------------------------------- by stof at 2012-11-01T16:16:17Z and ``git remote rename`` is about renaming a remote repo, not a branch --------------------------------------------------------------------------- by raziel057 at 2012-11-03T11:36:02Z Is it normal that all my commit are duplicated? I would like just update my master and merge with my branch. --------------------------------------------------------------------------- by fabpot at 2012-11-06T10:22:55Z @raziel057 Can you rebase on master? That should fix your problem. --------------------------------------------------------------------------- by fabpot at 2012-11-09T13:28:53Z @raziel057 Can you finish this PR? --------------------------------------------------------------------------- by Tobion at 2012-11-09T13:34:45Z I'll do it for the routing component this evening because I know it by heart. ^^ --------------------------------------------------------------------------- by raziel057 at 2012-11-09T15:06:26Z @Tobion ok Thanks! @fabpot Yes, I will try to finish it this week end. --------------------------------------------------------------------------- by raziel057 at 2012-11-11T13:04:07Z @Tobion Did you already change PHPDoc in the Routing component? --------------------------------------------------------------------------- by Tobion at 2012-11-11T15:21:18Z @raziel057 Yes I'm working on it. --------------------------------------------------------------------------- by Tobion at 2012-11-12T15:16:31Z @raziel057 Done. See #5994
| * CS Fixes - Replaced "array of type" by "Type[]" in PHPDoc blockThomas Lallement2012-11-195-15/+23
| |
* | merged branch Inori/consistent-util-classes (PR #5879)Fabien Potencier2012-11-132-4/+10
|\ \ | |/ |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This PR was squashed before being merged into the master branch (closes #5879). Commits ------- 07bd5c6 Make non-instantiable utils classes consistent with each other Discussion ---------- Make non-instantiable utils classes consistent with each other Bug fix: no Feature addition: no Backwards compatibility break: no Symfony2 tests pass: yes License of the code: MIT As per discussion in #5875 turned out that we don't have a consistent way to define non-instantiatable classes. I don't like `final` as it removes flexibility with no visible gain. I don't like `abstract` since it's not specifically clear what is meant by that. Is this class not complete? Should it be extended?
| * Make non-instantiable utils classes consistent with each otherRoman Marintsenko2012-11-132-4/+10
| |
* | fixed typoFabien Potencier2012-11-061-1/+1
| |
* | removed unused use statementsFabien Potencier2012-11-041-1/+0
|/
* fixed CSFabien Potencier2012-10-282-2/+2
|
* added a SecureRandomInterfaceFabien Potencier2012-10-282-5/+33
|
* rename String to StringUtilsFabien Potencier2012-10-282-3/+3
|
* renamed Prng to SecureRandomFabien Potencier2012-10-281-1/+1
|
* simplified the Prng codeFabien Potencier2012-10-282-52/+28
|
* moved the secure random class from JMSSecurityExtraBundle to Symfony (closes ↵Fabien Potencier2012-10-284-10/+192
| | | | #3595)
* Merge branch '2.1'Fabien Potencier2012-10-242-8/+8
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * 2.1: added missing use statment (closes #5825) Code cleanup [WebProfilerBundle] Fixed the use of nested macros Removed unused use statements. Nsdocblocks [ConfigDumpReference] avoid notice for variable nodes fixed fallback locale UniqueValidatorTest, Change message on assertions Documented removed _form_is_choice_group function Conflicts: src/Symfony/Bundle/FrameworkBundle/Command/ConfigDumpReferenceCommand.php src/Symfony/Bundle/WebProfilerBundle/Profiler/TemplateManager.php
| * NsdocblocksDrak2012-10-202-8/+8
| |
* | Merge branch '2.1'Fabien Potencier2012-10-181-1/+1
|\ \ | |/ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * 2.1: (28 commits) Delete use of CreationExeption [Form] Fixed error message in PropertyPath to not advice to use a non-existing feature [Form] Fixed creation of multiple money fields with different currencies [Form] Fixed setting the "data" option to an object in "choice" and "entity" type Fixed Serbian plural translations. Fixed IPv6 Check in RequestMatcher Fix typo change what I think is a typo [Console] Fix error when mode is not in PATH [WebProfilerBundle] fixed macro usage (to be forward compatible with Twig 2.x) Change monolog require-dev to use the branch alias instead of dev-master [FrameworkBundle] partially reverted previous merge [2.1] Added missing error return codes in commands Made the router lazy when setting the context [WebProfilerBundle] fixed typos Fix incorrect variable in FileProfilerStorage UnitTest fix UnitTest fix added a unit test fixed #5384 ...
| * change what I think is a typoGrégoire Paris2012-10-161-1/+1
| |
* | [Security] Added Pbkdf2PasswordEncoderSebastiaan Stok2012-10-081-0/+97
|/ | | | | | | | | | | | | | | | [Security] changed default iterations of Pbkdf2PasswordEncoder to 1000 instead of 5000 [Security] Improved description of PBKDF2 encoder [SecurityBundle] added PBKDF2 PasswordEncoder updated CHANGELOG.md [Security] Use the build-in hash_pbkdf2() when available [SecurityBundle] added information about hash_algorithm for configuration [Security] always check algorithm and fixed CS
* merged 2.0Fabien Potencier2012-07-231-0/+1
|\
| * Added missing propertyGrégoire Pineau2012-07-231-0/+1
| |
| * fixed CS (mainly method signatures)v2.0.16Fabien Potencier2012-07-0917-57/+57
| |
* | Revert "merged branch stof/serializable_role (PR #4925)"Fabien Potencier2012-07-152-35/+1
| | | | | | | | | | This reverts commit b0750f6dcd1e6f8b1be2c1e6604d4cbb785c9a8e, reversing changes made to d09bfe7552148d1d36b65487dfcbd378830b55a0.
* | fixed the serialization of the SwitchUserRoleChristophe Coevoet2012-07-141-0/+18
| |
* | [Security] Implemented the Serializable interface in the Role classChristophe Coevoet2012-07-141-1/+17
| |
* | added missing dotChristian Raue2012-07-121-1/+1
| |
* | fixed CSFabien Potencier2012-07-0919-59/+57
| |
* | merged 2.0Fabien Potencier2012-06-202-2/+2
|\ \ | |/
| * merged branch Maks3w/patch-4 (PR #4616)Fabien Potencier2012-06-201-1/+1
| |\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Commits ------- fa050b7 [Security] Change return value in DocBlock Discussion ---------- [Security] Change return value in DocBlock Change the return value for avoid confusions. ```php if (!$user instanceof UserInterface) { throw new AuthenticationServiceException('retrieveUser() must return a UserInterface.'); } ``` [UserAuthenticationProvider.php#L67](https://github.com/symfony/symfony/tree/2.0/src/Symfony/Component/Security/Core/Authentication/Provider/UserAuthenticationProvider.php#L67) --------------------------------------------------------------------------- by travisbot at 2012-06-19T21:03:07Z This pull request [passes](http://travis-ci.org/symfony/symfony/builds/1659148) (merged fa050b77 into e78a7bae).
| | * [Security] Change return value in DocBlockMaks2012-06-191-1/+1
| | | | | | | | | Change the return value for avoid confusions.
| * | [Security] Allow "0" as a passwordVictor Berchet2012-06-201-1/+1
| |/
| * fixed CSFabien Potencier2012-05-181-1/+1
| |
| * fixed phpdoc @param alignmentv2.0.14Fabien Potencier2012-05-153-3/+3
| |
* | [Security] fixed exception message in EncoderFactoryDouglas Greenshields2012-06-201-1/+1
| |
* | [Security] Fix retrieval of encoder when configured for concrete classesAlexander2012-06-181-1/+1
| |
* | [Security] allowed class names to be passed as an argument to ↵Fabien Potencier2012-06-182-6/+8
| | | | | | | | EncoderFactoryInterface::getEncoder()
* | moved the UserPassword validator from the security bundle to the security ↵Fabien Potencier2012-06-102-0/+73
| | | | | | | | component to make it reusable outside the full-stack framework
* | fixed CSFabien Potencier2012-05-181-1/+1
| |
* | fixed phpdoc @param alignmentFabien Potencier2012-05-153-3/+3
| |
* | merged 2.0Fabien Potencier2012-05-112-1/+10
|\ \ | |/
| * [Security] fixed phpdoc.Hugo Hamon2012-05-011-1/+1
| |
| * [Security] added some missing phpdoc for AbstractToken::setUser() and ↵Hugo Hamon2012-05-012-1/+10
| | | | | | | | UsernamePasswordToken::__construct() methods.
* | [Security] fixed English grammar in exception messageDouglas Greenshields2012-05-011-1/+1
| |
* | [Security][ACL] Fixed ObjectIdentity::fromDomainObject and ↵Jordan Alliot2012-04-121-0/+55
| | | | | | | | | | | | | | UserSecurityIdentity::from(Account|Token) when working with proxies Backported ClassUtils class from Doctrine Common 2.2 Fixes #2611, #2056, #2048, #2035
* | fixed CS (missing or misplaced license blocks)Eriksen Costa2012-04-024-8/+8
| |
* | updated license blocksEriksen Costa2012-03-315-15/+15
| |
* | [Security] Use LogoutException for invalid CSRF token in LogoutListenerJeremy Mikola2012-02-141-0/+25
| | | | | | | | | | | | On the advice of @schmittjoh, this commit adds a LogoutException class for use by LogoutListener if the CSRF token is invalid. The handling in the Security component's ExceptionListener is modeled after AccessDeniedException, which gets wrapped in an AccessDeniedHttpException in the absence of handler service or error page (I didn't think it was appropriate to re-use those for LogoutException).
* | add missing class var; add phpdocsGordon Franke2012-01-162-0/+6
| |
* | Add some more tests, and enforce boolean return value of interface ↵Dariusz Górecki2012-01-101-1/+1
| | | | | | | | implementations.
* | When method name is `hasUserChanged` the return boolean should be true (to ↵Dariusz Górecki2012-01-101-11/+11
| | | | | | | | match question semantics) and false when user has not changed, this commits inverts return statements.
* | Add note about `AdvancedUserInterface`.Dariusz Górecki2012-01-101-0/+3
| |
* | Refactor `isUserChanged` to `hasUserChanged`Dariusz Górecki2012-01-101-3/+3
| |
* | Change names to EquatableDariusz Górecki2012-01-102-8/+8
| |
* | Suggested fixes ;)Dariusz Górecki2012-01-101-3/+5
| |
* | [BC Break][Security] Moved user comparsion logic out of UserInterface As ↵Dariusz Górecki2012-01-104-56/+80
| | | | | | | | | | | | | | | | | | | | discussed on IRC meetings and in PR #2669 I came up with implementation. This is option2, I think more elegant. BC break: yes Feature addition: no/feature move Symfony2 test pass: yes Symfony2 test written: yes Todo: feedback needed
* | merged 2.0Fabien Potencier2012-01-093-11/+105
|\ \ | |/
| * fixed CSFabien Potencier2012-01-093-14/+29
| |
| * [Security] Adding more extensive PHPDoc to UserInterface, ↵Ryan Weaver2012-01-073-10/+87
| | | | | | | | AdvancedUserInterface and UserProviderInterface
* | Revert "merged branch kriswallsmith/security/demeter-fix (PR #2816)"Fabien Potencier2011-12-302-23/+0
| | | | | | | | | | This reverts commit 76ba2bc7accbea356c9a5bf5231bf786f50ffd90, reversing changes made to 4730f4303b1a266185226ee05fa9f93f0468a2e1.
* | 'for' was duplicatedJavier López2011-12-281-1/+1
| |
* | merged 2.0Fabien Potencier2011-12-181-3/+3
|\ \ | |/
| * fixed CSFabien Potencier2011-12-181-3/+3
| |
* | fixed CSFabien Potencier2011-12-182-2/+2
| |
* | merged 2.0Fabien Potencier2011-12-137-6/+16
|\ \ | |/
| * [DoctrineBridge] fixed some CSFabien Potencier2011-12-137-6/+17
| |
* | [Security] added SecurityContextInterface::getUser()Kris Wallsmith2011-12-082-0/+23
| | | | | | | | | | | | | | | | | | | | | | | | This changes helps the common use case of fetching the current user and better complies with the Law of Demeter (http://en.wikipedia.org/wiki/Law_of_Demeter). Before (still works): $token = $context->getToken(); $user = $token ? $token->getUser() : null; After: $user = $context->getUser();
* | merged 2.0Fabien Potencier2011-12-081-1/+5
|\ \ | |/
| * [Security] fixed castv2.0.7Fabien Potencier2011-12-071-1/+5
| |
* | added authentication success/failure eventsJohannes Schmitt2011-11-224-0/+110
| |
* | merged 2.0Fabien Potencier2011-11-221-1/+1
|\ \ | |/
| * Fixed small typo in phpdoc.ondrowan2011-11-211-1/+1
| |
* | [Security] made exceptions thrown by the user checker and the ↵Fabien Potencier2011-11-071-11/+19
| | | | | | | | checkAuthentication() method use the hideUserNotFoundExceptions flag
* | merged 2.0Fabien Potencier2011-11-073-4/+4
|\ \ | |/
| * replace occurences of "an UserInteface" with "a UserInterface"Igor Wiedler2011-11-033-4/+4
| |
* | Merge branch '2.0'Fabien Potencier2011-10-291-1/+1
|\ \ | |/ | | | | | | * 2.0: fixed CS
| * fixed CSFabien Potencier2011-10-291-1/+1
| |
* | merged 2.0Fabien Potencier2011-10-296-9/+0
|\ \ | |/
| * removed unused use statementsFabien Potencier2011-10-296-9/+0
| |
* | Removed redundant "@return void"-sHelmer Aaviksoo2011-10-074-7/+0
| |
* | [Security] changed a RuntimeException to LogicException for consistencies ↵Fabien Potencier2011-10-031-1/+1
|/ | | | between the different Token classes (closes #2310)
* CSAbhoryo2011-08-141-3/+4
|
* Search in others user providers when a user is not found in the first user ↵Abhoryo2011-08-141-2/+10
| | | | provider and throws the right exception.
* [Security] change a comparison to use a strict comparisonFabien Potencier2011-07-221-1/+1
|
* [Security] Moved EntityUserProvider to Doctrine Bridgemarc.weistroff2011-07-131-85/+0
|
* [Security] renamed UserProviderInterface::loadUser() to refreshUser()Fabien Potencier2011-06-164-6/+6
|
* [Security] reverted some changes from previous mergeFabien Potencier2011-06-151-1/+1
|
* merged branch kaiwa/loglevel (PR #1073)Fabien Potencier2011-06-151-1/+1
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Commits ------- cdf4b6a Checked log levels a45d3ee Reverted last commit 529381b ControllerNotFound: Changed log level from info to error. Also moved throw exception code block up, to prevent the message from beeing logged multiple times. 7c29e88 Changed log level of "Matched route ..." message from info to debug dca09fd Changed log level of "Using Controller ..." message from info to debug Discussion ---------- Log levels Just wanted to ask if the log level INFO is still correct for these messages? As there are only four log levels left (DEBUG, INFO, WARNING, ERROR), DEBUG might be the more appropriate level for these messages now. Let me give an example: An application is logging user actions (maybe to database) in order to assure comprehensibility, e. g. "User %s deleted post %d", "User %s written a message to user %s". These are not warnings of course, so the only suitable log level is INFO. But they will be thrown together with these very common (at least two per request?) "Using controller..." and "Matched route..." messages when choosing INFO as log level. --------------------------------------------------------------------------- by Seldaek at 2011/05/24 07:13:18 -0700 Agreed, this stuff is framework debug information. --------------------------------------------------------------------------- by fabpot at 2011/05/24 08:53:24 -0700 Why do you want to change these two specific ones? The framework uses the INFO level at other places too. Is it a good idea to say that the framework only logs with DEBUG? --------------------------------------------------------------------------- by stof at 2011/05/24 09:12:53 -0700 Doctrine logs at the INFO level too and I think it is useful to keep it as INFO. Being able to see the queries without having all DEBUG messages of the event dispatcher and security components is useful IMO. --------------------------------------------------------------------------- by Seldaek at 2011/05/25 02:30:24 -0700 Yeah, that's true, maybe we just need to reintroduce (again, meh:) NOTICE between INFO and WARNING. @kaiwa Of course the other way could be that you just add your DB handler to the app logger stack. That could be done in a onCoreRequest listener or such, basically you'd have to call `->pushHandler($yourDBHandler)` on the `monolog.logger.app` service. That way your messages will flow to it, but it won't receive noise from the framework stuff since those log on monolog.logger.request and other log channels. --------------------------------------------------------------------------- by fabpot at 2011/05/25 02:48:26 -0700 @Seldaek: I don't think we need another level. We just need to come up with a standard rules about the usage of each level. Adapted from log4j: * ERROR: Other runtime errors or unexpected conditions. * WARN: Use of deprecated APIs, poor use of API, 'almost' errors, other runtime that are undesirable or unexpected, but not necessarily "wrong" (unable to write to the profiler DB, ). * INFO: Interesting runtime events (security infos like the fact the user is logged-in or not, SQL logs, ...). * DEBUG: Detailed information on the flow through the system (route match, security flow infos like the fact that a token was found or that remember-me cookie is found, ...). What do you think? --------------------------------------------------------------------------- by stloyd at 2011/05/25 02:53:38 -0700 +1 for this standard (also this PR can be merged then), but we should review code for other "wrong" log levels usage (if everyone accept this standard) --------------------------------------------------------------------------- by fabpot at 2011/05/25 02:55:07 -0700 I won't merge this PR before all occurrences of the logger calls have been reviewed carefully and changed to the right level. --------------------------------------------------------------------------- by kaiwa at 2011/05/25 02:58:44 -0700 @fabpot: Just noticed these two occurring for every request in my log file. You are right, there are other places where this changes must be applied if we will change the log level. @stof: Hmm, i see. It is not possible to set the logger separately for each bundle, is it? That maybe would solve the problem. If somebody is interested in seeing the queries, he could set the log handler level to DEBUG for doctrine bundle, but still use INFO for the framwork itself. Plus he could even define a different output file or a completely different handler. I'm not sure if something like that is possible already (?) or realizable at all... just came into my mind. --------------------------------------------------------------------------- by Seldaek at 2011/05/25 03:01:07 -0700 Just FYI, from Monolog\Logger (which has CRITICAL and ALERT): * Debug messages const DEBUG = 100; * Messages you usually don't want to see const INFO = 200; * Exceptional occurences that are not errors * This is typically the logging level you want to use const WARNING = 300; * Errors const ERROR = 400; * Critical conditions (component unavailable, etc.) const CRITICAL = 500; * Action must be taken immediately (entire service down) * Should trigger alert by sms, email, etc. const ALERT = 550; The values kind of match http error codes too, 4xx are expected errors that are not really important (404s etc) and 5xx are server errors that you'd better fix ASAP. I'm ok with the descriptions, but I think alert and critical should be included too. I'll probably update Monolog docblocks to match whatever ends up in the docs. --------------------------------------------------------------------------- by Seldaek at 2011/05/25 03:03:21 -0700 @kaiwa you can do a lot, but not from the default monolog configuration entry, I'm not sure if we can really make that fully configurable without having a giant config mess. Please refer to my [comment above](https://github.com/symfony/symfony/pull/1073#issuecomment-1234316) to see how you could solve it. Maybe @fabpot has an idea how to make this more usable though. --------------------------------------------------------------------------- by stof at 2011/05/25 03:19:43 -0700 @Seldaek the issue is that the different logging channels are only know in the compiler pass, not in the DI extension. So changing the level in the extension is really hard IMO. Thus, the handlers are shared between the different logging channels (needed to open the log file only once for instance, or to send a single mail instead of one per channel) and the level is handled in the handlers, not the logger. I'm +1 for the standard, by adding the distinction between 400 and 500 status calls using ERROR and CRITICAL (which is already the case in the code). @kaiwa do you have time to review the calls to the logger between DEBUG and INFO or do you prefer I do it ? For instance, the Security component currently logs all message at DEBUG level and some of them should be INFO. --------------------------------------------------------------------------- by kaiwa at 2011/05/25 04:31:04 -0700 @stof ok i'll do that --------------------------------------------------------------------------- by kaiwa at 2011/05/25 12:22:51 -0700 Need some help :) I came across `ControllerNameParser::handleControllerNotFoundException()` which leads to redundant log messages currently: >[2011-05-25 20:53:16] request.INFO: Unable to find controller "AppBaseBundle:Blog" - class "App\BaseBundle\Controller\BlogController" does not exist. >[2011-05-25 20:53:16] request.ERROR: InvalidArgumentException: Unable to find controller "AppBaseBundle:Blog" - class "App\BaseBundle\Controller\BlogController" does not exist. (uncaught exception) at /home/ruth/symfony3/src/Symfony/Bundle/FrameworkBundle/Controller/ControllerNameParser.php line 87 Is it necessary to call `$this->logger->info($log);` if the InvalidArgumentException will be logged anyway? --------------------------------------------------------------------------- by stof at 2011/05/25 12:39:22 -0700 Well, the issue is that the ControllerNameParser logs messages and then uses them to throw an exception. I guess the logging call should be removed as it is redundant with the one of the ExceptionListener. @fabpot thoughts ? --------------------------------------------------------------------------- by kaiwa at 2011/05/27 11:39:25 -0700 I checked all debug, info and log calls. Sometimes it is hard to distinguish between the levels, so it would be great if someone reviews @cdf4b6a. @stof, maybe you want to take a look? --------------------------------------------------------------------------- by kaiwa at 2011/05/31 12:52:07 -0700 @stof, thanks for your comments. I added some replies above, please let me know your suggestions. --------------------------------------------------------------------------- by stof at 2011/05/31 14:04:22 -0700 @kaiwa As I said before, all the security logging calls should be DEBUG (most of them) or INFO (the one syaing that authentication succeeded for instance), but not WARN or ERROR as the exception don't go outside the firewall.
| * Checked log levelskaiwa2011-05-271-1/+1
| |
generated by cgit v1.1 at 2025-06-06 19:17:17 +0000