diff options
| author | Timo Tijhof <krinklemail@gmail.com> | 2013-10-12 01:52:45 +0200 |
|---|---|---|
| committer | Timo Tijhof <krinklemail@gmail.com> | 2013-10-12 01:52:45 +0200 |
| commit | 976cde8c0c8acaa2d7e1f4a9c03f8419e942d9f7 (patch) | |
| tree | fda0963722df953b860f17fdde41931f4d8f052a | |
| parent | 7619de73cb3337c6e228569523e037eda0daf217 (diff) | |
| download | fastdom-976cde8c0c8acaa2d7e1f4a9c03f8419e942d9f7.zip fastdom-976cde8c0c8acaa2d7e1f4a9c03f8419e942d9f7.tar.gz fastdom-976cde8c0c8acaa2d7e1f4a9c03f8419e942d9f7.tar.bz2 | |
Various minor clean up
* main: Fix typo in comment
* package: Removed redundant "node_modules/.bin" prefix.
npm script commands are executed in a subshell with that
directory in the execution path:
https://npmjs.org/doc/scripts.html#ENVIRONMENT
So even if the shell running `npm test` didn't install have it
globally, this will work fine.
* Add missing newline at EOF of various files.
* Consistently use single quotes (main js file does so mostly
except for one line).
* Consistently name test suites lowercase (in case of 'defer' and
'clear', like the method names they test).
| -rw-r--r-- | .gitignore | 2 | ||||
| -rw-r--r-- | .npmignore | 2 | ||||
| -rw-r--r-- | .travis.yml | 8 | ||||
| -rw-r--r-- | History.md | 2 | ||||
| -rw-r--r-- | component.json | 2 | ||||
| -rw-r--r-- | index.js | 4 | ||||
| -rw-r--r-- | package.json | 2 | ||||
| -rw-r--r-- | test/test.clear.js | 4 | ||||
| -rw-r--r-- | test/test.set.js | 4 |
9 files changed, 14 insertions, 16 deletions
@@ -1,2 +1,2 @@ node_modules -.DS_Store
\ No newline at end of file +.DS_Store @@ -1,3 +1,3 @@ /node_modules/ /examples/ -/test/
\ No newline at end of file +/test/ diff --git a/.travis.yml b/.travis.yml index 6212d53..f5eb376 100644 --- a/.travis.yml +++ b/.travis.yml @@ -1,7 +1,5 @@ -script: - - "npm test" - language: node_js - node_js: - - "0.10"
\ No newline at end of file + - "0.10" +script: + - "npm test" @@ -11,4 +11,4 @@ * add `FastDom#clear` clears read, write and defer jobs by id * remove `FastDom#clearRead` * remove `FastDom#clearWrite` - * change directory structure by removing `/lib`
\ No newline at end of file + * change directory structure by removing `/lib` diff --git a/component.json b/component.json index 82aa51f..d318c23 100644 --- a/component.json +++ b/component.json @@ -12,4 +12,4 @@ "README.md" ], "license": "MIT" -}
\ No newline at end of file +} @@ -114,7 +114,7 @@ var self = this; // If we are currently writing, we don't - // need to scedule a new frame as this + // need to schedule a new frame as this // job will be emptied from the write queue if (mode === 'writing' && type === 'write') return; @@ -280,7 +280,7 @@ if (typeof module !== 'undefined' && module.exports) { module.exports = fastdom; - } else if (typeof define === "function" && define.amd) { + } else if (typeof define === 'function' && define.amd) { define(function(){ return fastdom; }); } else { window['fastdom'] = fastdom; diff --git a/package.json b/package.json index e4ea0f3..58384df 100644 --- a/package.json +++ b/package.json @@ -4,7 +4,7 @@ "version": "0.7.1", "main": "index.js", "scripts": { - "test": "./node_modules/.bin/mocha-phantomjs test/index.html" + "test": "mocha-phantomjs test/index.html" }, "homepage": "https://github.com/wilsonpage/fastdom", "author": { diff --git a/test/test.clear.js b/test/test.clear.js index ee60f2e..20be9ed 100644 --- a/test/test.clear.js +++ b/test/test.clear.js @@ -1,5 +1,5 @@ -suite('Clear', function(){ +suite('clear', function(){ test("Should not run 'read' job if cleared (sync)", function(done) { var fastdom = new FastDom(); @@ -94,4 +94,4 @@ suite('Clear', function(){ }); }); -});
\ No newline at end of file +}); diff --git a/test/test.set.js b/test/test.set.js index a1dd83c..0ed296b 100644 --- a/test/test.set.js +++ b/test/test.set.js @@ -1,5 +1,5 @@ -suite('Set', function() { +suite('set', function() { test("Should run reads before writes", function(done) { var fastdom = new FastDom(); @@ -184,4 +184,4 @@ suite('Set', function() { done(); }); }); -});
\ No newline at end of file +}); |