diff options
Diffstat (limited to 'src/main.lib/Plugins/TargetPlugins/Manual')
4 files changed, 21 insertions, 20 deletions
diff --git a/src/main.lib/Plugins/TargetPlugins/Manual/Manual.cs b/src/main.lib/Plugins/TargetPlugins/Manual/Manual.cs index 72edb90..de82b5a 100644 --- a/src/main.lib/Plugins/TargetPlugins/Manual/Manual.cs +++ b/src/main.lib/Plugins/TargetPlugins/Manual/Manual.cs @@ -11,18 +11,16 @@ namespace PKISharp.WACS.Plugins.TargetPlugins public Manual(ManualOptions options) => _options = options; - public Task<Target> Generate() + public async Task<Target?> Generate() { - return Task.FromResult(new Target() + return new Target() { FriendlyName = $"[{nameof(Manual)}] {_options.CommonName}", CommonName = _options.CommonName, Parts = new List<TargetPart> { - new TargetPart { - Identifiers = _options.AlternativeNames - } + new TargetPart(_options.AlternativeNames) } - }); + }; } bool IPlugin.Disabled => false; diff --git a/src/main.lib/Plugins/TargetPlugins/Manual/ManualArguments.cs b/src/main.lib/Plugins/TargetPlugins/Manual/ManualArguments.cs index a6199b3..b887b1d 100644 --- a/src/main.lib/Plugins/TargetPlugins/Manual/ManualArguments.cs +++ b/src/main.lib/Plugins/TargetPlugins/Manual/ManualArguments.cs @@ -2,7 +2,7 @@ { internal class ManualArguments { - public string CommonName { get; set; } - public string Host { get; set; } + public string? CommonName { get; set; } + public string? Host { get; set; } } } diff --git a/src/main.lib/Plugins/TargetPlugins/Manual/ManualOptions.cs b/src/main.lib/Plugins/TargetPlugins/Manual/ManualOptions.cs index 2b72f70..f7a8e47 100644 --- a/src/main.lib/Plugins/TargetPlugins/Manual/ManualOptions.cs +++ b/src/main.lib/Plugins/TargetPlugins/Manual/ManualOptions.cs @@ -13,8 +13,8 @@ namespace PKISharp.WACS.Plugins.TargetPlugins public override string Name => "Manual"; public override string Description => DescriptionText; - public string CommonName { get; set; } - public List<string> AlternativeNames { get; set; } + public string? CommonName { get; set; } + public List<string>? AlternativeNames { get; set; } public override void Show(IInputService input) { diff --git a/src/main.lib/Plugins/TargetPlugins/Manual/ManualOptionsFactory.cs b/src/main.lib/Plugins/TargetPlugins/Manual/ManualOptionsFactory.cs index c0b3fb6..363f839 100644 --- a/src/main.lib/Plugins/TargetPlugins/Manual/ManualOptionsFactory.cs +++ b/src/main.lib/Plugins/TargetPlugins/Manual/ManualOptionsFactory.cs @@ -11,7 +11,7 @@ namespace PKISharp.WACS.Plugins.TargetPlugins private readonly IArgumentsService _arguments; public ManualOptionsFactory(IArgumentsService arguments) => _arguments = arguments; public override int Order => 5; - public override async Task<ManualOptions> Aquire(IInputService inputService, RunLevel runLevel) + public override async Task<ManualOptions?> Aquire(IInputService inputService, RunLevel runLevel) { var input = await inputService.RequestString("Enter comma-separated list of host names, starting with the common name"); if (string.IsNullOrEmpty(input)) @@ -24,25 +24,28 @@ namespace PKISharp.WACS.Plugins.TargetPlugins } } - public override Task<ManualOptions> Default() + public override async Task<ManualOptions?> Default() { var args = _arguments.GetArguments<ManualArguments>(); var input = _arguments.TryGetRequiredArgument(nameof(args.Host), args.Host); var ret = Create(input); - var commonName = args.CommonName; - if (!string.IsNullOrWhiteSpace(commonName)) + if (ret != null) { - commonName = commonName.ToLower().Trim().ConvertPunycode(); - ret.CommonName = commonName; - if (!ret.AlternativeNames.Contains(commonName)) + var commonName = args.CommonName; + if (!string.IsNullOrWhiteSpace(commonName)) { - ret.AlternativeNames.Insert(0, commonName); + commonName = commonName.ToLower().Trim().ConvertPunycode(); + ret.CommonName = commonName; + if (!ret.AlternativeNames.Contains(commonName)) + { + ret.AlternativeNames.Insert(0, commonName); + } } } - return Task.FromResult(ret); + return ret; } - private ManualOptions Create(string input) + private ManualOptions? Create(string? input) { var sanList = input.ParseCsv().Select(x => x.ConvertPunycode()); if (sanList != null) |