summaryrefslogtreecommitdiffstats
path: root/lib/plugins
diff options
context:
space:
mode:
Diffstat (limited to 'lib/plugins')
-rw-r--r--lib/plugins/__tests__/sortPlugins.js86
-rw-r--r--lib/plugins/loadForBook.js15
-rw-r--r--lib/plugins/sortPlugins.js47
3 files changed, 59 insertions, 89 deletions
diff --git a/lib/plugins/__tests__/sortPlugins.js b/lib/plugins/__tests__/sortPlugins.js
index 2e1b594..c50c851 100644
--- a/lib/plugins/__tests__/sortPlugins.js
+++ b/lib/plugins/__tests__/sortPlugins.js
@@ -1,70 +1,50 @@
var PluginDependency = require('../../models/pluginDependency');
var sortPlugins = require('../sortPlugins');
var listAll = require('../listAll');
-var THEME_PREFIX = require('../../constants/themePrefix');
-
-
-/**
- Check if a plugin is a theme given its name
-
- @return {Boolean}
-*/
-function isTheme(name) {
- return (name && name.indexOf(THEME_PREFIX) === 0);
-}
describe('sortPlugins', function() {
it('must load themes after plugins', function() {
var deps = PluginDependency.listFromString('theme-faq'),
allPlugins = listAll(deps);
- return sortPlugins(allPlugins, [])
- .then(function(sorted) {
- var plugins = sorted.slice(0, -2),
- themes = sorted.slice(-2);
-
- var pluginsOk = plugins.every(function(plugin) {
- return !isTheme(plugin.getName());
- });
-
- var themesOk = themes.every(function(theme) {
- return isTheme(theme.getName());
- });
-
- expect(pluginsOk).toBe(true);
- expect(plugins.has('search')).toBe(true);
-
- expect(themesOk).toBe(true);
- expect(themes.size).toBe(2);
- expect(themes.has('theme-faq')).toBe(true);
- expect(themes.has('theme-default')).toBe(true);
- });
+ var sorted = sortPlugins(allPlugins, []);
+ var names = sorted
+ .map(function(plugin) {
+ return plugin.getName();
+ })
+ .toArray();
+
+ expect(names).toEqual([
+ 'fontsettings',
+ 'sharing',
+ 'lunr',
+ 'search',
+ 'highlight',
+ 'theme-faq',
+ 'theme-default'
+ ]);
});
it('must load themes after plugins with a complex dependencies list', function() {
var deps = PluginDependency.listFromString('comment,theme-faq,-search,ga'),
allPlugins = listAll(deps);
- return sortPlugins(allPlugins, [])
- .then(function(sorted) {
- var plugins = sorted.slice(0, -2),
- themes = sorted.slice(-2);
-
- var pluginsOk = plugins.every(function(plugin) {
- return !isTheme(plugin.getName());
- });
-
- var themesOk = themes.every(function(theme) {
- return isTheme(theme.getName());
- });
-
- expect(pluginsOk).toBe(true);
- expect(plugins.has('search')).toBe(false);
-
- expect(themesOk).toBe(true);
- expect(themes.size).toBe(2);
- expect(themes.has('theme-faq')).toBe(true);
- expect(themes.has('theme-default')).toBe(true);
- });
+ var sorted = sortPlugins(allPlugins, []);
+ var names = sorted
+ .map(function(plugin) {
+ return plugin.getName();
+ })
+ .toArray();
+
+ expect(names).toEqual([
+ 'ga',
+ 'comment',
+ 'fontsettings',
+ 'sharing',
+ 'lunr',
+ 'highlight',
+ 'theme-faq',
+ 'theme-default'
+ ]);
});
}); \ No newline at end of file
diff --git a/lib/plugins/loadForBook.js b/lib/plugins/loadForBook.js
index fd45a77..296cb01 100644
--- a/lib/plugins/loadForBook.js
+++ b/lib/plugins/loadForBook.js
@@ -7,11 +7,10 @@ var sortPlugins = require('./sortPlugins');
/**
- Load a list of plugins in a book
-
- @param {Book}
- @return {Promise<Map<String:Plugin>}
-*/
+ * Load a list of plugins in a book
+ * @param {Book}
+ * @return {Promise<Map<String:Plugin>}
+ */
function loadForBook(book) {
var logger = book.getLogger();
var requirements = listForBook(book);
@@ -28,9 +27,9 @@ function loadForBook(book) {
);
});
- return sortPlugins(installed, requirementsKeys);
- })
- .then(function(installed) {
+ // Sort plugins
+ installed = sortPlugins(installed, requirementsKeys);
+
// Log state
logger.info.ln(installed.size + ' plugins are installed');
if (requirements.size != installed.size) {
diff --git a/lib/plugins/sortPlugins.js b/lib/plugins/sortPlugins.js
index 6626936..e96b02c 100644
--- a/lib/plugins/sortPlugins.js
+++ b/lib/plugins/sortPlugins.js
@@ -1,44 +1,35 @@
-var Promise = require('../utils/promise');
-
var THEME_PREFIX = require('../constants/themePrefix');
var LOADING_ORDER = ['plugin', 'theme'];
/**
- Returns the type of a plugin given its name
-
- @return {String}
-*/
+ * Returns the type of a plugin given its name
+ * @return {String}
+ */
function pluginType(name) {
return (name && name.indexOf(THEME_PREFIX) === 0) ? 'theme' : 'plugin';
}
/**
- Sort the list of installed plugins to match list in book.json
- The themes should always be loaded after the plugins
-
- @param {<OrderedMap<String:Plugin>>} plugins
- @param {<List<String>>} requirementsKeys
- @return {Promise<OrderedMap<String:Plugin>>}
-*/
-
+ * Sort the list of installed plugins to match list in book.json
+ * The themes should always be loaded after the plugins
+ *
+ * @param {<OrderedMap<String:Plugin>>} plugins
+ * @param {<List<String>>} requirementsKeys
+ * @return {OrderedMap<String:Plugin>}
+ */
function sortPlugins(plugins, requirementsKeys) {
- return Promise()
- .then(function() {
- // Sort plugins to match list in book.json
- plugins = plugins.sort(function(a, b) {
- // Get order from book.json
- var definitionOrder = requirementsKeys.indexOf(a.getName()) < requirementsKeys.indexOf(b.getName());
-
- // Get order from plugins a and b type
- var aType = pluginType(a.getName()),
- bType = pluginType(b.getName()),
- loadingOrder = LOADING_ORDER.indexOf(aType) < LOADING_ORDER.indexOf(bType);
+ // Sort plugins to match list in book.json
+ return plugins.sort(function(a, b) {
+ // Get order from book.json
+ var definitionOrder = requirementsKeys.indexOf(a.getName()) < requirementsKeys.indexOf(b.getName());
- return loadingOrder || definitionOrder ? -1 : 1;
- });
+ // Get order from plugins a and b type
+ var aType = pluginType(a.getName()),
+ bType = pluginType(b.getName()),
+ loadingOrder = LOADING_ORDER.indexOf(aType) < LOADING_ORDER.indexOf(bType);
- return plugins;
+ return loadingOrder || definitionOrder ? -1 : 1;
});
}
generated by cgit v1.1 at 2025-05-12 15:43:52 +0000